linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Hugh Dickins <hughd@google.com>, Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: mmotm woes, mainly compaction
Date: Tue, 12 Apr 2016 11:38:30 +0200	[thread overview]
Message-ID: <570CC216.8030201@suse.cz> (raw)
In-Reply-To: <alpine.LSU.2.11.1604120005350.1832@eggly.anvils>

On 04/12/2016 09:18 AM, Hugh Dickins wrote:
> 1. Fix crash in release_pages() from compact_zone() from kcompactd_do_work():
>     kcompactd needs to INIT_LIST_HEAD on the new freepages_held list.

Hmm, right. I didn't notice the new call site added by one series when 
rebasing the other series :/

> 4. Added VM_BUG_ONs to assert freepages_held is empty, matching those on
>     the other lists - though they're getting to look rather too much now.

I think the easiest thing to do for now is to drop from mmotm:
mm-compaction-direct-freepage-allocation-for-async-direct-compaction.patch
As Mel and Joonsoo didn't like it in the current state anyway.

> 6. Remove unused bool success from kcompactd_do_work().

That leaves just this part, which didn't fit anywhere else. I guess can 
just fold it to upcoming kcompactd patches?

Thanks for organizing my morning today, Hugh :)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2016-04-12  9:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-12  7:18 mmotm woes, mainly compaction Hugh Dickins
2016-04-12  8:03 ` Vlastimil Babka
2016-04-12  9:03 ` Vlastimil Babka
2016-04-12  9:14   ` Vlastimil Babka
2016-04-12  9:31 ` Vlastimil Babka
2016-04-12  9:38 ` Vlastimil Babka [this message]
2016-04-12 12:10 ` Michal Hocko
2016-04-12 14:51   ` Michal Hocko
2016-04-14 20:15   ` Hugh Dickins
2016-04-14 23:24     ` Vlastimil Babka
2016-04-15  1:00       ` Hugh Dickins
2016-04-18 19:14       ` Vlastimil Babka
2016-04-15  8:42     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570CC216.8030201@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).