From: Xishi Qiu <qiuxishi@huawei.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: mce: a question about memory_failure_early_kill in memory_failure()
Date: Wed, 20 Apr 2016 18:58:59 +0800 [thread overview]
Message-ID: <571760F3.2040305@huawei.com> (raw)
In-Reply-To: <57175F30.6050300@huawei.com>
On 2016/4/20 18:51, Xishi Qiu wrote:
> On 2016/4/20 15:07, Naoya Horiguchi wrote:
>
>> On Tue, Apr 19, 2016 at 07:13:34PM +0800, Xishi Qiu wrote:
>>> /proc/sys/vm/memory_failure_early_kill
>>>
>>> 1: means kill all processes that have the corrupted and not reloadable page mapped.
>>> 0: means only unmap the corrupted page from all processes and only kill a process
>>> who tries to access it.
>>>
>>> If set memory_failure_early_kill to 0, and memory_failure() has been called.
>>> memory_failure()
>>> hwpoison_user_mappings()
>>> collect_procs() // the task(with no PF_MCE_PROCESS flag) is not in the tokill list
>>> try_to_unmap()
>>>
>>> If the task access the memory, there will be a page fault,
>>> so the task can not access the original page again, right?
>>
>> Yes, right. That's the behavior in default "late kill" case.
>>
>
> Hi Naoya,
>
> Thanks for your reply, my confusion is that after try_to_unmap(), there will be a
> page fault if the task access the memory, and we will alloc a new page for it.
>
Hi Naoya,
If we alloc a new page, the task won't access the poisioned page again, so it won't be
killed by mce(late kill), right?
If the poisioned page is anon, we will lost data, right?
Thanks,
Xishi Qiu
> So how the hardware(mce) know this page fault is relate to the poisioned page which
> is unmapped from the task?
>
> Will we record something in pte when after try_to_unmap() in memory_failure()?
>
> Thanks,
> Xishi Qiu
>
>> I'm guessing that you might have a more specific problem around this code.
>> If so, please feel free to ask with detail.
>>
>> Thanks,
>> Naoya Horiguchi
>>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-04-20 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 11:13 mce: a question about memory_failure_early_kill in memory_failure() Xishi Qiu
2016-04-20 7:07 ` Naoya Horiguchi
2016-04-20 10:51 ` Xishi Qiu
2016-04-20 10:58 ` Xishi Qiu [this message]
2016-04-20 23:15 ` Naoya Horiguchi
2016-04-21 3:17 ` Xishi Qiu
2016-04-21 8:20 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571760F3.2040305@huawei.com \
--to=qiuxishi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).