From: Vlastimil Babka <vbabka@suse.cz>
To: Xishi Qiu <qiuxishi@huawei.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
"'Kirill A . Shutemov'" <kirill.shutemov@linux.intel.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Alexander Duyck <alexander.h.duyck@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()
Date: Thu, 12 May 2016 14:05:01 +0200 [thread overview]
Message-ID: <5734716D.1070401@suse.cz> (raw)
In-Reply-To: <57346FD6.6000306@huawei.com>
On 05/12/2016 01:58 PM, Xishi Qiu wrote:
> On 2016/5/12 19:36, Vlastimil Babka wrote:
>
>> On 05/09/2016 12:02 PM, Xishi Qiu wrote:
>>
>> Sounds ok, please try.
>>
>
> Hi Vlastimil and Naoya,
>
> The mainline doesn't have this problem, because commit
> add05cecef80 ("mm: soft-offline: don't free target page in successful
> page migration") fixed it in v4.2.
>
> I guess the above patch can't be applied to older kernel directly.
> So shall we rewrite a new one or backport the whole patches which it depend?
I think it makes most sense here to write a <4.2 specific patch and send
it just to stable. If the alternative of backporting add05cecef80 would
be disruptive, mention that in the changelog. Try to pinpoint the commit
that introduced the bug so the fix can have a proper "Fixes:" header.
> Thanks,
> Xishi Qiu
>
>>>
>>> Thanks,
>>> Xishi Qiu
>>>
>>>>> for (found = 0, iter = 0; iter < pageblock_nr_pages; iter++) {
>>>>> unsigned long check = pfn + iter;
>>
>>
>> .
>>
>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2016-05-12 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 8:34 [PATCH] mm: fix pfn spans two sections in has_unmovable_pages() Xishi Qiu
2016-05-09 9:39 ` Vlastimil Babka
2016-05-09 10:02 ` Xishi Qiu
2016-05-12 9:27 ` Naoya Horiguchi
2016-05-12 11:36 ` Vlastimil Babka
2016-05-12 11:58 ` Xishi Qiu
2016-05-12 12:05 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5734716D.1070401@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).