From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f199.google.com (mail-ig0-f199.google.com [209.85.213.199]) by kanga.kvack.org (Postfix) with ESMTP id A0A4A6B0005 for ; Thu, 19 May 2016 21:32:58 -0400 (EDT) Received: by mail-ig0-f199.google.com with SMTP id sq19so189702121igc.0 for ; Thu, 19 May 2016 18:32:58 -0700 (PDT) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com. [58.251.152.64]) by mx.google.com with ESMTPS id vx9si2039585igc.92.2016.05.19.18.32.57 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 19 May 2016 18:32:58 -0700 (PDT) Subject: Re: [PATCH] mm: compact: fix zoneindex in compact References: <1463659121-84124-1-git-send-email-puck.chen@hisilicon.com> <573DAD84.7020403@suse.cz> <573DADF7.4000109@suse.cz> <9741ef6d-b93b-a99b-e42f-9f510295dd3f@suse.cz> From: Chen Feng Message-ID: <573E68AC.5070103@hisilicon.com> Date: Fri, 20 May 2016 09:30:20 +0800 MIME-Version: 1.0 In-Reply-To: <9741ef6d-b93b-a99b-e42f-9f510295dd3f@suse.cz> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka , Hugh Dickins Cc: mhocko@suse.com, kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, tj@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , suzhuangluan@hisilicon.com, dan.zhao@hisilicon.com, qijiwen@hisilicon.com, xuyiping@hisilicon.com, oliver.fu@hisilicon.com, puck.chen@foxmail.com On 2016/5/20 1:45, Vlastimil Babka wrote: > On 19.5.2016 19:23, Hugh Dickins wrote: >> On Thu, 19 May 2016, Vlastimil Babka wrote: >>> On 05/19/2016 02:11 PM, Vlastimil Babka wrote: >>>> On 05/19/2016 01:58 PM, Chen Feng wrote: >>>>> While testing the kcompactd in my platform 3G MEM only DMA ZONE. >>>>> I found the kcompactd never wakeup. It seems the zoneindex >>>>> has already minus 1 before. So the traverse here should be <=. >>>> >>>> Ouch, thanks! >>>> >>>>> Signed-off-by: Chen Feng >>>> >>>> Fixes: 0f87baf4f7fb ("mm: wake kcompactd before kswapd's short sleep") >>> >>> Bah, not that one. >>> >>> Fixes: accf62422b3a ("mm, kswapd: replace kswapd compaction with waking >>> up kcompactd") >>> >>>> Cc: stable@vger.kernel.org >>>> Acked-by: Vlastimil Babka >>>> >>>>> --- >>>>> mm/compaction.c | 2 +- >>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>> >>>>> diff --git a/mm/compaction.c b/mm/compaction.c >>>>> index 8fa2540..e5122d9 100644 >>>>> --- a/mm/compaction.c >>>>> +++ b/mm/compaction.c >>>>> @@ -1742,7 +1742,7 @@ static bool kcompactd_node_suitable(pg_data_t *pgdat) >>>>> struct zone *zone; >>>>> enum zone_type classzone_idx = pgdat->kcompactd_classzone_idx; >>>>> >>>>> - for (zoneid = 0; zoneid < classzone_idx; zoneid++) { >>>>> + for (zoneid = 0; zoneid <= classzone_idx; zoneid++) { >>>>> zone = &pgdat->node_zones[zoneid]; >>>>> >>>>> if (!populated_zone(zone)) >> >> Ignorant question: kcompactd_do_work() just below has a similar loop: > > You spelled "Important" wrong. > >> should that one be saying "zoneid <= cc.classzone_idx" too? > > Yes. Chen, can you send updated patch (also with the ack/cc/fixes tags I added?) > kcompactd_do_work() This fix already added by Andrew Morton I will not sent it. > Thanks! > >> Hugh >> > > > . > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org