From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id 3F6116B0253 for ; Wed, 1 Jun 2016 13:10:39 -0400 (EDT) Received: by mail-io0-f200.google.com with SMTP id h5so40764746ioh.1 for ; Wed, 01 Jun 2016 10:10:39 -0700 (PDT) Received: from blackbird.sr71.net ([2001:19d0:2:6:209:6bff:fe9a:902]) by mx.google.com with ESMTP id n8si12688609paw.216.2016.06.01.10.10.38 for ; Wed, 01 Jun 2016 10:10:38 -0700 (PDT) Subject: Re: [PATCH 7/8] pkeys: add details of system call use to Documentation/ References: <20160531152814.36E0B9EE@viggo.jf.intel.com> <20160531152824.2B18E890@viggo.jf.intel.com> <20160601104333.7c2014fa@lwn.net> <574F114F.8010701@sr71.net> <20160601104937.098a89a2@lwn.net> From: Dave Hansen Message-ID: <574F170C.7060302@sr71.net> Date: Wed, 1 Jun 2016 10:10:36 -0700 MIME-Version: 1.0 In-Reply-To: <20160601104937.098a89a2@lwn.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Jonathan Corbet Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, dave.hansen@linux.intel.com On 06/01/2016 09:49 AM, Jonathan Corbet wrote: >> > + sys_pkey_alloc(0, PKEY_DISABLE_WRITE | PKEY_DISABLE_READ); >> > + sys_pkey_mprotect(ptr, size, PROT_READ|PROT_WRITE); >> > + something(ptr); > That should, IMO, be something like: > > key = pkey_alloc(...); > pkey_mprotect(ptr, size, PROT_READ|PROT_WRITE, key); That is true as well. I'll fix that up as well. Thanks for taking a look! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org