Re: [PATCH] mm: mglru: use pte_table_clamped_end() helper to calculate the end

["David Hildenbrand (Arm)" <david@kernel.org>]

On 11/13/26 12:54, Baolin Wang wrote:
> 
> 
> On 11/13/26 7:13 PM, sashiko-bot@kernel.org wrote:
>> Thank you for your contribution! Sashiko AI review found 1 potential
>> issue to consider:
>> - [High] mm: mglru: call to undeclared pte_table_clamped_end() in
>>    lru_gen_look_around()
>> -- 
>>
>> commit 921adf1dcfd3cc8b15e0745e6085a76a09ac3fb5
>> Author: Baolin Wang <baolin.wang@linux.alibaba.com>
>>
>> mm: mglru: use pte_table_clamped_end() helper to calculate the end
>>
>> This commit replaces the open-coded PTE table and VMA end address
>> calculation in lru_gen_look_around() with pte_table_clamped_end().
>>
>>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>>> index 25a224746c36d..cb8635e41a38a 100644
>>> --- a/mm/vmscan.c
>>> +++ b/mm/vmscan.c
>>> @@ -4340,7 +4340,7 @@ bool lru_gen_look_around(struct page_vma_mapped_walk
>>> *pvmw, unsigned int nr)
>>>       walk = current->reclaim_state ? current->reclaim_state->mm_walk : NULL;
>>>         start = max(addr & PMD_MASK, vma->vm_start);
>>> -    end = min(addr | ~PMD_MASK, vma->vm_end - 1) + 1;
>>> +    end = pte_table_clamped_end(addr, vma->vm_end);
>>
>> [Severity: High]
>> Does this break the build when CONFIG_LRU_GEN is enabled?
>> pte_table_clamped_end() is not declared or defined anywhere in the tree,
>> so compiling mm/vmscan.c fails with an implicit function declaration
>> error.
> 
> No. Because you applied the patch to the wrong tree (mm/mm-new). The helper has
> already been picked up in David's mm/core.git tree.

I'll get the relevant fix upstream next week. Once Andrew rebases he will be
able to pick this patch up :)

-- 
Cheers,

David