linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Dmitry Vyukov <dvyukov@google.com>,
	akpm@linux-foundation.org, glider@google.com,
	kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH] kasan: add newline to messages
Date: Thu, 30 Jun 2016 16:48:27 +0300	[thread overview]
Message-ID: <5775232B.2070607@virtuozzo.com> (raw)
In-Reply-To: <1467294357-98002-1-git-send-email-dvyukov@google.com>



On 06/30/2016 04:45 PM, Dmitry Vyukov wrote:
> Currently GPF messages with KASAN look as follows:
> kasan: GPF could be caused by NULL-ptr deref or user memory accessgeneral protection fault: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
> Add newlines.
> 
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>

Acked-by: Andrey Ryabinin <aryabinin@virtuozzo.com>

> ---
>  arch/x86/mm/kasan_init_64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/mm/kasan_init_64.c b/arch/x86/mm/kasan_init_64.c
> index 1b1110f..0493c17 100644
> --- a/arch/x86/mm/kasan_init_64.c
> +++ b/arch/x86/mm/kasan_init_64.c
> @@ -54,8 +54,8 @@ static int kasan_die_handler(struct notifier_block *self,
>  			     void *data)
>  {
>  	if (val == DIE_GPF) {
> -		pr_emerg("CONFIG_KASAN_INLINE enabled");
> -		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access");
> +		pr_emerg("CONFIG_KASAN_INLINE enabled\n");
> +		pr_emerg("GPF could be caused by NULL-ptr deref or user memory access\n");
>  	}
>  	return NOTIFY_OK;
>  }
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-06-30 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-30 13:45 [PATCH] kasan: add newline to messages Dmitry Vyukov
2016-06-30 13:48 ` Andrey Ryabinin [this message]
2016-08-31  2:07   ` amanda4ray
2016-09-08  0:03     ` bethelpchalfant
2017-01-30  9:58 ` lukefrierson888

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5775232B.2070607@virtuozzo.com \
    --to=aryabinin@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).