From: Dave Hansen <dave.hansen@intel.com>
To: Robert Ho <robert.hu@intel.com>,
pbonzini@redhat.com, akpm@linux-foundation.org, mhocko@suse.com,
oleg@redhat.com, dan.j.williams@intel.com
Cc: guangrong.xiao@linux.intel.com, gleb@kernel.org,
mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, stefanha@redhat.com,
yuhuang@redhat.com, linux-mm@kvack.org,
ross.zwisler@linux.intel.com
Subject: Re: [PATCH v3 2/2] Documentation/filesystems/proc.txt: Add more description for maps/smaps
Date: Fri, 23 Sep 2016 09:06:10 -0700 [thread overview]
Message-ID: <57E552F2.4030302@intel.com> (raw)
In-Reply-To: <1474636354-25573-2-git-send-email-robert.hu@intel.com>
On 09/23/2016 06:12 AM, Robert Ho wrote:
> +Note: for both /proc/PID/maps and /proc/PID/smaps readings, it's
> +possible in race conditions, that the mappings printed may not be that
> +up-to-date, because during each read walking, the task's mappings may have
> +changed, this typically happens in multithread cases. But anyway in each single
> +read these can be guarunteed: 1) the mapped addresses doesn't go backward; 2) no
> +overlaps 3) if there is something at a given vaddr during the entirety of the
> +life of the smaps/maps walk, there will be some output for it.
Could we spuce this description up a bit? Perhaps:
Note: reading /proc/PID/maps or /proc/PID/smaps is inherently racy.
This typically manifests when doing partial reads of these files while
the memory map is being modified. Despite the races, we do provide the
following guarantees:
1) The mapped addresses never go backwards, which implies no two
regions will ever overlap.
2) If there is something at a given vaddr during the entirety of the
life of the smaps/maps walk, there will be some output for it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-23 16:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:12 [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps Robert Ho
2016-09-23 13:12 ` [PATCH v3 2/2] Documentation/filesystems/proc.txt: Add more description for maps/smaps Robert Ho
2016-09-23 16:06 ` Dave Hansen [this message]
2016-09-28 2:27 ` Robert Hu
2016-09-23 13:50 ` [PATCH v3 1/2] mm, proc: Fix region lost in /proc/self/smaps Michal Hocko
2016-09-23 14:39 ` Michal Hocko
2016-09-23 13:56 ` Oleg Nesterov
2016-09-23 14:53 ` Michal Hocko
2016-09-23 15:53 ` Oleg Nesterov
2016-09-26 8:46 ` Michal Hocko
2016-09-29 13:14 ` Robert Hu
2016-09-29 13:42 ` Michal Hocko
2016-09-29 13:05 ` Robert Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E552F2.4030302@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mtosatti@redhat.com \
--cc=oleg@redhat.com \
--cc=pbonzini@redhat.com \
--cc=robert.hu@intel.com \
--cc=ross.zwisler@linux.intel.com \
--cc=stefanha@redhat.com \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).