From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E724C636CC for ; Mon, 13 Feb 2023 23:52:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B97FF6B0078; Mon, 13 Feb 2023 18:52:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B47986B007B; Mon, 13 Feb 2023 18:52:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0F3F6B007D; Mon, 13 Feb 2023 18:52:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 91A736B0078 for ; Mon, 13 Feb 2023 18:52:16 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 692EE80AF2 for ; Mon, 13 Feb 2023 23:52:16 +0000 (UTC) X-FDA: 80463919872.02.112059F Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf06.hostedemail.com (Postfix) with ESMTP id 4004218000B for ; Mon, 13 Feb 2023 23:52:14 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gchDyH70; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676332334; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BdZCDSNC/Y2cwwjf/KhiXCY0ZchgqgiAf18khssJ7Sk=; b=02ACGF5/s6kR90d41O/BYLRD7t5LQHLRs0YuguHAVc3qSVfC7LJjaTgZKJKEC+jNEPx7P/ 48B/+hABfLh8NI4t3BdYEzcFme7oZfBKLeeAb/8Siq13P9i3TBEJILIu+RMFMRz1ActsXO I2rUayMsr9acgwz4J7W7tmu+PV5lTnU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gchDyH70; spf=pass (imf06.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676332334; a=rsa-sha256; cv=none; b=B88L+VAWacU2g19H8MQkYB/qs90+eQuVq/aalmJEMd6vtTsHj8LWnE/N5LDgSedEOOZ+11 lWvQVvIwzReNiACX8pocejj4sxJFcCg2n/r7CrvHLswYXsEcp/nn1CExQ4DWf6G3gAjv1e 6geVBfhHbBslBPDmkG6mlaaUmWAJulc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676332334; x=1707868334; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=4fzPXXlr+NKT3FMdKI22Byml/iVzpZd9hBiHmFnYHyY=; b=gchDyH70cxVyoC7hHu5JWTcXenkA3F0X+kRZBvMY2nL57MZOvpA50kyR 2AVNLp3a9bBkJ5mOdPBG2ViBUl7O7vbBYgBt9RE8RpwsOiLfN7WoxjV4V CMvapVmn7JkEsPpo6M5ul0D6sceyt6BygFNe+LNOvV2DQeJL+Lg7P4wwY ZsEasRxt6kxU0TyrPQo4UHLdjCWJZa8n1UDdxYiIpHJ/gm7U3hyc5NLsS ETAI8g8GyyeeEvklCQpGk5moKwjrphXWaX6E4ZdcouUf5in1OISU0i/TR +o9K2Q3H9GuOTRX4FXp4RJTpu6rD9wAgiePcqTRLmoR4Q7HCOtwfRbUVY w==; X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="417248464" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="417248464" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 15:52:12 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10620"; a="792905130" X-IronPort-AV: E=Sophos;i="5.97,294,1669104000"; d="scan'208";a="792905130" Received: from mlswanso-mobl.amr.corp.intel.com (HELO [10.251.26.232]) ([10.251.26.232]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 15:52:11 -0800 Message-ID: <5803a3f2-72c8-fb1e-9ba3-e52747c990d3@intel.com> Date: Mon, 13 Feb 2023 15:52:11 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v9 07/18] x86/virt/tdx: Do TDX module per-cpu initialization Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "david@redhat.com" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "tglx@linutronix.de" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <557c526a1190903d11d67c4e2c76e01f67f6eb15.1676286526.git.kai.huang@intel.com> <2d9172c5-e1e7-bf94-c52b-0e9bc5b5b319@intel.com> <2d7141b1-1d76-4e67-60d2-471a524c372e@intel.com> <8e9238bbcccedfa00e2dbec87e1d77d370911846.camel@intel.com> From: Dave Hansen In-Reply-To: <8e9238bbcccedfa00e2dbec87e1d77d370911846.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4004218000B X-Stat-Signature: f9nqqxmsriptsku97ft7sccg71rc5b7h X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676332334-638282 X-HE-Meta: U2FsdGVkX18wbr5UttivuW2GPO9qN6H8zdA4LL9g8PDImOYwRrbTe9sNT9Wp3AsFHVOszcznBwrvV5a7ZbrdQm2C3dthMwXj9UvyMfzI378MCD1bEme6JUvNFD1i/mq9VqyHRxUGnj4EIPRkxrgBGQAKtZ0xftIyQzWXrh83dA9XjC9OsrS8ckxToLLuZISDTxs/XOIuuZBIFQ4nTUcQ653aThxJ/9u/V+BMWEjSMw/hv5g+Iyv2xaD/C2GmCte1LNNcuE1MntdDmKvc+xhar5CvsBlBHiprmumuAOrexYrzalX0Pk0IBJvLH+yYO8IE2wcHBb4whhyGJGOWhV4j+RbkgWuvKnokJDqV8wMzjC5LrhbtOuOmJdmSeTIHOnCclQ9mGrZtY1PV1d2fiORuSK2gJfz6aOG5+f2mLzn5SLURMjYgqE+tvk2+9btIPOwMM/IBv7FELDkUk1TTmsoZ0OBZ6ZYI/QpL81m1G5h9ZLt9sjPQLYgwtbyY0gaoyQ/6U/TazQ+muaAkmv41prrsqE9yDh8qN1poptXtr6y0glmEgltiJu+R6Moos8G1hG8qyXmptnroBQU3FMSS0WtwlrIzTv6+Ymzp+1Wf59NuR0JNPWdbl3COnpUVtcTkfG7DOskRhNrg20pre64pEcdEqg5NURJ6FSGXorbWjDd3hA9tiZWf5jTOC6inXFEL+YV2zveEDuGrp63e28BQ3MrdJYPM+3yZ5/Jz7rPj1Gt66i+u4xJ6ODrRqIXxU/fubMpMNPWx0Ag29m5/jU6LI3OfwFKyC1HnUBDwxiZKVSxqCeWl7S0XKoQM1EK5G8xqQUzjl+LQpIHpOerDKNhMhFUO2k+xT7VetXwkCHIKdIc0wn5KOE37mUI9Bvc6xmz3skEmyR3a59ACaRxHPq6RBYI0gKWczsavHsGvDBFoajiq0zLsPecdOsVvh9baXT8PchXibP1QPljy+9rxCJP8VQe 9iVHDpRn 8lIq8JROeXW0zS4SogY+tpufPdPCinc/w//TqdRQbIwIMvkIqH5TfC6dqcHz0NRnuevoCSdqYrXIX9BCZS1mm/QM/Fni1OOi6oL5WvLchBRzlReN0Uo9UcXlMWx1VaUogcEd/wZORPpWCjiJPtYptNGBWfPfXcekIl6zEV46NBx10rj2evyWJB3MavGTvLRVqv7ZvIFVQDYirwlM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/13/23 15:43, Huang, Kai wrote: > ( My main concern is "Run after the KVM handler" seems a little bit hacky to me. > Logically, it's more reasonable to have the TDX callback _before_ KVM's but not > _after_. If any user (KVM) has done tdx_enable() successfully, the TDX code > should give the user a "TDX-runnable" cpu before user (KVM)'s own callback is > involved. Anyway as mentioned above, I'll do above as you suggested.) I was assuming that the KVM callback is what does VMXON for a given logical CPU. If that were the case, you'd need to do the TDX stuff *AFTER* VMXON. Am I wrong?