From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440AAC83F22 for ; Thu, 17 Jul 2025 14:48:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D8AA88D000B; Thu, 17 Jul 2025 10:48:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D3B3B8D0001; Thu, 17 Jul 2025 10:48:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2A458D000B; Thu, 17 Jul 2025 10:48:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id ACA138D0001 for ; Thu, 17 Jul 2025 10:48:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5B5D016078A for ; Thu, 17 Jul 2025 14:48:46 +0000 (UTC) X-FDA: 83674038252.02.F70C0D9 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by imf02.hostedemail.com (Postfix) with ESMTP id 779EE8000F for ; Thu, 17 Jul 2025 14:48:44 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=USLaIKjO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752763724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Iw/Wu22cnB7NCngBl0TR+xjDDf5pHdg2GDKrviJBZ3c=; b=CNm6YEGOQZGJ/sEpfthU6ZPb96KNwi6/dMMpMFUvkaxxlOk/g+mWWZL4oG/1z4jI3UxPfS kKh/Q0PqN6KwXYdoMqHfa+pI25LWdIsM8WTkrUV+Y86jc+tz+DFjDnl5PkBua2vCOlZfnQ RxV9pO0ezfVSrj2Dadqkty1BnFyX8xI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752763724; a=rsa-sha256; cv=none; b=nm3SvapUccb7uVATPOUI+Y29ajKPGeZsrY2Bea+nhc9B1x3M/NX3xp41klgHHDH/F1LfpT Yi8wl2ly6MxOEMdZc+zQsr6DT4QF3sfCa0f63Ug71glRDAB/uWyudYc2KamWGgBbeb4o0W r3zBHIX68hJKljouI/aSFzs9wUVd75M= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=USLaIKjO; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf02.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-60c6fea6742so2082811a12.1 for ; Thu, 17 Jul 2025 07:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752763723; x=1753368523; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Iw/Wu22cnB7NCngBl0TR+xjDDf5pHdg2GDKrviJBZ3c=; b=USLaIKjO6PvjWZpbFOIc6nYv0TIASzP8w+0Tcbrf1rWsP2dONOwXL4cElnfd9FXCmF +06QH4YzU6LNYZKEJODK+CX2OPradiQ6HexWVXOTyqcW0DIIk0zhAG9GmZ2ANY5ed72S HYI5FgIBqBrlXgIqRh2IvsqhgkOCLerb08RDO64jXmVs83csI37vbm8V6h4DLzv4kwkV RMjSvo+hDEX8y30jOONJuKnC95+AoJaEHJ3rKAaYgEyNeMKxZgRiIXuqyb5l44Bl3QJl +92Oj9UneMLNQ2L6G9m1r/5ZBWdpxoBDZ4BhSPo0AIob2iCc9ACn7IFqKPuyOjpRrkCa ejVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752763723; x=1753368523; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Iw/Wu22cnB7NCngBl0TR+xjDDf5pHdg2GDKrviJBZ3c=; b=kWMiuq0eBakMcKnH4Z3TKWqHQnp6J9nke6/wamykSoGMUibN0rUyoa3LPMy1QnzZG9 slz0fg24sCCY5UVh80yqwXmU5h2dhRCc8R1Q2W+PC6MipSxAGN5GFY2RSYiagwoRd/Wb Lq/e7eH1ZONnHlAyA+HxerVnVQCzsLJeFUOImnOeTdtoutSdQ9avD9ZFRlkVAULKyV2p vFqdhSiBLxiYBL3M2unnbyUjrz70jw+MdoL7P2CjsYz7KBvPVmKPEH6KJaByS8AlEWh5 RC3Yx87Qy89qaRAp474fKdUUn6v8juHOWdtDDZNqZD0lFZFe/bNa60VE9JtVoflLsVCL CqGA== X-Forwarded-Encrypted: i=1; AJvYcCV6hK6OKG4A0Z3T4B3mygcOcR5yqpOJtN2sbIfxExl3dt5yCYjORmRK4ApwrxBQgZMCU+DER0ZqQg==@kvack.org X-Gm-Message-State: AOJu0Yyr19qd9+NKfn8W31AZ9lTfDvaEvV6ZKstyr38lWwd9LFQ+9WCk MsyEo4YuFo+i2ATslHj/bZulFjPYwD1FxHWwyXjyMk5+Q7U7PcTs1UgJ X-Gm-Gg: ASbGncvYhP47yj9Z7Dg1+8zBAXfnGkH1mA1/gjT5Ix1u7ha0D2QfxCU0t5ZIbIQ+N1L 8AhMlhDXwdSnUc5h7ib7niB/YKVYhP3eZAiaBbI5aF4lVcdRHpxkGjrYTeSAu0k7kLdXNQEmoN4 vojPejy/s+WnTANx7erDo0V55n8bxyhb0GWXx/gTeejVrYbpIll36JHt0YYffx2u/vcsk+BbEmp GjTiHMQME9n7WwfV97kUDE+oqZ3ObBbLH3Fme/ZGqYiKAH5+24kTPTe0FNVwJN5FxCqDvrL2UXn 8ZtPUfeszDBvhEFlO1S3zEDjEmY8PG/Xiexp1VYUdVyKuWef6b20TdhCCiU7wN8N3VW5VrHPCDV bQCxzbclMA/NGOtmypi1ed/4X6Fp6lDN2cEEUhU88N/phEkz0LXUBdVtJi+LugoEgCl16cAc= X-Google-Smtp-Source: AGHT+IF+ZlqtPhXZntOTf7k0IhgSZ5eOF3kN2nKesocfNZywTkRlH6l4yVpCGS0SF12qy1k2Tg4cXA== X-Received: by 2002:a05:6402:27cb:b0:608:64ff:c9b5 with SMTP id 4fb4d7f45d1cf-61281eca285mr6839430a12.8.1752763722542; Thu, 17 Jul 2025 07:48:42 -0700 (PDT) Received: from ?IPV6:2a03:83e0:1126:4:14f1:c189:9748:5e5a? ([2620:10d:c092:500::7:8a92]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-61268c93b63sm3889881a12.9.2025.07.17.07.48.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 07:48:41 -0700 (PDT) Message-ID: <58c82190-e7b7-499b-9463-527312a28a3d@gmail.com> Date: Thu, 17 Jul 2025 15:48:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 1/5] mm, thp: use __thp_vma_allowable_orders() in khugepaged_enter_vma() To: Yafang Shao , akpm@linux-foundation.org, david@redhat.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, hannes@cmpxchg.org, gutierrez.asier@huawei-partners.com, willy@infradead.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org Cc: bpf@vger.kernel.org, linux-mm@kvack.org References: <20250608073516.22415-1-laoar.shao@gmail.com> <20250608073516.22415-2-laoar.shao@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250608073516.22415-2-laoar.shao@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: ncuuz8ywgjwi4esstupn8ehhg8e65ooj X-Rspamd-Queue-Id: 779EE8000F X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1752763724-950313 X-HE-Meta: U2FsdGVkX1/CNXyRIOzZFZRWPWoYdzp6jPDJLP7k47UDC54rCOwSF7zitVbzGpVVUbXXH4/34OGWA8/gQQZHMrq1BT1UTcbQztEbVv9ySIYs04J97xVxK8rtDxLW/roVHadWYzISEkZeCuqe1Z+FgCvI/BvahlG7MYQkYBi170/xIzfAbrVCwaR62bZlmpmz4kf/Cwb10koFnQ5Y6B3hlaib8GgtYISheGtBb8c0I9Rqb7HzeoBqoOjQPXx98PEjzRrfREkvtBtJ5hle9k6ZuImhJX+43SeEdotmywLCi8vjZve4aSr5ND1fy6I0B456Xpw+9Uxkqpg7rPqprNzLEhMvKDVxel8rAjWoa2FNCfP9zg1waZ5ESvq1CqekXq2f+iHvA8HMozBEarNjLXls/szqcgoGuRXuqkD9x2XpxtNLelLphcxOet8CrWBAY1byjstM2tAoaTcUXCiM74soluPC88XQwBmu95B+SheHBYtLxfI9sUEgDAgQ5LfWRcq1BEa/FqSTC4tlNNXZcNXwTXUSerOnhvNbd2OEr3SSiEKeuASxabMYF8m5rRFfXMYTXNAkuus/m9+A2iOx9K7iuRAQ50bOTZOR1oIdtmUl0PS8VHxLUkm7Xp4GuhRIiAK0TdAf+68eA2cNC4fVSfUCmqjlPP8C3erDVIUWG/9yB2UZ+lhEjTTifR5hNqAl3lgQGO/qJ9D07LMJeAhLuHcsAOrixfP2MCJcAfucEb9koNXdxaTvilWlbspeUQxyKlQTgwaZW8Tf43/BHBGolWq6/jKIDj5ANWsVzls7wx45bqvuagk983hi54RuPm98dhpZfgNDOUXAQ5SkwgZx1k1QfHHltgpefz74Qu+YA2Z7rYAbw17J0SFTL3f3fHyp2AnkZXB5zGxOK2SLpdWvTxdnnS2o3RwMNiCnLZxCvjxGu8eJEVOOeaMAzzCFRWMBJhgrAeO66pG99LsQ6a6cW+B pTkwm6oA oOzAXAyMXIWwAoNWn5UotnTVkINs1SCzNfXiB9LoZJw//EKF9958106N2vq/6Kd91WwGmgBVNLIOuE2MSnZ7rvaMbNMDZF40PfpV0JMEnNO6NUIaAewLQuWAj+3DxMRetHCHi6O6HO86jKeXQkL8w1jb1SZ8oez5BLoI4Ysey7wauEfvntWwRqWO0owvbac9HMSFgbjmNrsAuewavfCV/ezzjxg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/06/2025 08:35, Yafang Shao wrote: > The order has already been validated in hugepage_pmd_enabled(), so there's > no need to recheck it in thp_vma_allowable_orders(). > The checks are not equivalent. hugepage_pmd_enabled just checks if the sysfs entries allow hugification. thp_vma_allowable_orders modifies the orders that can be used based on vm_flags, which is not done in hugepage_pmd_enabled. > Signed-off-by: Yafang Shao > --- > mm/khugepaged.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/khugepaged.c b/mm/khugepaged.c > index 15203ea7d007..79e208999ddb 100644 > --- a/mm/khugepaged.c > +++ b/mm/khugepaged.c > @@ -474,8 +474,8 @@ void khugepaged_enter_vma(struct vm_area_struct *vma, > { > if (!test_bit(MMF_VM_HUGEPAGE, &vma->vm_mm->flags) && > hugepage_pmd_enabled()) { > - if (thp_vma_allowable_order(vma, vm_flags, TVA_ENFORCE_SYSFS, > - PMD_ORDER)) > + if (__thp_vma_allowable_orders(vma, vm_flags, TVA_ENFORCE_SYSFS, > + BIT(PMD_ORDER))) > __khugepaged_enter(vma->vm_mm); > } > }