From: zhong jiang <zhongjiang@huawei.com>
To: vinayak menon <vinayakm.list@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
mhocko@suse.com, "linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "mm: vmpressure: fix sending wrong events on underflow"
Date: Wed, 7 Jun 2017 14:41:04 +0800 [thread overview]
Message-ID: <5937A000.8020306@huawei.com> (raw)
In-Reply-To: <CAOaiJ-k5c07J2mHyhUut+S3nqbjdXe+dYQgxBGn=wTmHEq5x2Q@mail.gmail.com>
On 2017/6/7 14:17, vinayak menon wrote:
> On Wed, Jun 7, 2017 at 11:42 AM, Minchan Kim <minchan@kernel.org> wrote:
>> On Wed, Jun 07, 2017 at 12:56:57PM +0800, zhong jiang wrote:
>>> On 2017/6/7 11:55, Minchan Kim wrote:
>>>> On Wed, Jun 07, 2017 at 11:08:37AM +0800, zhongjiang wrote:
>>>>> This reverts commit e1587a4945408faa58d0485002c110eb2454740c.
>>>>>
>>>>> THP lru page is reclaimed , THP is split to normal page and loop again.
>>>>> reclaimed pages should not be bigger than nr_scan. because of each
>>>>> loop will increase nr_scan counter.
>>>> Unfortunately, there is still underflow issue caused by slab pages as
>>>> Vinayak reported in description of e1587a4945408 so we cannot revert.
>>>> Please correct comment instead of removing the logic.
>>>>
>>>> Thanks.
>>> we calculate the vmpressue based on the Lru page, exclude the slab pages by previous
>>> discussion. is it not this?
>>>
>> IIRC, It is not merged into mainline although mmotm has it.
> That's right Minchan. That patch was not mainlined.
>
>
Hi Minchan and vinayak
we should revert the patch (mm: vmpressure: fix sending wrong events on underflow), then
apply the mmotm's related patch. or drop the mmotm's related patch, then corrent the comment.
which one make more sense. Maybe the latter is more feasible. Suggestion ?
Thanks
zhongjiang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-06-07 6:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 3:08 [PATCH] Revert "mm: vmpressure: fix sending wrong events on underflow" zhongjiang
2017-06-07 3:55 ` Minchan Kim
2017-06-07 4:56 ` zhong jiang
2017-06-07 6:12 ` Minchan Kim
2017-06-07 6:17 ` vinayak menon
2017-06-07 6:41 ` zhong jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5937A000.8020306@huawei.com \
--to=zhongjiang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=vinayakm.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).