linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Wei Wang <wei.w.wang@intel.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"virtio-dev@lists.oasis-open.org"
	<virtio-dev@lists.oasis-open.org>,
	"david@redhat.com" <david@redhat.com>,
	"cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
	"mgorman@techsingularity.net" <mgorman@techsingularity.net>,
	"aarcange@redhat.com" <aarcange@redhat.com>,
	"amit.shah@redhat.com" <amit.shah@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"liliang.opensource@gmail.com" <liliang.opensource@gmail.com>,
	"yang.zhang.wz@gmail.com" <yang.zhang.wz@gmail.com>,
	"quan.xu@aliyun.com" <quan.xu@aliyun.com>
Subject: Re: [PATCH v13 4/5] mm: support reporting free page blocks
Date: Fri, 04 Aug 2017 16:55:22 +0800	[thread overview]
Message-ID: <5984367A.3030809@intel.com> (raw)
In-Reply-To: <20170804082423.GG26029@dhcp22.suse.cz>

On 08/04/2017 04:24 PM, Michal Hocko wrote:
>
>> For our use case, the callback just puts the reported page
>> block to the ring, then returns. If the ring is full as the host
>> is busy, then I think it should skip this one, and just return.
>> Because:
>>      A. This is an optimization feature, losing a couple of free
>>           pages to report isn't that important;
>>      B. In reality, I think it's uncommon to see this ring getting
>>          full (I didn't observe ring full in the tests), since the host
>>          (consumer) is notified to take out the page block right
>>          after it is added.
> I thought you only updated a pre allocated bitmat... Anyway, I cannot
> comment on this part much as I am not familiar with your usecase.
>   

Actually the bitmap is in the hypervisor (host). The callback puts the
(pfn,size) on a ring which is shared with the hypervisor, then the
hypervisor takes that info from the ring and updates that bitmap.


Best,
Wei

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-08-04  8:52 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  6:38 [PATCH v13 0/5] Virtio-balloon Enhancement Wei Wang
2017-08-03  6:38 ` [PATCH v13 1/5] Introduce xbitmap Wei Wang
2017-08-07  6:58   ` Wei Wang
2017-08-09 21:36   ` Andrew Morton
2017-08-10  5:59     ` Wei Wang
2017-08-03  6:38 ` [PATCH v13 2/5] xbitmap: add xb_find_next_bit() and xb_zero() Wei Wang
2017-08-03  6:38 ` [PATCH v13 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG Wei Wang
2017-08-03 14:22   ` Michael S. Tsirkin
2017-08-03 15:17     ` Wang, Wei W
2017-08-03 15:55       ` Michael S. Tsirkin
2017-08-03  6:38 ` [PATCH v13 4/5] mm: support reporting free page blocks Wei Wang
2017-08-03  9:11   ` Michal Hocko
2017-08-03 10:42     ` Wei Wang
2017-08-03 10:44       ` Michal Hocko
2017-08-03 11:27         ` Wei Wang
2017-08-03 11:28           ` Michal Hocko
2017-08-03 12:11             ` Wei Wang
2017-08-03 12:41               ` Michal Hocko
2017-08-03 13:17                 ` Wei Wang
2017-08-03 13:50                   ` Michal Hocko
2017-08-03 15:20                     ` Wang, Wei W
2017-08-03 21:02                       ` Michael S. Tsirkin
2017-08-04  7:53                         ` Michal Hocko
2017-08-04  8:15                           ` Wei Wang
2017-08-04  8:24                             ` Michal Hocko
2017-08-04  8:55                               ` Wei Wang [this message]
2017-08-08  6:12     ` Wei Wang
2017-08-08  6:34       ` [virtio-dev] " Wei Wang
2017-08-10  7:05         ` Michal Hocko
2017-08-10  7:38           ` Wei Wang
2017-08-10  7:53             ` Michal Hocko
2017-08-03  6:38 ` [PATCH v13 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ Wei Wang
2017-08-03  8:13   ` Pankaj Gupta
2017-08-03 12:28     ` Wei Wang
2017-08-03 13:05       ` Pankaj Gupta
2017-08-03 13:21         ` Wei Wang
2017-08-03 12:33   ` Michael S. Tsirkin
2017-08-03 16:11   ` kbuild test robot
2017-08-16  5:57 ` [virtio-dev] [PATCH v13 0/5] Virtio-balloon Enhancement Adam Tao
2017-08-16  9:33   ` Wei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5984367A.3030809@intel.com \
    --to=wei.w.wang@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=amit.shah@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=david@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=liliang.opensource@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mawilcox@microsoft.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=quan.xu@aliyun.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=yang.zhang.wz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).