From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Michal Hocko <mhocko@kernel.org>, Will Deacon <will.deacon@arm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-api <linux-api@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-mm <linux-mm@kvack.org>,
Tianhong Ding <dingtianhong@huawei.com>,
Hanjun Guo <guohanjun@huawei.com>,
Libin <huawei.libin@huawei.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: Re: [PATCH v2 1/1] mm: only dispaly online cpus of the numa node
Date: Mon, 9 Oct 2017 14:06:56 +0800 [thread overview]
Message-ID: <59DB1200.40106@huawei.com> (raw)
In-Reply-To: <20171003135628.xqhvr3rg7s5aymeq@dhcp22.suse.cz>
On 2017/10/3 21:56, Michal Hocko wrote:
> On Tue 03-10-17 14:47:26, Will Deacon wrote:
>> On Mon, Oct 02, 2017 at 02:54:46PM -0700, Andrew Morton wrote:
>>> On Mon, 2 Oct 2017 11:38:07 +0100 Will Deacon <will.deacon@arm.com> wrote:
>>>
>>>>> When I executed numactl -H(which read /sys/devices/system/node/nodeX/cpumap
>>>>> and display cpumask_of_node for each node), but I got different result on
>>>>> X86 and arm64. For each numa node, the former only displayed online CPUs,
>>>>> and the latter displayed all possible CPUs. Unfortunately, both Linux
>>>>> documentation and numactl manual have not described it clear.
>>>>>
>>>>> I sent a mail to ask for help, and Michal Hocko <mhocko@kernel.org> replied
>>>>> that he preferred to print online cpus because it doesn't really make much
>>>>> sense to bind anything on offline nodes.
>>>>>
>>>>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>>>>> Acked-by: Michal Hocko <mhocko@suse.com>
>>>>> ---
>>>>> drivers/base/node.c | 12 ++++++++++--
>>>>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>>>
>>>> Which tree is this intended to go through? I'm happy to take it via arm64,
>>>> but I don't want to tread on anybody's toes in linux-next and it looks like
>>>> there are already queued changes to this file via Andrew's tree.
>>>
>>> I grabbed it. I suppose there's some small risk of userspace breakage
>>> so I suggest it be a 4.15-rc1 thing?
>>
>> To be honest, I suspect the vast majority (if not all) code that reads this
>> file was developed for x86, so having the same behaviour for arm64 sounds
>> like something we should do ASAP before people try to special case with
>> things like #ifdef __aarch64__.
>>
>> I'd rather have this in 4.14 if possible.
>
> Agreed!
>
+1
--
Thanks!
BestRegards
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-09 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 9:53 [PATCH v2 0/1] mm: only dispaly online cpus of the numa node Zhen Lei
2017-09-29 9:53 ` [PATCH v2 1/1] " Zhen Lei
2017-10-02 10:38 ` Will Deacon
2017-10-02 21:54 ` Andrew Morton
2017-10-03 13:47 ` Will Deacon
2017-10-03 13:56 ` Michal Hocko
2017-10-09 6:06 ` Leizhen (ThunderTown) [this message]
2017-10-03 1:22 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59DB1200.40106@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=dingtianhong@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=guohanjun@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).