From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39FA2C88CB4 for ; Tue, 13 Jun 2023 11:15:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB7E76B0074; Tue, 13 Jun 2023 07:15:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B67DA8E0003; Tue, 13 Jun 2023 07:15:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A30078E0002; Tue, 13 Jun 2023 07:15:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 951E26B0074 for ; Tue, 13 Jun 2023 07:15:11 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5F2731C7C10 for ; Tue, 13 Jun 2023 11:15:11 +0000 (UTC) X-FDA: 80897468022.27.B4EE423 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf26.hostedemail.com (Postfix) with ESMTP id 6D749140003 for ; Tue, 13 Jun 2023 11:15:09 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=sef3YbXz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686654909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4kd+y1uwKfRP7e93ZE/WKZWkAA+D5Ut1RT3+7c7Onw=; b=ofVT5ud64KeucgcfyKImBi48RyNpX5O0J742Sj27EffkhQtdlYBOx6yJLNotq45I7XxCmA Xsfpt1cCmEJcDadczwHt22Z00ABoRHBLsf1wBgZbNX/6R+Bs+VPOqIU7kI6nALgEHjAdqx v4zoTHILWGIf5uUDmpXh8UBbL4itJBw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=sef3YbXz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf26.hostedemail.com: domain of ttoukan.linux@gmail.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=ttoukan.linux@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686654909; a=rsa-sha256; cv=none; b=yHe8XsJQoVPw4UKaeQbUaM2hocyODkx7w3MmUNY1sXJW59MrE0B9Gmo/msp+1klKqgz3fW ll+wmpZroRkXmCrfk4ouOQou9wuvoGl81wiAtKkB4ILSsel16eBsCWHP2+W6mL7cpERNzo fIOnrma1ruksOWKsnJ6vfIkx+MSeHIg= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-3090d3e9c92so5145325f8f.2 for ; Tue, 13 Jun 2023 04:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686654908; x=1689246908; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R4kd+y1uwKfRP7e93ZE/WKZWkAA+D5Ut1RT3+7c7Onw=; b=sef3YbXzr7MvxGXHaRQdMd+IM+wAPQBtg+CKkvRPn7PmFW+E/bx0clC72RYYbWcdMt y171cIXU4EfkHrqXVqOMxVz8CRv6k5d06AngpR01J8izEa8Yf4+d0mBOYGuotmzUuBbP XCv9X9gDUDRq2KI8NBVmd5W4C6B1pjq5GINjOmX3egn/E+7GMbpZNW4M2SD3QSMPNiu2 aR2vN95sLlugbPZg+V34pB5muiMCNpt1X/6696C22rnQ1myg8ZcnG5U7idVZqZxpLdrf D7fWbcb8H/uchGj9tghtN7wwYYR+kc9ejChx7SZHNrc5BWc2y3Y0A+sBriVp+LlArHGX tSiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686654908; x=1689246908; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R4kd+y1uwKfRP7e93ZE/WKZWkAA+D5Ut1RT3+7c7Onw=; b=lT9IN8NNsO9kiRTYQaRa6Z/oVZH6icydvbDtXuMM3qo1TPw2rWIVTImrcvIqDuctoi hGX04bJ7YlUA5RKaat0hwPuVVDKPK4f5ShxbhZEWj+ILAtrVIW22b5RYTKAwoNlP2d2X 1l8VxxC+a6F9jpoxDe2ZoHpkCjJuaYMyAESBXFNO+j0u64fiLsVAJEjTQkR7Q8jDJj2j fbBRowFKtnylk8jQMBbHEp5lx2xgw5YB3BpgyLWcwZQ9G6vD1eac4DMVLqaTOGm/ygum xpY80uU6vh9y7+QEOODsy5UyeNe4WM1rGzfhmj39U0kF+j2WvhuDwlhAsBH2r8QHLCpt 7RtA== X-Gm-Message-State: AC+VfDzMX2E+yfDqmRtRvRWOBMsdH41+RT3Vyxs9Pvg/G1Ds7OvmUTTG rUpPiPpgj1TlXQuDZ9MYhBI= X-Google-Smtp-Source: ACHHUZ6ZNvQZlX7H3HzuRZ0k2J5gJdr2u9+UMZo3nIqlVJaBUQmWwBFxq9Dje1Cdfb+3MmMX8iF4IA== X-Received: by 2002:adf:e544:0:b0:30f:bcfd:c690 with SMTP id z4-20020adfe544000000b0030fbcfdc690mr5868435wrm.38.1686654907663; Tue, 13 Jun 2023 04:15:07 -0700 (PDT) Received: from [192.168.0.107] ([77.126.161.239]) by smtp.gmail.com with ESMTPSA id m12-20020a7bca4c000000b003f4290720d0sm14009675wml.47.2023.06.13.04.15.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 04:15:07 -0700 (PDT) Message-ID: <5a9d4ffb-a569-3f60-6ac8-070ab5e5f5ad@gmail.com> Date: Tue, 13 Jun 2023 14:15:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next v10 08/16] tls: Inline do_tcp_sendpages() To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Boris Pismenny , John Fastabend , Gal Pressman , ranro@nvidia.com, samiram@nvidia.com, drort@nvidia.com, Tariq Toukan References: <4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com> <20230522121125.2595254-1-dhowells@redhat.com> <20230522121125.2595254-9-dhowells@redhat.com> <2267272.1686150217@warthog.procyon.org.uk> Content-Language: en-US From: Tariq Toukan In-Reply-To: <2267272.1686150217@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6D749140003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: aw387opxcocp653r5cageiip7unhsfdg X-HE-Tag: 1686654909-510190 X-HE-Meta: U2FsdGVkX1/9cmAKdHxPzjpuYaS+d17uaIaJ/CpeRWQcBQP8LMrJgxvmGTL8EEV6TRHa70+xeDjsaGSmSYjYDo2dPnQE2Ki+fQOQ+ADYfmxrhGzB5dr/Bes1a8ZNZ89crSGRVuCT9u8KJAXbQbTo8SPAoUsQ0YERyyIzY5r2ZdDJKQY3A1Ts/08NLjCDOhvcC9IKZAOjVNeeTfWURYz8iVbahnBPFywex2oP5plxjTTrWpP3X7Sfic9B7IZIIIZ7MjtqQjlYS93UQfA2eMP/eOJDTODi2joAOThjmSD+HhWyw5M79lSAe/BPEhm1FP3KSVwhfQFjOmPELrYiAAS1emNW2ftPys5OmVMGfN/8MALCQB0ogI3rKRWZje45zN4BxtddSc759maSJhgS7IyiSf2Hn1waUAa0siJFj85YtaeZjq+9kHgwyqC+Tcr7AvlxxVkfT6+oTQXpu14hEe5eFl2xWodgBWqQS3gBpWJSgr/N/c+CLtKlDMr0KMrOzdloLOt0fbpqg6c9pXzDANn62GOKz4IgG9srL9EAqTkdu5ZG4SJGO9xDqOuyQ2elFlE46Q8jCIm7FJvDTUoHE7T/h1V5no3NVOOQF72zrD83ZXYbPDJB1zfPoTtBVnbeIrqvIoPotGtrHUkkZeh/SqgpOOlrURPkMMVH//QPJhqQYeKpHNcuJ079Ajyf8V/qqAGxboAIzjjYRADuumiIKtkVPSj4hea+lielhwK68r5nbr2icxMLSiqbPls/NMner35r7Z+xxBGe6sw7Fa5Xd2l/72nc7wgQvQ6AMleomnpsDGIgnoHy5xVqRECbEN6MxDWEdR6tHIVmoYG0FCjEs/vMaHDca2Z/jEfLS3/y9ntA/KK7lV94tE2Wc90sf+An8LVyH163e6EVf8S6DdBbsI/S9YyWnh3tq7P1jn2QwSLG6QwVU57YLFcK0ZmUvie42it8ymr5fkGbHIeFOEx7xm6 CWjHv3J7 eUahpKhhBx6cHncRhvFiWyCeF+RkdzHHDOSjkhpnPpHr49O23VsP8xegYFmxgliGCQ/hMUo9GpsrcEfgkj+KnxHeElWroxRjkfOaAokyGX/EuvLzWMh8tyBAqCmsbdOTTYIz7EtPSrOp/IzaZeExBCYJ5dn/xXQNUWcTy4nUk6+nz39YdVvHidxA7R/KVxTMglyxZgfZFAYR2ZHzwhwhOnwYzD8+LhZRHbClrs7Ra+VJIMsnhqS8IpUbn5zAtdN3LByv4YBLvScjGIrv4AwDKUsOeSe0r6TS2GhzqeRWnoPgw7BNQkxq/1GmcWqEsxvnDnPgzdXirk3jdMqY7nZijEdPLFXrRiQ9NCPG6g5AX+0Jgb0HnK2wOxF8wfIcaa+gbirlVFgd+V+gpQuCZa/5ZXJuAooHgtGqVprotCQgK3eVlDBL9I8tvnn4ZCU/Fw9oMlp4m6qVKEpHb+RH9B8UQZ6zIF+9s0Iv0BSXBq9jdlmD4Q+gKr0ZjYBlkB5bJkk1f/anzAHdKHvYbYe+XEi7k0FrMIrwK5X1N1RJW+JurZ4p8ywr2fiTQa6u2e0nbXFLpRlRTXZyEHPSqbJFCq0tZnU7Z5+/R6tdYyBBm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/06/2023 18:03, David Howells wrote: > Tariq Toukan wrote: > >> My team spotted a new degradation in TLS TX device offload, bisected to this >> patch. > > I presume you're using some hardware (I'm guessing Mellanox?) that can > actually do TLS offload? Unfortunately, I don't have any hardware that can do > this, so I can't test the tls_device stuff. > >> From a quick look at the patch, it's not clear to me what's going wrong. >> Please let us know of any helpful information that we can provide to help in >> the debug. > > Can you find out what source line this corresponds to? > > RIP: 0010:skb_splice_from_iter+0x102/0x300 > > Assuming you're building your own kernel, something like the following might > do the trick: > > echo "RIP: 0010:skb_splice_from_iter+0x102/0x300" | > ./scripts/decode_stacktrace.sh /my/built/vmlinux /my/build/tree > Hi, It's: RIP: 0010:skb_splice_from_iter (/usr/linux/net/core/skbuff.c:6957) which coresponds to this line: if (WARN_ON_ONCE(!sendpage_ok(page))) > if you run it in the kernel source tree you're using and substitute the > paths to vmlinux and the build tree for modules. > > David >