From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F8AFC2BD09 for ; Mon, 24 Jun 2024 15:39:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 83F416B03C7; Mon, 24 Jun 2024 11:39:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7EEB26B03C8; Mon, 24 Jun 2024 11:39:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B6476B03C9; Mon, 24 Jun 2024 11:39:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4EA566B03C7 for ; Mon, 24 Jun 2024 11:39:08 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B102F80F75 for ; Mon, 24 Jun 2024 15:39:07 +0000 (UTC) X-FDA: 82266190734.06.D7604E8 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf29.hostedemail.com (Postfix) with ESMTP id BC8BF120016 for ; Mon, 24 Jun 2024 15:39:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fpcurWnn; spf=pass (imf29.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719243531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HPcPd9wy1fSfjdoXcI4T31fTF+D9RtkuwE8EltBejPw=; b=E2d5npPPQwOrsWc81cvQOVLPH7Ix2/meVRwjI8fonPOV9UrCaaX8PV0QiXC5DqOkdOa+Mw 9ip4CMO4JtuZBmIP7WQLENDlhsbDKX2IlvrYvEKaODx95Ag8mk4yb1RMSMA7GoXU8e6SP5 CQQhuwaJhAOquEp5U63ZQ9Dq6klGGIQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719243531; a=rsa-sha256; cv=none; b=fT1dFC6BnhGAk2YuO+yIlPoYRV6M4cWdcWEm71LTGrZ9A3i/M1Nk8UyeO16SKt2NIvO5Dt iQ03O1zsd0VNOy3OCNX4xnwpE82lcF60Qz+lS4n0HBqAa46TbooXY5RoT6XbkUSg8kRp5z NFYtkX6Bj/+TnPzJMdiqud4ReDbFg6I= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fpcurWnn; spf=pass (imf29.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4218008c613so37469605e9.2 for ; Mon, 24 Jun 2024 08:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719243544; x=1719848344; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HPcPd9wy1fSfjdoXcI4T31fTF+D9RtkuwE8EltBejPw=; b=fpcurWnn3opyRysm3SZn7ysbNdA9hk/buHzomFzs4FVfBDRJgLPbwfQdM85Pyr6nNb CNuMGImGR7J+5pEavXRkw/7MeU9FhV149it1bG6xS5DQLmv3FsChaUuSk15gvEBqBLAI MmZniTuSgZzzDRA2wzcLrNY5XqbYfUra3dGE2DMZPo/jdv6D8l574hjDEcBeQxW3aFpP N5PWBGFlKGcClYbKBgoBoAEixEgC9EfowgVAFcL3xSmYepIjfqbDAba5eOEwGdykApDW RP52CFSjq8UjSB8TUOFN+V2/Xe1aLNJqPo09n8/r92E9xe4NPAylg+s+ECdxYkEIbf47 ze7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719243544; x=1719848344; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HPcPd9wy1fSfjdoXcI4T31fTF+D9RtkuwE8EltBejPw=; b=OKXbVM+ej6CSxn2gvwVyNYHh55fLmXlpDNeBJF32SFkmeohfCmO0j5VEdeqDZ6yBzS 3dgmoJHk0e0vKlgYKpZaxOPwUKFPB3r7J+gC/RifwMWotvf55EekTxGonaJRWNTvPjjG 26LYbqgZDUJDdNjLAX90nxIymNAxKiTKdroE8EH51dqfKQdECBdZAqKmfap/D+W3kqqH wDfxHxQ/vc1yPPazbVqR0x3mqBAzw2GL1v7+iRt4nmmjFgB7rfxoaWikzFOC4bakhIv2 RUs+PTuWrcl0xcCk06LgZ1lFMDeWgQyrgiJl96hDOGJfeI3iWbNfFWTBvYAcppMkdx3n ueHg== X-Forwarded-Encrypted: i=1; AJvYcCVfitacIYOkTKdmwnU/nanHBOlV6ZT2zxZmlmprsTPq4ezHOOsSP+wEZ+dKdByAvAcDC9C1tVW77GsukuASdxIYx7I= X-Gm-Message-State: AOJu0YxaDjhwndMhYkL4m+Eix5IFkckhTVPNT5J7RPWnF8YQ+yrqM0xR J/ZI9SY5irSDERcRzf+Lf+SnieOf0gjhTl2uRqBu9xXKmMSLUAdX X-Google-Smtp-Source: AGHT+IEKItbua/CYYFygu+88L+0laEZhLABVve6WLN9uF33edGgRXGcJjBtKahS8k9Dy8kc+1m3BWw== X-Received: by 2002:a7b:cc89:0:b0:421:7f4d:525f with SMTP id 5b1f17b1804b1-4248cc35da7mr33607055e9.24.1719243543832; Mon, 24 Jun 2024 08:39:03 -0700 (PDT) Received: from ?IPV6:2001:16a2:df66:b900:46d:aa3:6645:bcd8? ([2001:16a2:df66:b900:46d:aa3:6645:bcd8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4247d0c54c9sm179753455e9.27.2024.06.24.08.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 08:39:03 -0700 (PDT) Message-ID: <5b3e732c-d23d-41ef-ae5c-947fa3e866ab@gmail.com> Date: Mon, 24 Jun 2024 18:39:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master] [mm] 0fa2857d23: WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof To: Hugh Dickins Cc: Yosry Ahmed , kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Linux Memory Management List , Andrew Morton , Chengming Zhou , Nhat Pham , David Hildenbrand , "Huang, Ying" , Johannes Weiner , Matthew Wilcox , Shakeel Butt , Andi Kleen , linux-kernel@vger.kernel.org References: <202406241651.963e3e78-oliver.sang@intel.com> <12fb19d1-3e57-4880-be59-0e83cdc4b7f1@gmail.com> <61d19ec8-2ba7-e156-7bb7-f746dae8e120@google.com> Content-Language: en-US From: Usama Arif In-Reply-To: <61d19ec8-2ba7-e156-7bb7-f746dae8e120@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: bozrprp7uoxtw1rfpoupxrr93m5kdwe8 X-Rspamd-Queue-Id: BC8BF120016 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1719243545-355555 X-HE-Meta: U2FsdGVkX1/1+QPmgF094aPa+c/kzFq1uGk3Wfu57y3dPzeAFCVqFtVUKtLZQtLM/Q/rw5Bm5/1mCDDolFQSULs5GrG/i7lyIWytpev/Becb0C0zW0oqqDYibmGeLBWZpBWmlB7LFwQrg8JAltXuP5XGayItixRbv/BQBM4cTX1SIVMLggBnvPG+nFnSz/cSg7U4k7nU/ioXCLtXKoemqzfF58Rbe36/A3lrqTbCkXpYv5ojE/1p/8HNTsybZzfcuBSWO8sW3rHsgks/cFXhF2yRJGYZNYEEbgOlPKibY5IUphGxTUzqETLlTKhOQlUsYNmLB25kMe2Hu28/rrqOjofjzJqNxh70rZVpUxefmd7aQgXryJeF48rBoRULSMylMjAXBfaFG0SfibRW58pwjRU+GfWmycR5GzsTjHZbYpFAVEnIPDGPKfPG3AqT2Z0UMEKk7n9WgC91wX4z+QRkemYzUJBLnY/If7X/wAkkfIFXOCrax37Qg2DP7CqajkqB/lRIxIiunHCzBB5O16R26mBgETJuZa018pmEpozzndc49LCNkpKtq0SN9fMfUtps3OHqx7G+4QW2r7QqxCvi0bdDg7XVlscaQknKW9mxtkPYhNRGsIs145esMqwhnLRVbglBk9lzTvvvf7LYvVXSwieZwum/5L1GLoWpRzchIEy/V5eIl7OosbAG7MnqkrmABQo7dnHzRCMTf6vtqyREGNlpObIKcsPl58CVeQb6EGCWhGmoqzb4KiVnUH6AhQEkGc+136jp8ySsBuRQRAR33uZCLskQclR0s+fl3en5NjvPAhlmKdCH1kE4QN/3tyP26uc5qB4my7TEIKOUE3HBw3za2Yuc8u22WhvJ1Z9UrcRABQFcyf/aGcTJBSld2YEsgCQDbvAoU5l2kEtYTsEa+tso5UlEc3mHETLhFrUku0I9xRsjQGPpBf3i2uGbecHY5QoAzbgLw/ZhhMvrwIQ sGxzQmNb oX2+MDRlHWjbUlaSyQcXdvpoJd10iKYQMix+Is638niCpN5KKfI8/HEuovAqhafdz55ke2hlVdlQMrXU+6m9v8XfkOvuJRpWnZGWf52wiJruw6PX4sWRVWHVjzXUxC8oAi/XjVbFXkAOJCi6A5NGnfg70L/zeOet7zpQGs1NFjjFUvM6JomzupH9XhCd0aI9G+LFbG84OkdWahNfTdj2bqt2NdJEf98kPI0a718gdW4tAAFpmCOxAQe/qB3fX4+vbDHFpWopIvwWYqen21/X2QxYTsftielR2GbTzTRfPPNRAprb1lun7TlMMgs5qjRoyDG4mOgniWZR70dgODF+0JiMdVZe5QJ+oL3mNLTwGItB3wls/9WDJQWMLJby944x9SRJwBFfAkSpphJEo8u3Jf943EZT2gXnuRW3X9fdfL/CftEr+Zk32qaa71k6yPng1i92cuF5usKalPhbj667kwTmgbtpWQ8GDUpQ9WBnLAlVK60fjB3Bk6Q2ZEUWlpadi/qliNSbkkjRSEOTQIVuddwiXg4VSxgGw0Jsq60uCV0aEfsZu0HT6AdworR26nRhncErO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/06/2024 18:26, Hugh Dickins wrote: > On Mon, 24 Jun 2024, Usama Arif wrote: >> On 24/06/2024 15:05, Yosry Ahmed wrote: >>> On Mon, Jun 24, 2024 at 1:49 AM kernel test robot >>> wrote: >>>> >>>> Hello, >>>> >>>> kernel test robot noticed >>>> "WARNING:at_mm/page_alloc.c:#__alloc_pages_noprof" on: >>>> >>>> commit: 0fa2857d23aa170e5e28d13c467b303b0065aad8 ("mm: store zero pages to >>>> be swapped out in a bitmap") >>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master >>> This is coming from WARN_ON_ONCE_GFP(order > MAX_PAGE_ORDER, gfp), and >>> is triggered by the new bitmap_zalloc() call in the swapon path. For a >>> sufficiently large swapfile, bitmap_zalloc() (which uses kmalloc() >>> under the hood) cannot be used to allocate the bitmap. >>> >>> Usama, I think we want to use a variant of kvmalloc() here. > Yes, I hit the same problem with swapon in my testing, > and had been intending to send a patch. > >> Yes, just testing with below diff now. The patch is not in mm-stable yet, so >> will just send another revision with below diff included. Thanks! >> >> >> diff --git a/mm/swapfile.c b/mm/swapfile.c >> index 0b8270359bcf..2263f71baa31 100644 >> --- a/mm/swapfile.c >> +++ b/mm/swapfile.c >> @@ -2643,7 +2643,7 @@ SYSCALL_DEFINE1(swapoff, const char __user *, >> specialfile) >>         free_percpu(p->cluster_next_cpu); >>         p->cluster_next_cpu = NULL; >>         vfree(swap_map); >> -       bitmap_free(p->zeromap); >> +       kvfree(p->zeromap); > Yes. > >>         kvfree(cluster_info); >>         /* Destroy swap account information */ >>         swap_cgroup_swapoff(p->type); >> @@ -3170,7 +3170,7 @@ SYSCALL_DEFINE2(swapon, const char __user *, >> specialfile, int, swap_flags) >>                 goto bad_swap_unlock_inode; >>         } >> >> -       p->zeromap = bitmap_zalloc(maxpages, GFP_KERNEL); >> +       p->zeromap = kvzalloc(DIV_ROUND_UP(maxpages, 8), GFP_KERNEL); > No, 8 is not right for 32-bit kernels. I think you want > p->zeromap = kvzalloc(BITS_TO_LONGS(maxpages), GFP_KERNEL); > but please check it carefully, I'm easily confused by such conversions. > > Hugh Ah yes, didnt take into account 32-bit kernel. I think its supposed to be  p->zeromap = kvzalloc(BITS_TO_LONGS(maxpages) * sizeof(unsigned long), GFP_KERNEL); if using BITS_TO_LONGS. Will wait sometime incase there are more comments and will send out another version. Thanks! >>         if (!p->zeromap) { >>                 error = -ENOMEM; >>                 goto bad_swap_unlock_inode;