From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34798C433F5 for ; Tue, 4 Oct 2022 02:16:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A62396B0072; Mon, 3 Oct 2022 22:16:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9ED266B0073; Mon, 3 Oct 2022 22:16:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 816C56B0074; Mon, 3 Oct 2022 22:16:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6796A6B0072 for ; Mon, 3 Oct 2022 22:16:44 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3D4971C5C1B for ; Tue, 4 Oct 2022 02:16:44 +0000 (UTC) X-FDA: 79981653528.26.494995A Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf26.hostedemail.com (Postfix) with ESMTP id D780A140015 for ; Tue, 4 Oct 2022 02:16:43 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id lx7so11656940pjb.0 for ; Mon, 03 Oct 2022 19:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CaXno1qEaV74BR47NIHz1H2pJTTUIFFA+A4lpB/mgXA=; b=eloCpiVf/0XcI+V+9l2I+AY6JDTwodTaVWUcwJM8+ymYWCbCYU6oBKazVN4ASxEJX6 kk9rcQNkV9iNEBCEfBpiQL8dJO8Ze5SU5jT+OEylww1Rdoa2cSXdVmfP8YB9ZS+TH1ok h98MPxQcbqwHETxS/dd25Mmf0WuqbMHpi/wUbu+ALDMg0/lCf5WzLQTsU9cEs0W/u242 s0Ymg5MD1aqfX3VyUTM64F0uWzm19iJV4OPDMpgg3sQgr/nMEdZXKUqfcKtchsO3+TO4 WcxOl4sdDhoTC772r6pirqm5F/HfdZ/bE36pFYNbWNSppnVLW50Yi/HaYpOzQmMfBoy7 o0dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CaXno1qEaV74BR47NIHz1H2pJTTUIFFA+A4lpB/mgXA=; b=vN/drTG1usT+9vtyLpAfsXqlsayHhp8lm/JeJfLL4wDI5TX8OuzfmeIGJBElCCfSo4 EYHcoVx9gE5+tYLeNMZYPM5UhNIFbI6M7D0UeklC60nmOsbGZhE5VBa1tKtoi0ErXhR2 qNH6IH3oPfYN2KPgDAtUlRFI5U05X7r+5MH5auP2pIBQ6iuV8w4bGqW/e8TGIyy+h/Rn a0R8o0KxhxelJFqNnGZWvtqc9wA6PuEi3m/0MKQf8hOR+T1eP3R8IXsqjyu0XUUAeUyK 0lbgzKRVsSI+puY4PW09l0A9qCD4E552Q7z4H/2iiqSI+hUEzIYGiYN2kGPuY54MxZz5 ax3w== X-Gm-Message-State: ACrzQf3zayPQ5g5sPTV8YwSVPT5W8w9dD9FgcpUi3kLXvP+CmEc+UhFt OFQ0Kb82D6se+AbunWuTL7M= X-Google-Smtp-Source: AMsMyM7z7mqbqxau9dc5BF4w7ZntoA9ZSL+qDurMSeilS3c8J2q9EzScXlqJREt95R+vDsKYOP4Ufg== X-Received: by 2002:a17:902:c205:b0:178:5083:f656 with SMTP id 5-20020a170902c20500b001785083f656mr24923647pll.81.1664849802859; Mon, 03 Oct 2022 19:16:42 -0700 (PDT) Received: from [192.168.43.80] (subs02-180-214-232-17.three.co.id. [180.214.232.17]) by smtp.gmail.com with ESMTPSA id y5-20020aa79ae5000000b00561382a5a25sm30703pfp.26.2022.10.03.19.16.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 19:16:42 -0700 (PDT) Message-ID: <5baaba9c-b07d-4d28-9416-217ebed14eb4@gmail.com> Date: Tue, 4 Oct 2022 09:16:31 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v2 01/39] Documentation/x86: Add CET description Content-Language: en-US To: "Edgecombe, Rick P" , "corbet@lwn.net" Cc: "bsingharora@gmail.com" , "hpa@zytor.com" , "Syromiatnikov, Eugene" , "peterz@infradead.org" , "rdunlap@infradead.org" , "keescook@chromium.org" , "Yu, Yu-cheng" , "dave.hansen@linux.intel.com" , "kirill.shutemov@linux.intel.com" , "Eranian, Stephane" , "linux-mm@kvack.org" , "fweimer@redhat.com" , "nadav.amit@gmail.com" , "jannh@google.com" , "dethoma@microsoft.com" , "linux-arch@vger.kernel.org" , "kcc@google.com" , "pavel@ucw.cz" , "oleg@redhat.com" , "hjl.tools@gmail.com" , "bp@alien8.de" , "Lutomirski, Andy" , "linux-doc@vger.kernel.org" , "arnd@arndb.de" , "Moreira, Joao" , "tglx@linutronix.de" , "mike.kravetz@oracle.com" , "x86@kernel.org" , "Yang, Weijiang" , "jamorris@linux.microsoft.com" , "john.allen@amd.com" , "rppt@kernel.org" , "mingo@redhat.com" , "Shankar, Ravi V" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "gorcunov@gmail.com" References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-2-rick.p.edgecombe@intel.com> <87v8p5f0mg.fsf@meer.lwn.net> <0eb358ac-068c-d025-07e3-80a3c51ef39c@gmail.com> <5832fa687e6da50697a7627d53453b728ed1b7b7.camel@intel.com> From: Bagas Sanjaya In-Reply-To: <5832fa687e6da50697a7627d53453b728ed1b7b7.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eloCpiVf; spf=pass (imf26.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664849803; a=rsa-sha256; cv=none; b=VaMDlkjQZKqlQgbBc3Z2oKVJVeYVimxwKQ9G3I9FBPOal0Akm32iHkoTKuswmpCVKCCZjT 09gEcaImZ6uCWxW1O8zwRWr0OxRZeCRgcvYgfQCp+KJCrTCmTVRd8t6BaUBlsY10Zy/3d4 VkNjc4Vq0/j70CZbd2RdmsZ8du1fjmQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664849803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CaXno1qEaV74BR47NIHz1H2pJTTUIFFA+A4lpB/mgXA=; b=wEe2SBsyI0IGCpagAMVobpy0T0KArBx3M9BWYhAsitE5C24mTvw+Q4VoAn6HeHeAzhbTOJ 4ELvb82xF9so0mshCqmUhMjLjNLXM0V1h7IKKnpipFcBxHxd9DQ19Agk/nUlLvBSozIZY7 cJkD7vOJ4OoqJhmMkbbRaN5L0mInR58= X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D780A140015 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eloCpiVf; spf=pass (imf26.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: i4pdkaiein5akok1ahpwfqfdf8wtkj71 X-HE-Tag: 1664849803-134286 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/3/22 23:56, Edgecombe, Rick P wrote: > On Fri, 2022-09-30 at 20:41 +0700, Bagas Sanjaya wrote: >> On 9/30/22 20:33, Jonathan Corbet wrote: >>>> CET introduces Shadow Stack and Indirect Branch Tracking. >>>> Shadow stack is >>>> a secondary stack allocated from memory and cannot be directly >>>> modified by >>>> -applications. When executing a CALL instruction, the processor >>>> pushes the >>>> +applications. When executing a ``CALL`` instruction, the >>>> processor pushes the >>> >>> Just to be clear, not everybody is fond of sprinkling lots of >>> ``literal >>> text`` throughout the documentation in this way. Heavy use of it >>> will >>> certainly clutter the plain-text file and can be a net negative >>> overall. >>> >> >> Actually there is a trade-off between semantic correctness and plain- >> text >> clarity. With regards to inline code samples (like identifiers), I >> fall >> into the former camp. But when I'm reviewing patches for which the >> surrounding documentation go latter camp (leave code samples alone >> without >> markup), I can adapt to that style as long as it causes no warnings >> whatsover. > > Thanks. Unless anyone has any objections, I think I'll take all these > changes, except for the literal-izing of the instructions. They are not > really being used as code samples in this case. > > Bagas, can you reply with your sign-off and I'll just apply it? OK, here goes... Signed-off-by: Bagas Sanjaya -- An old man doll... just what I always wanted! - Clara