From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C619C5B543 for ; Fri, 30 May 2025 17:10:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E69F6B016B; Fri, 30 May 2025 13:10:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 16F966B016F; Fri, 30 May 2025 13:10:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 010666B0175; Fri, 30 May 2025 13:10:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D481B6B016B for ; Fri, 30 May 2025 13:10:24 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 26F1B160FE3 for ; Fri, 30 May 2025 17:10:24 +0000 (UTC) X-FDA: 83500212768.24.1522989 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf06.hostedemail.com (Postfix) with ESMTP id C8038180017 for ; Fri, 30 May 2025 17:10:21 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zUaUfzX1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=efd0cnFq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zUaUfzX1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=efd0cnFq; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748625022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bkwj7ORW1EMkW+ZUqrg5leI0TSmf04O2/PaYlHh/9LY=; b=nJiKFr+yeqMLaH+nm+WinSKGf+l+xedVFxSJh10CPw6q3Q2gh8Do5OJN30oCfceDikMUTv KATCVV89sDhIX60NR7lHFSd1hyYx1AVPYmrAtIm6E8gcoZUdw3DkCxT/cPWQU70kn+By3+ 7+4wftfKz3iX3iw3/VkHzduYSbCCGLw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zUaUfzX1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=efd0cnFq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=zUaUfzX1; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=efd0cnFq; spf=pass (imf06.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748625022; a=rsa-sha256; cv=none; b=i8R0ke/9Hu3Ak5TTeIKrOXQFC6sVaG0z8f4qgIRWJuY13EiMrTD40pBeLx93UgjOa/63NW tfexv69/c4EaUi6GM36bQsplDqqrHjPoaco3w7vAi/QgngUb9n4NdSMQOdWdHvcdF7YGFo tu2tP6ptjBEKkdSBh+lbVMscJZqKNF0= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4B67921ADC; Fri, 30 May 2025 17:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748625020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bkwj7ORW1EMkW+ZUqrg5leI0TSmf04O2/PaYlHh/9LY=; b=zUaUfzX1YeqRCWu9OWctT33ZJRRNDJCwb5ec4CFx1y39/v1qKp1og1jckOnEaL7CwusNpr EdaZWShFRSgiejdBBZLTrJies8AXhDb1TonKr6aSaNetMUexFwNPeeHU5qsj5pcP6xulQE t6uD1jmXPdYAHhM0vrc9lClT0bIVC8Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748625020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bkwj7ORW1EMkW+ZUqrg5leI0TSmf04O2/PaYlHh/9LY=; b=efd0cnFqoSOPSJNPONK4rVttxH7jtx9LcDgFhktuM1v7fQ9aLLHgMpceMOuzjP+n8q+/bO wiR6mhuDbVHtf6CQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1748625020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bkwj7ORW1EMkW+ZUqrg5leI0TSmf04O2/PaYlHh/9LY=; b=zUaUfzX1YeqRCWu9OWctT33ZJRRNDJCwb5ec4CFx1y39/v1qKp1og1jckOnEaL7CwusNpr EdaZWShFRSgiejdBBZLTrJies8AXhDb1TonKr6aSaNetMUexFwNPeeHU5qsj5pcP6xulQE t6uD1jmXPdYAHhM0vrc9lClT0bIVC8Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1748625020; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bkwj7ORW1EMkW+ZUqrg5leI0TSmf04O2/PaYlHh/9LY=; b=efd0cnFqoSOPSJNPONK4rVttxH7jtx9LcDgFhktuM1v7fQ9aLLHgMpceMOuzjP+n8q+/bO wiR6mhuDbVHtf6CQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 210B7132D8; Fri, 30 May 2025 17:10:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1xBmB3zmOWgQdgAAD6G6ig (envelope-from ); Fri, 30 May 2025 17:10:20 +0000 Message-ID: <5baee4e4-d8d1-435f-bdec-6cae2fcc6492@suse.cz> Date: Fri, 30 May 2025 19:10:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/6] mm/page_isolation: remove migratetype from move_freepages_block_isolate() Content-Language: en-US To: Zi Yan , David Hildenbrand , Johannes Weiner , linux-mm@kvack.org Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250530162227.715551-1-ziy@nvidia.com> <20250530162227.715551-5-ziy@nvidia.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250530162227.715551-5-ziy@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: C8038180017 X-Rspamd-Server: rspam09 X-Stat-Signature: jrneohhabtua6a4s1xg44s1y6ozxdar5 X-HE-Tag: 1748625021-508808 X-HE-Meta: U2FsdGVkX1+uziJ7wqXEeo1wtdGA5OyjwHQ03qwoqxjc8plfvTs79P0sNDTuXlrly2BS7slPWj3FtTmLNVKKmbuc5+3Y9mnOM2JFuyXHmvr0mszA4RT3iCwtT63ONpnir8YF4b43zjaWDJswxIpJRsGWzYo9qkayn5O97HZabutSbJu0VnXc7DIlfhNc6re/RdPEHV3/uxhngSuTQAYh3Mv3hUnA2W/Tcq1ikRtwQDW4/JgfC8q7E6Bz8dkCYCziwFmfxZkbcFjC68nPvrWMxQfBrYEzLzx7q5oIdEhZstv2PbSkswERH3fhuQHROtnoms22pvzWiCOoJuIjB9dfBGr+OYFzz5vf0oeZbe8r5ArvHaqf/7RXtZ5Z70sBUUvh7Rso8zMYBzSJ2BAVq1WISrxDAEoAOzgQhcrrvbxuw4MeuABTQGHhjMEz/f6kRU++pWeYUABIjBAbVogs3uPJhQAPtbBjaaWJd3Vin1xQCmhDwVqVh/3FP+FhAUEQWh9ndPYcrAsiXe+veAO5tVyap2pppkpHvbzTOtNQDretPVgahBLh9qALgcRunTq0EBW0ZR/9lMumEKB38oYrcZzhLjLZNhd5k3wp7iEuxRZBY0srHRrhIfojOjw60bPEJY5SVwDErJ9i4pC7t9lAZj2UFPh5TISDalnoYKzILdxzpn1I1ZtUzNePUqLGV4m7UvamrWNAg4oSk+FCrgJ82q5cGI2AnVRs7XNhLNS4zzbyvKww3MyUIj6qZh5A7VGr1ZEjs4zSORRnfe6pfvf+rn0EulGfx5Q2NA3D4WR/Islq9T5Ywav+ZF8kzhNjnZSuATCFn4CRYs6BlzldIxwZqet7ynt7ke3dHYw9NZxsNaYf4Q4gaTCFSQdhGKKS3iWalKDwIdL4cR4JQkWStDlRPcVB/vuIStNp1UJIBPZKZH6LjfnmBm/ruFzaNwaQrfxVkp5zl22L94j8U5tkNtYhVOm HSj116YU ovnEpmderF8HdpRJegNW1TxBCVetl+qwtvQa0LJpmjng4MGFchBjSZssZCBuwTloVRoFmV73bUeYG2YrOHP4jnWz8GltZmiBaiP3F6qCT+nbsVvalVsvcsAgpSOuNBcjGTERCViq1exubr8HoimuFRQnewnZMLI9vY3PwbkegTJKC0PsQf6FjCuEpPbgeh+rv4LY1YtaH8L9H+vhn0mGa6RRA114cdExd+33ZWSM6YfLo2wN3KrBDjFgsZBlWSASvL1+/JSgE3M4qEDAmOsXJh+ISK7yV13/gDjIWasNljOZC3ozhHYYeZwMXWvrne1FcyH8IpUtgLBfo1mHTHnHxVyKzBh6LiMdr5EGv/wxHapsypMo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/30/25 18:22, Zi Yan wrote: > Since migratetype is no longer overwritten during pageblock isolation, > moving a pageblock out of MIGRATE_ISOLATE no longer needs a new > migratetype. > > Add pageblock_isolate_and_move_free_pages() and > pageblock_unisolate_and_move_free_pages() to be explicit about the page > isolation operations. Both share the common code in > __move_freepages_block_isolate(), which is renamed from > move_freepages_block_isolate(). > > Add toggle_pageblock_isolate() to flip pageblock isolation bit in > __move_freepages_block_isolate(). > > Make set_pageblock_migratetype() only accept non MIGRATE_ISOLATE types, > so that one should use set_pageblock_isolate() to isolate pageblocks. > As a result, move pageblock migratetype code out of > __move_freepages_block(). > > Signed-off-by: Zi Yan Reviewed-by: Vlastimil Babka