From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84DAC433DF for ; Mon, 15 Jun 2020 13:02:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8DEC82078E for ; Mon, 15 Jun 2020 13:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DEC82078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 26A376B000A; Mon, 15 Jun 2020 09:02:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21ABB6B000C; Mon, 15 Jun 2020 09:02:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1577D6B000D; Mon, 15 Jun 2020 09:02:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id F398B6B000A for ; Mon, 15 Jun 2020 09:02:57 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id ABD8718027699 for ; Mon, 15 Jun 2020 13:02:57 +0000 (UTC) X-FDA: 76931461194.09.rake43_430c30626df6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id A5977180AE817 for ; Mon, 15 Jun 2020 13:02:29 +0000 (UTC) X-HE-Tag: rake43_430c30626df6 X-Filterd-Recvd-Size: 4446 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 13:02:28 +0000 (UTC) Received: from [10.44.0.192] (unknown [103.48.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8F89206B7; Mon, 15 Jun 2020 13:02:24 +0000 (UTC) Subject: Re: [PATCH 04/21] mm: free_area_init: use maximal zone PFNs rather than zone sizes To: Mike Rapoport Cc: akpm@linux-foundation.org, bhe@redhat.com, geert@linux-m68k.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mm@kvack.org, rppt@linux.ibm.com References: <20200412194859.12663-5-rppt@kernel.org> <20200615062234.GA7882@kernel.org> <24563231-ed19-6f4f-617e-4d6bfc7553e4@linux-m68k.org> <20200615082937.GB7882@kernel.org> From: Greg Ungerer Message-ID: <5cae945c-1d15-9857-f7a5-defa884f7b3c@linux-m68k.org> Date: Mon, 15 Jun 2020 23:02:21 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200615082937.GB7882@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A5977180AE817 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On 15/6/20 6:29 pm, Mike Rapoport wrote: > (reduced the spam list) > > On Mon, Jun 15, 2020 at 05:17:28PM +1000, Greg Ungerer wrote: >> On 15/6/20 4:22 pm, Mike Rapoport wrote: >>> On Mon, Jun 15, 2020 at 01:53:42PM +1000, Greg Ungerer wrote: >>>> From: Mike Rapoport >>>>> Currently, architectures that use free_area_init() to initialize memory map >>>>> and node and zone structures need to calculate zone and hole sizes. We can >>>>> use free_area_init_nodes() instead and let it detect the zone boundaries >>>>> while the architectures will only have to supply the possible limits for >>>>> the zones. >>>>> >>>>> Signed-off-by: Mike Rapoport >>>> >>>> This is causing some new warnings for me on boot on at least one non-MMU m68k target: >>> >>> There were a couple of changes that cause this. The free_area_init() >>> now relies on memblock data and architectural limits for zone sizes >>> rather than on explisit pfns calculated by the arch code. I've update >>> motorola variant and missed coldfire. Angelo sent a fix for mcfmmu.c >>> [1] and I've updated it to include nommu as well >>> >>> [1] https://lore.kernel.org/linux-m68k/20200614225119.777702-1-angelo.dureghello@timesys.com >>> >>>> From 55b8523df2a5c4565b132c0691990f0821040fec Mon Sep 17 00:00:00 2001 >>> From: Angelo Dureghello >>> Date: Mon, 15 Jun 2020 00:51:19 +0200 >>> Subject: [PATCH] m68k: fix registration of memory regions with memblock >>> >>> Commit 3f08a302f533 ("mm: remove CONFIG_HAVE_MEMBLOCK_NODE_MAP option") >>> introduced assumption that UMA systems have their memory at node 0 and >>> updated most of them, but it forgot nommu and coldfire variants of m68k. >>> >>> The later change in free area initialization in commit fa3354e4ea39 ("mm: >>> free_area_init: use maximal zone PFNs rather than zone sizes") exposed that >>> and caused a lot of "BUG: Bad page state in process swapper" reports. >> >> Even with this patch applied I am still seeing the same messages. > > Argh, it was to early in the morning... > Can you please try the one below? > > It seems that coldfire didn't register all its physical memory with > memblock and the pfn list was damaged because of that. > > > diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c > index e779b19e0193..f66f4b1d062e 100644 > --- a/arch/m68k/kernel/setup_no.c > +++ b/arch/m68k/kernel/setup_no.c > @@ -138,7 +138,8 @@ void __init setup_arch(char **cmdline_p) > pr_debug("MEMORY -> ROMFS=0x%p-0x%06lx MEM=0x%06lx-0x%06lx\n ", > __bss_stop, memory_start, memory_start, memory_end); > > - memblock_add(memory_start, memory_end - memory_start); > + memblock_add(_rambase, memory_end - _rambase); > + memblock_reserve(_rambase, memory_start - _rambase); > > /* Keep a copy of command line */ > *cmdline_p = &command_line[0]; Yep, thats got it. Boots clean again with this one. Regards Greg