Re: [PATCH v2 2/8] minmax: Use _Static_assert() instead of static_assert()

Christophe JAILLET
2024-07-28T17:51:57Z

Le 28/07/2024 à 16:18, David Laight a écrit :
> The static_assert() wrapper provides the text of the expression as the
> error message, this isn't needed here as an explicit message is provided.
> If there is an error (quite likely for min/max) the wrapper also adds
> two more lines of error output that just make it harder to read.
>
> Since it gives no benefit and actually makes things worse directly
> using _Static_assert() is much better.
>
> Signed-off-by: David Laight <david.laight@aculab.com>
> ---
> v2:
> - No change.
>
> include/linux/minmax.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/minmax.h b/include/linux/minmax.h
> index cea63a8ac80f..ab64b2e73ae5 100644
> --- a/include/linux/minmax.h
> +++ b/include/linux/minmax.h
> @@ -48,7 +48,7 @@
> #define __cmp_once(op, x, y, unique_x, unique_y) ({ \
> typeof(x) unique_x = (x); \
> typeof(y) unique_y = (y); \
> - static_assert(__types_ok(x, y), \
> + _Static_assert(__types_ok(x, y), \

Nitpick, should there be a v3: a tab can be removed to keep things aligned.

> #op "(" #x ", " #y ") signedness error, fix types or consider u" #op "() before " #op "_t()"); \
> __cmp(op, unique_x, unique_y); })

CJ