Linux-mm Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hao Ge <hao.ge@linux.dev>
To: Uladzislau Rezki <urezki@gmail.com>
Cc: Dev Jain <dev.jain@arm.com>,
	Suren Baghdasaryan <surenb@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	Alexander Potapenko <glider@google.com>,
	Marco Elver <elver@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	Dennis Zhou <dennis@kernel.org>, Tejun Heo <tj@kernel.org>,
	Christoph Lameter <cl@gentwo.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	kasan-dev@googlegroups.com, linux-mm@kvack.org,
	Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v4 4/9] mm/vmalloc: BUG_ON() on an unaligned range in vmap_pages_range_noflush_walk()
Date: Mon, 16 Nov 2026 11:15:24 +0800	[thread overview]
Message-ID: <5d234178-7799-4603-82bf-40a70101f78a@linux.dev> (raw)
In-Reply-To: <avWtB-nWZUwLdQdP@milan>

Hi Ulad

On 2026/11/12 20:11, Uladzislau Rezki wrote:
> On Tue, Nov 10, 2026 at 07:25:41PM +0800, Hao Ge wrote:
>> The pte loop of vmap_pages_pte_range() maps whole pages and stops
>> only when addr lands exactly on end.  An unaligned end lets addr
>> jump over it and the loop keeps mapping into whatever follows the
>> range.  An unaligned start maps the page below the range with its
>> first pte.  That corruption is impossible to debug afterwards, so
>> bug out on addr and end at the entry of
>> vmap_pages_range_noflush_walk().
>>
>> Reported-by: Sashiko <sashiko-bot@kernel.org>
>> Signed-off-by: Hao Ge <hao.ge@linux.dev>
>> ---
>>  mm/vmalloc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>> index 27f2674a5556..86fbb1d2b27a 100644
>> --- a/mm/vmalloc.c
>> +++ b/mm/vmalloc.c
>> @@ -698,6 +698,8 @@ static int vmap_pages_range_noflush_walk(unsigned long addr, unsigned long end,
>>  	pgtbl_mod_mask mask = 0;
>>  
>>  	BUG_ON(addr >= end);
>> +	BUG_ON(!PAGE_ALIGNED(addr) || !PAGE_ALIGNED(end));
>> +
>>
> But why do we add this? We used to live without it and as far i see
> we have not gotten any report about any unaligned addresses un-maping.
> 
> The vmap allocator grantees that va->va_start/end have to be page
> aligned.

You are right that no in-tree caller passes an unaligned range today.
This came about after looking at
commit a739e6b557af ("mm: vmalloc: WARN_ON if mapping size is not PAGE_SIZE aligned").
That commit only guards the ioremap family. vmap_pte_range() is reached
through vmap_page_range() only, so what it protects is ioremap_page_range(),
pci_remap_iospace() and friends, which map physically contiguous ranges.

vmap_pages_range_noflush_walk() has the same loop and serves the other half of the picture,
the virtually contiguous mappings, where the physical pages behind the range do not have to
be contiguous, and since functions like vmap_pages_range() take addr and end from the caller as
they are, the page alignment is the caller's contract in the first place, so this is the same idea
as a739e6b557af and the check just makes that contract visible.

That said, dropping this patch is also fine with me. Nobody can actually trigger it today, as I said at
the beginning, so I will drop it from the next version.

Thanks
Best Regards
Hao

> 
> --
> Uladzislau Rezki


  reply	other threads:[~2026-11-16  3:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 11:25 [PATCH v4 0/9] mm/vmalloc: fix up vmap error handling Hao Ge
2026-11-10 11:25 ` [PATCH v4 1/9] mm/kmsan: undo the shadow mapping when the origin mapping fails Hao Ge
2026-11-11 21:03   ` Suren Baghdasaryan
2026-11-12  7:50     ` Hao Ge
2026-11-12 15:50       ` Suren Baghdasaryan
2026-11-10 11:25 ` [PATCH v4 2/9] mm/kmsan: skip vunmap_range_noflush when KMSAN is disabled Hao Ge
2026-11-11 22:10   ` Suren Baghdasaryan
2026-11-12  7:32     ` Hao Ge
2026-11-10 11:25 ` [PATCH v4 3/9] mm/vmalloc: BUG_ON() on an unaligned range in vmap_range_noflush() Hao Ge
2026-11-10 12:28   ` Hao Ge
2026-11-12  0:00     ` Suren Baghdasaryan
2026-11-12 12:23   ` Uladzislau Rezki
2026-11-10 11:25 ` [PATCH v4 4/9] mm/vmalloc: BUG_ON() on an unaligned range in vmap_pages_range_noflush_walk() Hao Ge
2026-11-12  0:16   ` Suren Baghdasaryan
2026-11-12  7:22     ` Hao Ge
2026-11-12 12:11   ` Uladzislau Rezki
2026-11-16  3:15     ` Hao Ge [this message]
2026-11-10 11:25 ` [PATCH v4 5/9] mm/vmalloc: BUG_ON() on an unaligned range in __vunmap_range_noflush() Hao Ge
2026-11-12  0:22   ` Suren Baghdasaryan
2026-11-12 12:15   ` Uladzislau Rezki
2026-11-16  3:21     ` Hao Ge
2026-11-10 11:25 ` [PATCH v4 6/9] mm/vmalloc: only flush the cache after the vmap succeeded Hao Ge
2026-11-12  0:30   ` Suren Baghdasaryan
2026-11-12  7:01     ` Hao Ge
2026-11-12 12:16   ` Uladzislau Rezki
2026-11-10 11:25 ` [PATCH v4 7/9] mm/vmalloc: undo partial mappings inside the mapping functions Hao Ge
2026-11-12  1:15   ` Suren Baghdasaryan
2026-11-12  6:27     ` Hao Ge
2026-11-12 12:19   ` Uladzislau Rezki
2026-11-10 11:25 ` [PATCH v4 8/9] powerpc: drop redundant unmaps of failed vmap mappings Hao Ge
2026-11-10 11:25 ` [PATCH v4 9/9] mm/percpu: stop unmapping the CPU that failed to map Hao Ge
2026-11-11 20:45 ` [PATCH v4 0/9] mm/vmalloc: fix up vmap error handling Suren Baghdasaryan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d234178-7799-4603-82bf-40a70101f78a@linux.dev \
    --to=hao.ge@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=chleroy@kernel.org \
    --cc=cl@gentwo.org \
    --cc=dennis@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=ritesh.list@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sshegde@linux.ibm.com \
    --cc=surenb@google.com \
    --cc=tj@kernel.org \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox