From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id E8BB3900086 for ; Fri, 15 Apr 2011 18:55:16 -0400 (EDT) MIME-Version: 1.0 Message-ID: <5d23c6c4-5d68-4c2e-af24-2a08f592cb8e@default> Date: Fri, 15 Apr 2011 15:53:47 -0700 (PDT) From: Dan Magenheimer Subject: RE: [PATCH] xen: cleancache shim to Xen Transcendent Memory References: <20110414212002.GA27846@ca-server1.us.oracle.com 1302904935.22658.9.camel@localhost.localdomain> In-Reply-To: <1302904935.22658.9.camel@localhost.localdomain> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Ian Campbell Cc: Chris Mason , viro@zeniv.linux.org.uk, akpm@linux-foundation.org, adilger.kernel@dilger.ca, tytso@mit.edu, mfasheh@suse.com, jlbec@evilplan.org, matthew@wil.cx, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, hch@infradead.org, ngupta@vflare.org, jeremy@goop.org, JBeulich@novell.com, Kurt Hackel , npiggin@kernel.dk, Dave Mccracken , riel@redhat.com, avi@redhat.com, Konrad Wilk , mel@csn.ul.ie, yinghan@google.com, gthelen@google.com, torvalds@linux-foundation.org > From: Ian Campbell [mailto:Ian.Campbell@citrix.com] > Sent: Friday, April 15, 2011 4:02 PM > Subject: Re: [PATCH] xen: cleancache shim to Xen Transcendent Memory >=20 > On Thu, 2011-04-14 at 14:20 -0700, Dan Magenheimer wrote: > > [PATCH] xen: cleancache shim to Xen Transcendent Memory > > > > This patch provides a shim between the kernel-internal cleancache > > API (see Documentation/mm/cleancache.txt) and the Xen Transcendent > > Memory ABI (see http://oss.oracle.com/projects/tmem). >=20 > There's no need to build this into a kernel which doesn't have > cleancache (or one of the other frontends), is there? I think there > should be a Kconfig option (even if its not a user visible one) with > the appropriate depends/selects. Yes, you're right. It should eventually depend on CONFIG_CLEANCACHE || CONFIG_FRONTSWAP though there's no sense merging this xen cleancache shim at all unless/until Linus merges cleancache (and hopefully later some evolution of frontswap). And once cleancache (and/or frontswap) is merged, there's very little reason NOT to enable one or both on a Xen guest kernel. Thanks, Dan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org