From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE79C433EF for ; Fri, 22 Jul 2022 14:08:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC7FB6B0074; Fri, 22 Jul 2022 10:07:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D77CB8E0003; Fri, 22 Jul 2022 10:07:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C180E8E0002; Fri, 22 Jul 2022 10:07:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B11CB6B0074 for ; Fri, 22 Jul 2022 10:07:59 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 800A6A0C74 for ; Fri, 22 Jul 2022 14:07:59 +0000 (UTC) X-FDA: 79714914678.16.0321D15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 1F78840085 for ; Fri, 22 Jul 2022 14:07:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658498878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l8a/WRegPOdZwKugMYKaaY0XGl8Dn+IbhTpt/OWCmYM=; b=X9CdrWCruPAYQTN5a3jf2VteiyA5bO4O5938/jRw0xsKB3gScxs9rNToE3hnrQcbFrPYUM rJJ4fpFBWzB0xFgEK2deRN/kHi0Eio6Xg0vZEREsf4y1iRAKM2Jm4Bme80RtND3ztgaw2N Inm93XRk6Zk4NjptcbwkazWcgTASyfs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-474-BIQPYoSkOkaB1vmOP_KEAw-1; Fri, 22 Jul 2022 10:07:50 -0400 X-MC-Unique: BIQPYoSkOkaB1vmOP_KEAw-1 Received: by mail-wr1-f69.google.com with SMTP id i9-20020adfa509000000b0021d865ce5e3so840428wrb.6 for ; Fri, 22 Jul 2022 07:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:organization:in-reply-to :content-transfer-encoding; bh=l8a/WRegPOdZwKugMYKaaY0XGl8Dn+IbhTpt/OWCmYM=; b=0ubmBDmj9f3HT8H84/GRKTvU885roEsFri4Il/kd/2t+DgRS1kQGufvKnJ/FhddJKe 3Qf9KZMlu/pju1OhDSfclop0QIPgUipGZ5vuuoF3GtvT8bkfVLGjKY5W3On0zHsfLozV vXqbXmjZcjxwmRCwayufUFXQcFByrlTFI0rfW1cwGci4fLzuH9RAjCRvU4yHIYWsr+TD 1ADIs5Nk3ZGNCSFMlAcwUeIf2fRmBsf06lq/NGc9OX3QECDU0m8Llz/Nwbd/64wN3aAG rLshWLZZH9LantfWGaCdoHK806O0eQuYq2ohomQ6tkkyXOOEcWE8IhEyKG1+m1FJp2pI QNpg== X-Gm-Message-State: AJIora+ujmIe8YXArQkQ54VFXRZuCBklc3QviNPi76el9CDbq8+q8AA8 gKVuv2BDg4XRA9/Qvl/+Lajh0x/qHXnbFhY8tVSaDS56aPbMUbYCJqGLFXDkQHFtAO8UWs89u2f uf6Q3CLlT+lw= X-Received: by 2002:a5d:53c9:0:b0:21d:62f8:f99f with SMTP id a9-20020a5d53c9000000b0021d62f8f99fmr87939wrw.214.1658498868939; Fri, 22 Jul 2022 07:07:48 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vSshwyGQ0KMdrtp15M6q3/lUK221PemuB2tK0wPeqzQSMsQkjQT4Af4VIpFnru8cRx2EZfXQ== X-Received: by 2002:a5d:53c9:0:b0:21d:62f8:f99f with SMTP id a9-20020a5d53c9000000b0021d62f8f99fmr87909wrw.214.1658498868518; Fri, 22 Jul 2022 07:07:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:cb00:cd6b:7964:cc7d:b0e6? (p200300cbc707cb00cd6b7964cc7db0e6.dip0.t-ipconnect.de. [2003:cb:c707:cb00:cd6b:7964:cc7d:b0e6]) by smtp.gmail.com with ESMTPSA id q5-20020a1ce905000000b003a0323463absm5206666wmc.45.2022.07.22.07.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 07:07:48 -0700 (PDT) Message-ID: <5d6c745e-219c-3abf-a30d-b3fb8e8e752c@redhat.com> Date: Fri, 22 Jul 2022 16:07:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/3] selftests: soft-dirty: Add test for mprotect From: David Hildenbrand To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Andrew Morton , Andrea Arcangeli References: <20220721183338.27871-1-peterx@redhat.com> <20220721183338.27871-3-peterx@redhat.com> <8fbbd68f-267c-1e0d-a578-7da4551c4c19@redhat.com> <8fd4d9fa-7370-3d97-20d0-a4dfed914600@redhat.com> Organization: Red Hat In-Reply-To: <8fd4d9fa-7370-3d97-20d0-a4dfed914600@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658498879; a=rsa-sha256; cv=none; b=wq9CKG8IP4nB6yv55l+LugYLw+DFrR4TcNJTJrEPJzqGvzlZH8ApN44dRMNtqM3yHwlkU3 8SxoxiEcFDITcbtmTunD8wgoE15BYJbzB7g4ubJL3GSMRxI1J2h19u+ULBTpqECSMPXk6u Jnyt2CVqQT/b+5sTbg6b3xNzr2uW9Aw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X9CdrWCr; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658498879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l8a/WRegPOdZwKugMYKaaY0XGl8Dn+IbhTpt/OWCmYM=; b=3X2VXTXrVfh5uXsIyHPAKvf6UMcUjsKdN/EDt/ndge5J3zhn/9cN03PTtccjFF/XqfwTXd JECK62YqShwIi2+ggMdNaTZV7w6DirqEhbuNK5e0lYxfpXJ2fg3OwzARCz+YKE0bBT51JX Q696L/8DJjuhqyQNPN8p/tNxRfnuYe0= X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 1F78840085 X-Stat-Signature: d8ztdba9rtgrs8zpenr698emgcic41pb Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=X9CdrWCr; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf01.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-HE-Tag: 1658498878-955162 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.07.22 16:00, David Hildenbrand wrote: > On 22.07.22 15:44, Peter Xu wrote: >> On Fri, Jul 22, 2022 at 09:17:34AM +0200, David Hildenbrand wrote: >>> On 21.07.22 20:33, Peter Xu wrote: >>>> Add two soft-diryt test cases for mprotect() on both anon or file. >>> >>> s/soft-diryt/soft-dirty/ >> >> Fixed. >> >>> >>>> >>>> Signed-off-by: Peter Xu >>>> --- >>>> tools/testing/selftests/vm/soft-dirty.c | 69 ++++++++++++++++++++++++- >>>> 1 file changed, 68 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/tools/testing/selftests/vm/soft-dirty.c b/tools/testing/selftests/vm/soft-dirty.c >>>> index 08ab62a4a9d0..7d93906aa43f 100644 >>>> --- a/tools/testing/selftests/vm/soft-dirty.c >>>> +++ b/tools/testing/selftests/vm/soft-dirty.c >>>> @@ -121,13 +121,78 @@ static void test_hugepage(int pagemap_fd, int pagesize) >>>> free(map); >>>> } >>>> >>>> +static void test_mprotect(int pagemap_fd, int pagesize, bool anon) >>>> +{ >>>> + const char *type[] = {"file", "anon"}; >>>> + const char *fname = "./soft-dirty-test-file"; >>>> + int test_fd; >>>> + char *map; >>> >>> Instead of fname, unlink, open, close, unlink you can use a tmpfile >>> >>> FILE *file; >>> >>> file = tmpfile(); >>> if (!file) { >>> ksft_test_result_fail("tmpfile() failed\n"); >>> return; >>> } >>> test_fd = fileno(file); >> >> Note that tmpfile() should by default fetch from /tmp which is very >> possibly a tmpfs afaict. It's tricky in this special test case since I >> don't think tmpfs can trigger this bug (shmem doesn't define page_mkwrite). >> > > I don't think we need that? SOFTDIRTY tracking enabled should be > sufficient, or what am I missing? > I think you're right that it doesn't work with tmpfile. I do wonder why, because I'd have thought that it's sufficient for vma_wants_writenotify() to return "1" due to the vma_soft_dirty_enabled() check. Hm .... -- Thanks, David / dhildenb