From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A90EAC54E65 for ; Thu, 22 May 2025 12:42:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 379E16B0082; Thu, 22 May 2025 08:42:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32AF86B0083; Thu, 22 May 2025 08:42:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 219B56B0085; Thu, 22 May 2025 08:42:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 02C6A6B0082 for ; Thu, 22 May 2025 08:42:09 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A2FB981368 for ; Thu, 22 May 2025 12:42:09 +0000 (UTC) X-FDA: 83470506378.09.F66BCCC Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf03.hostedemail.com (Postfix) with ESMTP id 855072000E for ; Thu, 22 May 2025 12:42:07 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SFcBA0Tf; spf=pass (imf03.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747917727; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k8h8VMy7nG682XM9lhzNlq6IHy3T2cGrxMUNGDBFIHI=; b=QZ8byCB3wpVxKhEYlVgoNtxMxFv+/I+XyDpGZx8OGOmqwErwPvsRGFSkRBJRSqOSOmHkQY iJBYafUW1PviNZ6+zif/fJzmMk6Mk2p8TXWqWabvd8vrvU0kGSvrblzMbyAfkMXwYse5Le KrmPX0iSxw4KVR5IATjpUhRHiSQm5Qc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=SFcBA0Tf; spf=pass (imf03.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747917727; a=rsa-sha256; cv=none; b=x0VG29Fn7wPRbleY7xGPzZIMc7Dt5Jy2qTiVpgldU4DJaXvC83WbqVDZLc/oshbF3YdSOp n33PnGpSGwJNqGRpwA7pw1Zg3foEx4OBorhCIffor6pR6uhFrfX5KSA3g+tw8Eg+LdfkdC MTIzg1s1Ly5hNubuwAdkxMhECrZN4XM= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5fff52493e0so9372861a12.3 for ; Thu, 22 May 2025 05:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1747917726; x=1748522526; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k8h8VMy7nG682XM9lhzNlq6IHy3T2cGrxMUNGDBFIHI=; b=SFcBA0TfYj9k/qE0qxT7Ns5P+InEN0sPDd9mpqa8OeVNM8+ILja+41Twjjbs8EhlAX 7PL+xMJLyCS7jW4HVLIeo82+M3eEX07Z8cmNS3eXgtrI4EJZKpz6RU4pgJHVvREktpmi 1pckv3ioNBdKPG3btuOjj2ghXvSnVnzBJPXUu2B22NnpCZaifhZTLf+QL4kFn4trvjiY UsoatNJgSo/5LLeExFABKfO82KDK2e4xlMzQROYgDHQLlX0QFzoJRbv+T+Rq+f6x2hZC GFlpcpMmN441ThT1m9+C84y95cXjl4NLWcfAYL+5HhzwV55RsymktD0YCqkrNtj7ulC8 f5+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747917726; x=1748522526; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k8h8VMy7nG682XM9lhzNlq6IHy3T2cGrxMUNGDBFIHI=; b=e6Qz/yfPW222LC95mONUu9Ma1U7g87lpayvQlj7AtMkB0tfjhPl8upkBEq4JSykbUu FBTx3CCT4C+LcD2liyrWMJ5rgrB1QUHw4UcXMhw/Rlf6i6HyNdhXRcnXsiaX0sxtL4JX jhHg+pNu06p9a1pwQYB1mQVAAQ2g9ESiV7b2LjQJIKO9p8+UCslmZoRG51EeAxARerxO z2nA66pLyhEVtPXfvOznOTCTtZMgYdGcd1wYQIZELTwVLegX8+mSenpCNh7hC8L++Ywh 78cTebAveZ/0cndtrrVEnaE08wPtR+DhHtckTGFb5/32ybHjr/VJNtviqCuKjxwzMbRt Rd+g== X-Forwarded-Encrypted: i=1; AJvYcCWp7oKBoMcQrGkKnj2VkJpc+Ak8QS520Y1HhE/H//h2NbSRuieZf3ce73w4/0jgIcwfdOYi8F3xNg==@kvack.org X-Gm-Message-State: AOJu0YxAWn1m/OBg1N32TqAFawNWSvxEdKgmWQGgZb/N5zOxMmHPrHH1 XbGEiAXA92D4ltVwGHjj/MxdiHy1SwzynECFwFlCG2uEYJBVoDNrSMJN X-Gm-Gg: ASbGncu+FWPdFbW/i2246TgkVtsmKbtd9L7g6KhC1iWKpX0SwPrzpqqWDuUZKgUFShz XMc8tulRuklUrbMH2DdFDCTCNczlxFLVImjFpDL4ltivwzzjH4KnOmRfXzxVCW1htVZ8LSiNv9S 5fK8qhXuNZhqeVLZ4A8h2XZNh6qmaHNkpVYhdHl2qBgNB/9xQAWHtQRsPPjS9QrJdtMloTrBb3Y ZWyG9rwWSeUsDYBxNfA0mzm/UyTmB53SUpdgweAEvWTRtc+NHOBjAhP8jLGt3J+zs3tiB2lhQHC HaFYgU71NBeBW2zNzCEEsGVSyXHtBxAg+XNzra8xNoljIIGRwhoE7555D7NyUTMrQ8QqZ3EYMqQ yZVRGLJnbwS8TY9A3nWjJMKf4tSBt X-Google-Smtp-Source: AGHT+IHLAVBPibuhf8QzjbXW44030B4EB047Zq+RDL9gWkT9nEi3cm3/MnD48ZG0WtiuwILtclqN+A== X-Received: by 2002:a17:907:1c92:b0:ad5:59ef:7f56 with SMTP id a640c23a62f3a-ad559ef8c28mr1973309466b.48.1747917725536; Thu, 22 May 2025 05:42:05 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:58:b3b6:ff61:e825? ([2620:10d:c092:600::1:d7d1]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad52d06b532sm1064205466b.43.2025.05.22.05.42.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 May 2025 05:42:05 -0700 (PDT) Message-ID: <5d8afe59-497b-4ff9-bea1-ede1f48772e0@gmail.com> Date: Thu, 22 May 2025 13:42:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: slub: only warn once when allocating slab obj extensions fails To: Harry Yoo Cc: Shakeel Butt , surenb@google.com, Andrew Morton , hannes@cmpxchg.org, vlad.wing@gmail.com, linux-mm@kvack.org, kent.overstreet@linux.dev, linux-kernel@vger.kernel.org, kernel-team@meta.com, vbabka@suse.cz, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev References: <20250520122547.1317050-1-usamaarif642@gmail.com> <20250520122547.1317050-2-usamaarif642@gmail.com> <64b19c8f-e02e-490b-b987-9a996f36be21@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: fx3cytqn7xxfzs57pejpzu1ydqadfwp1 X-Rspamd-Queue-Id: 855072000E X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747917727-915296 X-HE-Meta: U2FsdGVkX19fernBQgErq0I95L3cGZsC9aztp5uPPxoXOPcBEMgUEYlm8VNbguczBrbLLjakclVAI4rSKm/mxQBqbQRHZgvEQYxAZgswFK+/o57oPz267hSZ7/ODkbOG+Q6z3Y2Bh92ne5m33Cvs+KgUjh2ytkNLfnXmG9upqRvVi2XEQReq6CilzjI55d6CRcW5asEaPLrPJ2f9CsrkeGVT5BKg8U4lmFWTPxi1T7hlnwfiXjTFCM6gKYM5D/npJzZVY16JZWoejORFNuntXSEb0Z4F4bTFjs2fl26x7zouZinIdY6TOd4hK9bHpBZw1pXw04B3fBAKG1VsM/zaprQnBIxSwW/bXmPORYOyxa2/5MMqsG+9xMzQnuESobgGxHS/svD5ZvcYaV/WyrNugPtw6Dl8yDq9AbqNsEB3tuh6AXMY6iel1nHl60m+SrRX57D4vS3SChkRpeRx90M23XttmP/eHGsGWFK4fo68ROvb4ikX43zvMtGCSBO7EWcIS+RLLE3u8p94EMkzoZc3q/cBMhrU42IKqoIjvk/bDMYmXxjrnI6OMxtVTzJm/5h7ss3rQCQh6IpWda6/DV1fCyYXNHw8/2Ilp6joxEOO52/gAitqtoPLvu0gNyU05at5OWqJst/EuK7SzEj9OY5hU29pT1bn7NJlTI9gqfeQXwZLyxSGxSfMAcqHLYNq2Gs6bng5kaaUZhERR2sFmgxGCv8LX8EKQLTzS43HOtrbiORYnD8dQO+HtHqJZ6cd4VYl1ha/g+bNsI9KrADwcz78wwMnJRXsuywIghfBhOfi+2yR8DmtBlzO9YtUlqbsLg78MftLiv1yxta9qT6HTubXfc/FasUPcNiaNgU1+UegOaJjjbjSNObsf+tOy+3gSanGPmfqBBWYcfNTCFU8ENVeIVs3UDfx9dpCDTL55yj4BfabJs9zvqYZym+CmNbMt92LAyXRGKqIIONVNsVkG3e K1BJN6cZ NyQMtxIfMJ0Rm96MKVYSVlUnb9kiU6TQ+0SH7Zlxuf5JPDnqaw/PT0vO+XS1yag5BH6qna7nywajfZfjr+AVYacTZl4UGv2Y25BJ+DrftArOpNcEkzM46e8X9cyktX2DX4OZEzOtHo/2Uy+9Oq9yz5XnLyLFiGmZZHm75HsRcykPY5E5KAxVbVX8b/VBqpzhkCSKgFfqzRBNxoE2swLMmQfAY//W2vZKEbqQeZHiQ+Yv+YQiFD0T6cVYmRYphyvQQGD8LAyaav0ECj3ewVRhQdDBiNpgg+Nx++f6sODGpfUMutB5/EkSy5KvvSaRtkRUI1Qin/RbfDEknWMP9AzZsv3SVGFgsdJVLLZFf7shTIPmOR5aDSZ0RGQhJV30NcV/c4CFFDvEsAutcg7D/W3BRJRj8CXq8pKx5RuGSfeZz/YhLAWgwlQonsDAwHN3sCmZVg0tZt4cwWO+N7d+M7KjtjhtF7Q47In0XT2HCUMxJzC7C6iWiWPjatTiQZrXD8R8IV56RJv5rp/kIrab7btI7UwNQ4QKKspHTrX58cPnG/IIs+zw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22/05/2025 01:16, Harry Yoo wrote: > On Tue, May 20, 2025 at 04:22:16PM +0100, Usama Arif wrote: >> >> >> On 20/05/2025 15:18, Shakeel Butt wrote: >>> On Tue, May 20, 2025 at 02:42:09PM +0100, Usama Arif wrote: >>>> >>>> >>>> On 20/05/2025 14:34, Harry Yoo wrote: >>>>> On Tue, May 20, 2025 at 01:25:47PM +0100, Usama Arif wrote: >>>>>> In memory bound systems, a large number of warnings for failing this >>>>>> allocation repeatedly may mask any real issues in the system >>>>>> during memory pressure being reported in dmesg. Change this to >>>>>> WARN_ONCE. >>>>>> >>>>>> Signed-off-by: Usama Arif >>>>>> Reported-by: Vlad Poenaru >>>>>> Closes: https://lore.kernel.org/all/17fab2d6-5a74-4573-bcc3-b75951508f0a@gmail.com/ >>>>>> --- >>>>> >>>>> Hi, >>>>> >>>>> Please Cc SLAB ALLOCATOR folks in MAINTAINERS on patches that touch >>>>> slab code ;) >>>>> >>>> >>>> Thanks for adding them to CC! I was just thinking of this as a memory >>>> allocation profiling issue and added the maintainers for it, >>>> but should have added slab maintainers as well. >>>> >>>> >>>>>> mm/slub.c | 2 +- >>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/mm/slub.c b/mm/slub.c >>>>>> index bf43c403ead2..97cb3d9e8d00 100644 >>>>>> --- a/mm/slub.c >>>>>> +++ b/mm/slub.c >>>>>> @@ -2102,7 +2102,7 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) >>>>>> >>>>>> slab = virt_to_slab(p); >>>>>> if (!slab_obj_exts(slab) && >>>>>> - WARN(alloc_slab_obj_exts(slab, s, flags, false), >>>>>> + WARN_ONCE(alloc_slab_obj_exts(slab, s, flags, false), >>>>>> "%s, %s: Failed to create slab extension vector!\n", >>>>>> __func__, s->name)) >>>>> >>>>> I think this should be pr_warn_once()? >>>>> I'm not sure why this was WARN() in the first place. >>>>> >>>> >>>> Isn't WARN_ONCE the same as pr_warn_once but with needing the condition >>>> of the first arg to be true? We only want to warn if alloc_slab_obj_exts >>>> returns non-zero. So WARN_ONCE should be ok? >>>> >>> >>> The difference is the impact on panic_on_warn users which are mostly >>> testing bots. This warning is not actionable, so I agree with Harry to >>> covert this to pr_warn_once(). >>> >> >> Sounds good! Will change it to below for the next revision. >> Will wait for the kvmalloc conversation to conclude before sending >> the next revision. >> >> diff --git a/mm/slub.c b/mm/slub.c >> index 08804d2f2ead..ab0b7ee87159 100644 >> --- a/mm/slub.c >> +++ b/mm/slub.c >> @@ -2101,11 +2101,13 @@ prepare_slab_obj_exts_hook(struct kmem_cache *s, gfp_t flags, void *p) >> return NULL; >> >> slab = virt_to_slab(p); >> - if (!slab_obj_exts(slab) && >> - WARN(alloc_slab_obj_exts(slab, s, flags, false), >> - "%s, %s: Failed to create slab extension vector!\n", >> - __func__, s->name)) >> - return NULL; >> + if (!slab_obj_exts(slab)) { >> + if(alloc_slab_obj_exts(slab, s, flags, false)) >> + pr_warn_once("%s, %s: Failed to create slab extension vector!\n", >> + __func__, s->name); >> + else >> + return NULL; > > Returning NULL when alloc_slab_obj_exts() succeeds doesn't make sense. > I think you meant something like this? > > if (!slab_obj_exts(slab) && > alloc_slab_obj_exts(slab, s, flags, false)) { > pr_warn_once("%s, %s: Failed to create slab extension vector!\n", > __func__, s->name); > return NULL; > } > Yes, Thank you! >> + } >> >> return slab_obj_exts(slab) + obj_to_index(s, slab, p); >> } >> >