From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5472C77B76 for ; Mon, 17 Apr 2023 18:28:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 100EE8E0001; Mon, 17 Apr 2023 14:28:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B1486B0072; Mon, 17 Apr 2023 14:28:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBBD58E0001; Mon, 17 Apr 2023 14:28:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DE26A6B0071 for ; Mon, 17 Apr 2023 14:28:56 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AE8BB1C66CD for ; Mon, 17 Apr 2023 18:28:56 +0000 (UTC) X-FDA: 80691719472.30.EA794E6 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf09.hostedemail.com (Postfix) with ESMTP id BA4C3140011 for ; Mon, 17 Apr 2023 18:28:54 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=LOBAzaOn; spf=pass (imf09.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681756134; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0lqi6e8RVymVTF7fcFUOheURxMqgPbsBHzaUXSbYH78=; b=WFYozFMclr2VUxZMYS2rla8TngMSHfgRftwUBPcAbe7ypXaTxM2p0WDgQ6Mn7ncR7pGrsI VORJ5/15HznVerCEqZkzvqYF5rcDMK4XHpHVCUt1V/vAvFOw9UmaYW3iu+3OlIvjhqmtL/ d85bhBzIfPcsMCTMgDttNkmCakljGW0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=LOBAzaOn; spf=pass (imf09.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681756134; a=rsa-sha256; cv=none; b=ORzEzdFTgwTPfx0BSVhRaXtWmePrXbZZqQw3WXP7HQY/cp/UOtQbJknEvPFQXFFMogoh4D 9RmeXQl5LRRiV6J3tDL6wnrIvKa/AGglDjTS8R2ZwVIJ9Zy61thyyGkB0EyAmPbt2fr9Td etYjgVRe8AZwI96Lx2dMfsUxcedmnsY= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5067716f9e7so427936a12.0 for ; Mon, 17 Apr 2023 11:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681756133; x=1684348133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0lqi6e8RVymVTF7fcFUOheURxMqgPbsBHzaUXSbYH78=; b=LOBAzaOnsbv+xJP9yrRAQZbI6B1nC83pWaavjbDytCM09qdqR5xvP/kOGyGhyhJitE KeFPQxLE9aNAeW1K964mlXNqJnmye34SZhx0h6fSjZutXCXd9fORM/8rV2tklwzzLNQZ unFClX8U9/out3OBbsRqjF9TqIZvUyxfnirs0dD5tVubtnARlTCHDsVc9473jaXtDh9u yQo8XH/bcZziG8vVyG4OQ7yQJpWLA0UsdMHpOjfJB2LbZnfjTok5V2+a/6Ge25MLKsFi D0H0C9s5cYSU+CGEfWy7YlAoMvB6Zpw6/uropFfLFEjewyhLKYjtqFIYkDDkCX3R08Xb WqsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681756133; x=1684348133; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0lqi6e8RVymVTF7fcFUOheURxMqgPbsBHzaUXSbYH78=; b=Q+TGN8nOLi2d+J9QYESabK4nvFPNhfyfM1tfWIKmc5O/srRt6nd5LpVMsw/wh4d5R6 8UIJT62q12nHXudYJDDib/YpnaMQkrHW1xYeZ5UEOljpUwS72CPJjFT02UamLVOU27px BtRqsUondJS41lc7vk6+rkXRxUQmOxnbF58+YxvEQxAV5guvYUT4HMcY6x8AqXSBx9Z1 FWyO8txWibtggtON2osn3rMLduqqLrjaPKn+PZMacAEn3Ruu/gU72iTT/cTwcjQ3BiiP 8F0c/3mcOJHml4BFN1n2QBaFRt+A3Z4zVrQFFgAkVYiK3Hg8l8ummR4Q7EOeipqNQBsU iMzw== X-Gm-Message-State: AAQBX9fVGSNYZUgyGnUQfWVb+cSZnqMXsBXq230xFTIjrQ78crQEbaKJ C+G9cUsu144frA3xSVMD8dg= X-Google-Smtp-Source: AKy350YbvOqbJZgTK9Sfz/uzC+CuwIZ0d5X/ModBjEaxuEa/1srzK+Ja6pWa6tWd/92z8dNPYbu33w== X-Received: by 2002:a17:906:7a45:b0:947:bff2:1c2d with SMTP id i5-20020a1709067a4500b00947bff21c2dmr11215147ejo.3.1681756133240; Mon, 17 Apr 2023 11:28:53 -0700 (PDT) Received: from [192.168.10.10] ([37.252.92.4]) by smtp.gmail.com with ESMTPSA id e17-20020a17090681d100b0094f2f1c5ea1sm3618588ejx.174.2023.04.17.11.28.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 11:28:52 -0700 (PDT) Message-ID: <5dc97e10-8c64-4818-2642-dd8edb21c016@gmail.com> Date: Mon, 17 Apr 2023 22:28:51 +0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] mm: khugepaged: Fix kernel BUG in hpage_collapse_scan_file Content-Language: en-US To: Andrew Morton , Zach O'Keefe Cc: Yang Shi , himadrispandya@gmail.com, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-mm@kvack.org, skhan@linuxfoundation.org, syzbot+9578faa5475acb35fa50@syzkaller.appspotmail.com, Mike Kravetz , "Kirill A. Shutemov" , Matthew Wilcox References: <20230330155305.423051-1-ivan.orlov0322@gmail.com> <20230331013301.ecgkjymaf3ws6rfb@google.com> <20230416113335.caeafda1328fdd4bfe2406e8@linux-foundation.org> From: Ivan Orlov In-Reply-To: <20230416113335.caeafda1328fdd4bfe2406e8@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: BA4C3140011 X-Stat-Signature: qwmppttho9t3mtfqxk5onwoybghn8paw X-Rspam-User: X-HE-Tag: 1681756134-169993 X-HE-Meta: U2FsdGVkX1/I79EsPVj4SzkZlrOVejzsBCVekCnK7lxi1YH0hp9eUtuTATQq2+f5KSfmLWHITZ9MKiV7Xoa9OGwItTPaPWtbvbQ4cAEcReByJGBMQ0UgeuVT1Yy0TOVWloh31Vfmv+K4CedXOaeF9+ygrV94keLw7ZSFPJ60VuTt9xxBPsVBlNZwbWFaiw1ijWiC68U93Qw+KPktbmKwVzlzO3Yw9FFgmVIrXsPcr6uu1uOrvcSp+ckS8bTJ3t0mo4WY3iDhhlqPIoQeQ1gZESDqgQgFmYDbPthZNXMelP9+BWCWdnUMzkf1R50EKQwdxqYOOMTZ9cNq7awIB80zu8rsQg4D5aPzUqRWMydZVmVmRK8b6CSQLvr4kd824P5zMSd6HcYNFFo5q9HA6GlX+wQXeCQHuU7YeNQdxPkkscCfv60LrkJc+dbbufn4mjUTLMg8Dmh/MqGlhDtgVN0mnvA6TLIM5yDJOdhFJB98+FMpeqvAqgwH7BZa3+EYtqCp/UYTGf9BxMHumPgYhrX7rN07hoNFfnXdnT/0lRnT8ZECRdFsQga/ikPxq27WwyfVHQS7uBepr4MwWl8lC2hbh37ULsfv6zWm/rd3OqlAFoA7odSlUTWfI1izaYUaGVWkXvPlf9L5Z2F7E/kcT0572ZSIxe0px3bX+IG3owdw1M0uWcXnRNvWwloFHqCCXD8qc5n5+vxZmA4vsJiYtqMjl8Pg8xjtKSmuGzSncJFezSSffUhvFTPF0+srj6a9nEaPNn1O1YnxvEDqXVNoRcv+6H3zgEsJeFkXZc6hATdQ04H996Q9k7mlGpG9niHDNHuBjJ5ki81KLTX1ZWgC0/A4vvmIlQgw6FR5x+5pnp0aKbEwEl4SfPfYuoHjwGTNWjeJK2r49ryBRuidEkkpsJMQXUBpdHHsYoDU/nLcyNl0cO14PJxcdeDtfFSlvWN6sFv13hw0D94PiI6c+4mhS4I CUY0Y8bS QkvUfN0zKyYbD4EcK/gnVlhBLA3AId1AvlJDhU56pbH/wXgoLmJD7WE1eFXEnLkyg7UpiArdIOw/gJiXAtNy/8cuLMNSTmcftTvyclsQfghzgNrUfVTEeixUszhTzY/jc7hZT9m3wVrgc9U/0Glq6Ch+1Tn5Ce/WcnS9VEKwFF64L1+1K587ryuVi6UqJ2HwGLB3IvU/Fz2EaDhYDnmJK9Aq2RMLmOHawXz7MN7rm6REtdS9nzyGD5xyVK7rHLZdqvUGQvL8K+hha4YppPxPk4UOKbqDAOqShSQnCtlKdIsw3mAVQ6v0slrmb1nzTxaj+gCfAZYo0NWE+4pLXOB9ATgNWpf7H+sk/tBjFqqCpJqElnSrPMesrAMJCgyEwC2BymuTGKasZUUxkgl+hN7cbNsgWWNnx6M/Jry02b0Vo++OHnXiEpKjBANzUk0PvbxOzd215x4pLRTZYt8xlgZl5ya05FZvqk2TAGss427g6YBnGQ6RLEarKDJgCEIo4pQQeNmwaRH1j6XzzYoVnDAvj5mh0V+wUZBNy4eijMfAvDVCIA0IzAe+tLEMdB70UHPyl5Uu1+n7SDqsrHCpsAaIomiFBQB+UeBB5WN6ZShhB2KEgCnRVIEtRACrMNgXSA/LpzAHSU34wVLkF2vnnNzmxDzJtdZkZyFT+QoQsYB6soOfx9F2OdyOV+drLKw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.04.2023 22:33, Andrew Morton wrote: > > Circling back to this fix... > > The BUG() is obviously real. We're unsure that Ivan's fix is the best > one. We haven't identified a Fixes:, and as this report is against the 6.2 > kernel, a cc:stable will be needed. > > According to the sysbot bisection > (https://syzkaller.appspot.com/bug?id=7d6bb3760e026ece7524500fe44fb024a0e959fc), > this is present in linux-5.19, so it might predate Zach's > 58ac9a8993a13ebc changes. But that bisection claim might be > misleading. > > And Zach is offline for a few months. So can people please take a look > and see if we can get this wrapped up? > > Matthew, the assertion failure is in the > > VM_BUG_ON(index != xas.xa_index); > > which was added in 77da9389b9d5f, so perhaps you could take a look? > > Thanks. Tested today on the latest rc7, the bug still exists. Kind regards, Ivan Orlov.