From: andrey.konovalov@linux.dev
To: Marco Elver <elver@google.com>, Alexander Potapenko <glider@google.com>
Cc: Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
kasan-dev@googlegroups.com, Evgenii Stepanov <eugenis@google.com>,
Oscar Salvador <osalvador@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>
Subject: [PATCH v3 03/19] lib/stackdepot: drop valid bit from handles
Date: Mon, 23 Oct 2023 18:22:34 +0200 [thread overview]
Message-ID: <5e251a589cb3142607ec5af8fcb904d424702a14.1698077459.git.andreyknvl@google.com> (raw)
In-Reply-To: <cover.1698077459.git.andreyknvl@google.com>
From: Andrey Konovalov <andreyknvl@google.com>
Stack depot doesn't use the valid bit in handles in any way, so drop it.
Reviewed-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
---
lib/stackdepot.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 0772125efe8a..482eac40791e 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -32,13 +32,12 @@
#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8)
-#define DEPOT_VALID_BITS 1
#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */
#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER))
#define DEPOT_STACK_ALIGN 4
#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN)
-#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_VALID_BITS - \
- DEPOT_OFFSET_BITS - STACK_DEPOT_EXTRA_BITS)
+#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \
+ STACK_DEPOT_EXTRA_BITS)
#define DEPOT_POOLS_CAP 8192
#define DEPOT_MAX_POOLS \
(((1LL << (DEPOT_POOL_INDEX_BITS)) < DEPOT_POOLS_CAP) ? \
@@ -50,7 +49,6 @@ union handle_parts {
struct {
u32 pool_index : DEPOT_POOL_INDEX_BITS;
u32 offset : DEPOT_OFFSET_BITS;
- u32 valid : DEPOT_VALID_BITS;
u32 extra : STACK_DEPOT_EXTRA_BITS;
};
};
@@ -303,7 +301,6 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc)
stack->size = size;
stack->handle.pool_index = pool_index;
stack->handle.offset = pool_offset >> DEPOT_STACK_ALIGN;
- stack->handle.valid = 1;
stack->handle.extra = 0;
memcpy(stack->entries, entries, flex_array_size(stack, entries, size));
pool_offset += required_size;
--
2.25.1
next prev parent reply other threads:[~2023-10-23 16:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 16:22 [PATCH v3 00/19] stackdepot: allow evicting stack traces andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 01/19] lib/stackdepot: check disabled flag when fetching andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 02/19] lib/stackdepot: simplify __stack_depot_save andrey.konovalov
2023-10-23 16:22 ` andrey.konovalov [this message]
2023-10-23 16:22 ` [PATCH v3 04/19] lib/stackdepot: add depot_fetch_stack helper andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 05/19] lib/stackdepot: use fixed-sized slots for stack records andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 06/19] lib/stackdepot: fix and clean-up atomic annotations andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 07/19] lib/stackdepot: rework helpers for depot_alloc_stack andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 08/19] lib/stackdepot: rename next_pool_required to new_pool_required andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 09/19] lib/stackdepot: store next pool pointer in new_pool andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 10/19] lib/stackdepot: store free stack records in a freelist andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 11/19] lib/stackdepot: use read/write lock andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 12/19] lib/stackdepot: use list_head for stack record links andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 13/19] kmsan: use stack_depot_save instead of __stack_depot_save andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 14/19] lib/stackdepot, kasan: add flags to __stack_depot_save and rename andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 15/19] lib/stackdepot: add refcount for records andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 16/19] lib/stackdepot: allow users to evict stack traces andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 17/19] kasan: remove atomic accesses to stack ring entries andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 18/19] kasan: check object_size in kasan_complete_mode_report_info andrey.konovalov
2023-10-23 16:22 ` [PATCH v3 19/19] kasan: use stack_depot_put for tag-based modes andrey.konovalov
2023-10-24 9:32 ` [PATCH v3 00/19] stackdepot: allow evicting stack traces Anders Roxell
2023-10-24 13:13 ` Marco Elver
2023-11-03 21:37 ` Andrey Konovalov
2023-11-06 17:41 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e251a589cb3142607ec5af8fcb904d424702a14.1698077459.git.andreyknvl@google.com \
--to=andrey.konovalov@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).