From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: David Hildenbrand <david@redhat.com>
Cc: Suren Baghdasaryan <surenb@google.com>,
akpm@linux-foundation.org, Liam.Howlett@oracle.com,
vbabka@suse.cz, peterx@redhat.com, jannh@google.com,
hannes@cmpxchg.org, mhocko@kernel.org, paulmck@kernel.org,
shuah@kernel.org, adobriyan@gmail.com, brauner@kernel.org,
josef@toxicpanda.com, yebin10@huawei.com, linux@weissschuh.net,
willy@infradead.org, osalvador@suse.de, andrii@kernel.org,
ryan.roberts@arm.com, christophe.leroy@csgroup.eu,
tjmercier@google.com, kaleshsingh@google.com,
aha310510@gmail.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v7 4/7] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified
Date: Wed, 16 Jul 2025 11:39:58 +0100 [thread overview]
Message-ID: <5e33a9b8-b0d9-4a5d-9b2c-280e3e64a70c@lucifer.local> (raw)
In-Reply-To: <7e0ec5b5-0359-4f79-aa5e-e1273f824057@redhat.com>
On Wed, Jul 16, 2025 at 12:04:25PM +0200, David Hildenbrand wrote:
> On 16.07.25 05:05, Suren Baghdasaryan wrote:
> > Extend /proc/pid/maps tearing test to verify PROCMAP_QUERY ioctl operation
> > correctness while the vma is being concurrently modified.
> >
>
> Wonder if that should be moved out of this series as well. Of course, it
> doesn't hurt to have this test already in.
Yeah that's move this out actually, in this series it's not actually
testing anything _pertinent_.
Though all the tests are designed to pass _before_ as well as after
obviously, so (as David says) no harm to have it here BUT - it's confusing
and a bit weird :P
So yeah let's just move this test over to the respun procmap query series.
BTW Suren - slightly unrelated but - the syzbot report I did the analysis
on is super super reproducable, so if you want to play around with
different solutions, using that should make it some quick iterations.
>
> --
> Cheers,
>
> David / dhildenb
>
Cheers, Lorenzo
next prev parent reply other threads:[~2025-07-16 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 3:05 [PATCH v7 0/7] use per-vma locks for /proc/pid/maps reads Suren Baghdasaryan
2025-07-16 3:05 ` [PATCH v7 1/7] selftests/proc: add /proc/pid/maps tearing from vma split test Suren Baghdasaryan
2025-07-16 10:44 ` David Hildenbrand
2025-07-16 10:50 ` Lorenzo Stoakes
2025-07-16 14:20 ` Suren Baghdasaryan
2025-07-16 16:44 ` Suren Baghdasaryan
2025-07-16 3:05 ` [PATCH v7 2/7] selftests/proc: extend /proc/pid/maps tearing test to include vma resizing Suren Baghdasaryan
2025-07-16 3:05 ` [PATCH v7 3/7] selftests/proc: extend /proc/pid/maps tearing test to include vma remapping Suren Baghdasaryan
2025-07-16 3:05 ` [PATCH v7 4/7] selftests/proc: test PROCMAP_QUERY ioctl while vma is concurrently modified Suren Baghdasaryan
2025-07-16 10:04 ` David Hildenbrand
2025-07-16 10:39 ` Lorenzo Stoakes [this message]
2025-07-16 16:43 ` Suren Baghdasaryan
2025-07-16 3:05 ` [PATCH v7 5/7] selftests/proc: add verbose more for tests to facilitate debugging Suren Baghdasaryan
2025-07-16 3:05 ` [PATCH v7 6/7] fs/proc/task_mmu: remove conversion of seq_file position to unsigned Suren Baghdasaryan
2025-07-16 10:41 ` David Hildenbrand
2025-07-16 3:05 ` [PATCH v7 7/7] fs/proc/task_mmu: read proc/pid/maps under per-vma lock Suren Baghdasaryan
2025-07-16 13:57 ` Vlastimil Babka
2025-07-16 14:29 ` Suren Baghdasaryan
2025-07-16 22:55 ` [PATCH v7 0/7] use per-vma locks for /proc/pid/maps reads Andrew Morton
2025-07-17 1:38 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e33a9b8-b0d9-4a5d-9b2c-280e3e64a70c@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=aha310510@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=brauner@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=josef@toxicpanda.com \
--cc=kaleshsingh@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@weissschuh.net \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=paulmck@kernel.org \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=tjmercier@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).