From: Marc Zyngier <marc.zyngier@arm.com>
To: Abbott Liu <liuwenliang@huawei.com>,
linux@armlinux.org.uk, aryabinin@virtuozzo.com,
kstewart@linuxfoundation.org, gregkh@linuxfoundation.org,
f.fainelli@gmail.com, akpm@linux-foundation.org,
afzal.mohd.ma@gmail.com, alexander.levin@verizon.com
Cc: glider@google.com, dvyukov@google.com,
christoffer.dall@linaro.org, linux@rasmusvillemoes.dk,
mawilcox@microsoft.com, pombredanne@nexb.com,
ard.biesheuvel@linaro.org, vladimir.murzin@arm.com,
nicolas.pitre@linaro.org, tglx@linutronix.de,
thgarnie@google.com, dhowells@redhat.com, keescook@chromium.org,
arnd@arndb.de, geert@linux-m68k.org, tixy@linaro.org,
mark.rutland@arm.com, james.morse@arm.com,
zhichao.huang@linaro.org, jinb.park7@gmail.com,
labbott@redhat.com, philip@cog.systems,
grygorii.strashko@linaro.org, catalin.marinas@arm.com,
opendmb@gmail.com, kirill.shutemov@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
kvmarm@lists.cs.columbia.edu, linux-mm@kvack.org
Subject: Re: [PATCH 3/7] Disable instrumentation for some code
Date: Mon, 19 Mar 2018 08:38:04 +0000 [thread overview]
Message-ID: <5ec51db8-196e-fd3d-8cce-2bdaccc52424@arm.com> (raw)
In-Reply-To: <20180318125342.4278-4-liuwenliang@huawei.com>
On 18/03/18 12:53, Abbott Liu wrote:
> From: Andrey Ryabinin <a.ryabinin@samsung.com>
>
> Disable instrumentation for arch/arm/boot/compressed/*
> and arch/arm/vdso/* because those code won't linkd with
> kernel image.
>
> Disable kasan check in the function unwind_pop_register
> because it doesn't matter that kasan checks failed when
> unwind_pop_register read stack memory of task.
>
> Reviewed-by: Russell King - ARM Linux <linux@armlinux.org.uk>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
> Signed-off-by: Abbott Liu <liuwenliang@huawei.com>
> ---
> arch/arm/boot/compressed/Makefile | 1 +
> arch/arm/kernel/unwind.c | 3 ++-
> arch/arm/vdso/Makefile | 2 ++
> 3 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index 45a6b9b..966103e 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -24,6 +24,7 @@ OBJS += hyp-stub.o
> endif
>
> GCOV_PROFILE := n
> +KASAN_SANITIZE := n
>
> #
> # Architecture dependencies
> diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
> index 0bee233..2e55c7d 100644
> --- a/arch/arm/kernel/unwind.c
> +++ b/arch/arm/kernel/unwind.c
> @@ -249,7 +249,8 @@ static int unwind_pop_register(struct unwind_ctrl_block *ctrl,
> if (*vsp >= (unsigned long *)ctrl->sp_high)
> return -URC_FAILURE;
>
> - ctrl->vrs[reg] = *(*vsp)++;
> + ctrl->vrs[reg] = READ_ONCE_NOCHECK(*(*vsp));
> + (*vsp)++;
> return URC_OK;
> }
>
> diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile
> index bb411821..87abbb7 100644
> --- a/arch/arm/vdso/Makefile
> +++ b/arch/arm/vdso/Makefile
> @@ -30,6 +30,8 @@ CFLAGS_vgettimeofday.o = -O2
> # Disable gcov profiling for VDSO code
> GCOV_PROFILE := n
>
> +KASAN_SANITIZE := n
> +
> # Force dependency
> $(obj)/vdso.o : $(obj)/vdso.so
>
>
You need to extend this at least to arch/arm/kvm/hyp/Makefile, as the
KASAN shadow region won't be mapped in HYP. See commit a6cdf1c08cbfe for
more details (all the arm64 comments in this patch apply to 32bit as well).
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2018-03-19 8:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 12:53 [PATCH v2 0/7] KASan for arm Abbott Liu
2018-03-18 12:53 ` [PATCH 1/7] 2 1-byte checks more safer for memory_is_poisoned_16 Abbott Liu
2018-03-18 13:21 ` Russell King - ARM Linux
2018-03-18 12:53 ` [PATCH 2/7] Add TTBR operator for kasan_init Abbott Liu
2018-03-18 12:53 ` [PATCH 3/7] Disable instrumentation for some code Abbott Liu
2018-03-19 8:38 ` Marc Zyngier [this message]
2018-03-18 12:53 ` [PATCH 4/7] Replace memory function for kasan Abbott Liu
2018-03-18 12:53 ` [PATCH 5/7] Define the virtual space of KASan's shadow region Abbott Liu
2018-03-18 12:53 ` [PATCH 6/7] Initialize the mapping of KASan shadow memory Abbott Liu
2018-03-18 12:53 ` [PATCH 7/7] Enable KASan for arm Abbott Liu
2018-03-19 20:43 ` kbuild test robot
2018-03-18 19:13 ` [PATCH v2 0/7] " Florian Fainelli
2018-03-19 18:29 ` Florian Fainelli
2018-03-25 23:58 ` Joel Stanley
-- strict thread matches above, loose matches on Subject: below --
2018-03-24 11:39 [PATCH 3/7] Disable instrumentation for some code Liuwenliang (Abbott Liu)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec51db8-196e-fd3d-8cce-2bdaccc52424@arm.com \
--to=marc.zyngier@arm.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.levin@verizon.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=dhowells@redhat.com \
--cc=dvyukov@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@linaro.org \
--cc=james.morse@arm.com \
--cc=jinb.park7@gmail.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=liuwenliang@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mawilcox@microsoft.com \
--cc=nicolas.pitre@linaro.org \
--cc=opendmb@gmail.com \
--cc=philip@cog.systems \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=thgarnie@google.com \
--cc=tixy@linaro.org \
--cc=vladimir.murzin@arm.com \
--cc=zhichao.huang@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).