linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: zhlcindy <zhlcindy@imap.linux.ibm.com>
To: Li Zhang <zhlcindy@gmail.com>
Cc: mgorman@techsingularity.net, vbabka@suse.cz,
	akpm@linux-foundation.org, khandual@linux.vnet.ibm.com,
	aneesh.kumar@linux.vnet.ibm.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org,
	Li Zhang <zhlcindy@linux.vnet.ibm.com>
Subject: Re: [PATCH 1/1] mm/page_alloc: Remove useless parameter of __free_pages_boot_core
Date: Thu, 24 Mar 2016 12:00:52 +0800	[thread overview]
Message-ID: <5ed84fae352de403ca23306666cb25bb@imap.linux.ibm.com> (raw)
In-Reply-To: <1458791480-20324-1-git-send-email-zhlcindy@gmail.com>

Sorry, a mail address in TO list is wrong. Correct it.

On 2016-03-24 11:51, Li Zhang wrote:
> From: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> 
> __free_pages_boot_core has parameter pfn which is not used at all.
> So this patch is to make it clean.
> 
> Signed-off-by: Li Zhang <zhlcindy@linux.vnet.ibm.com>
> ---
>  mm/page_alloc.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index a762be5..8c0affe 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1056,8 +1056,7 @@ static void __free_pages_ok(struct page *page,
> unsigned int order)
>  	local_irq_restore(flags);
>  }
> 
> -static void __init __free_pages_boot_core(struct page *page,
> -					unsigned long pfn, unsigned int order)
> +static void __init __free_pages_boot_core(struct page *page, unsigned
> int order)
>  {
>  	unsigned int nr_pages = 1 << order;
>  	struct page *p = page;
> @@ -1134,7 +1133,7 @@ void __init __free_pages_bootmem(struct page
> *page, unsigned long pfn,
>  {
>  	if (early_page_uninitialised(pfn))
>  		return;
> -	return __free_pages_boot_core(page, pfn, order);
> +	return __free_pages_boot_core(page, order);
>  }
> 
>  /*
> @@ -1219,12 +1218,12 @@ static void __init deferred_free_range(struct
> page *page,
>  	if (nr_pages == MAX_ORDER_NR_PAGES &&
>  	    (pfn & (MAX_ORDER_NR_PAGES-1)) == 0) {
>  		set_pageblock_migratetype(page, MIGRATE_MOVABLE);
> -		__free_pages_boot_core(page, pfn, MAX_ORDER-1);
> +		__free_pages_boot_core(page, MAX_ORDER-1);
>  		return;
>  	}
> 
> -	for (i = 0; i < nr_pages; i++, page++, pfn++)
> -		__free_pages_boot_core(page, pfn, 0);
> +	for (i = 0; i < nr_pages; i++, page++)
> +		__free_pages_boot_core(page, 0);
>  }
> 
>  /* Completion tracking for deferred_init_memmap() threads */

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2016-03-24  4:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24  3:51 [PATCH 1/1] mm/page_alloc: Remove useless parameter of __free_pages_boot_core Li Zhang
2016-03-24  4:00 ` zhlcindy [this message]
2016-03-29  6:18 ` Pan Xinhui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed84fae352de403ca23306666cb25bb@imap.linux.ibm.com \
    --to=zhlcindy@imap.linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    --cc=zhlcindy@gmail.com \
    --cc=zhlcindy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).