From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DCA4C433EF for ; Tue, 14 Jun 2022 13:07:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 719EB6B0072; Tue, 14 Jun 2022 09:07:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C9816B0074; Tue, 14 Jun 2022 09:07:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B8486B0075; Tue, 14 Jun 2022 09:07:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4BECD6B0072 for ; Tue, 14 Jun 2022 09:07:46 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 200BA34144 for ; Tue, 14 Jun 2022 13:07:46 +0000 (UTC) X-FDA: 79576868532.18.E49CB1A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id A3D2B40094 for ; Tue, 14 Jun 2022 13:07:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 709AF6157F; Tue, 14 Jun 2022 13:07:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C7C9C3411B; Tue, 14 Jun 2022 13:07:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655212063; bh=o1i62i9cvcd6zXd6+ZKu0naAcMPa5eKgxWy6B4lu02k=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z6k5BnOssL4pis2anV8YUt2r+AigMLzMiGGeo8b0AO4vBL++oEct0NLuPZ+1a2iMQ BBGEW0gyIhOOL0uOIZpP/uVB3H5Y1mUc7eyJ8IM/m595KBHkXljkhh6wVfmyXxJI2g B3HzNNV/zhDSGx64Qvb9tueKXZjTRpmtPekoPuVPZAsqI7RZqPin6vUfIzxXWXiXIa Q2n3EHCpVlHUG53+vmZ/e2Nor4OQYyUAu5kgQSRmxetAN7hkF69bONJdq8YmBAbG5b 6x4EUcWgCE0OQz1dYfjBy+JnCCSW14dMHcL8WLon0U+SMpBvZxbgCjNgTOB07k38Wj Fbtx97cgz9LNw== Message-ID: <5f295a8f-058a-97d1-d9e0-095fdb5e5a7c@kernel.org> Date: Tue, 14 Jun 2022 15:07:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/3] mm/page_alloc: use might_alloc() Content-Language: en-US To: Daniel Vetter , LKML Cc: DRI Development , Daniel Vetter , Andrew Morton , linux-mm@kvack.org References: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20220605152539.3196045-1-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655212065; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sFD8Rfb65+0/nF8ZipbNUlDUgcSGE+hFmI1B1cHE43M=; b=fMVBLSsns9qwh5vlgrIrKkMY2hmhqPmGtfm8qdHLgClilSTAfvM21xpr8R6dBPCtht5I8K G2vnBtPPGHD8FjA4gyJ89Vm5KYObfVDbqcVlNvdz5rdpkcza2n60cF1mnnd7NDnoB6DFwc PeBqmjUvuO32kI7wnKg7EyLqokNyqyA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6k5BnOs; spf=pass (imf11.hostedemail.com: domain of vbabka@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=vbabka@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655212065; a=rsa-sha256; cv=none; b=fFHtAkMbP2yWET7oUQub1eFLswN/446Mtpnyryz9kyzWzcfTFZq/Ctk5TEHaCzLEbU0ivo I5SNn3t6vJzeAloDU5w2WcR7Fg6faw3Qg7+hOE2Bja+nL0FvxApyKQwKbumIEOzlDfFPkw 3VTSN+kiuChh8UQ2JyBwc+RQVk78UO4= X-Stat-Signature: wm4z7pqytti1rpwyqs5hswjx5ryi6dyu X-Rspamd-Queue-Id: A3D2B40094 X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z6k5BnOs; spf=pass (imf11.hostedemail.com: domain of vbabka@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=vbabka@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1655212065-813560 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/5/22 17:25, Daniel Vetter wrote: > ... instead of open codding it. Completely equivalent code, just > a notch more meaningful when reading. > > Signed-off-by: Daniel Vetter > Cc: Andrew Morton > Cc: linux-mm@kvack.org Reviewed-by: Vlastimil Babka > --- > mm/page_alloc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 2db95780e003..277774d170cb 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5177,10 +5177,7 @@ static inline bool prepare_alloc_pages(gfp_t gfp_mask, unsigned int order, > *alloc_flags |= ALLOC_CPUSET; > } > > - fs_reclaim_acquire(gfp_mask); > - fs_reclaim_release(gfp_mask); > - > - might_sleep_if(gfp_mask & __GFP_DIRECT_RECLAIM); > + might_alloc(gfp_mask); > > if (should_fail_alloc_page(gfp_mask, order)) > return false;