From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: David Hildenbrand <david@redhat.com>,
Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com,
npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com,
ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio
Date: Thu, 8 May 2025 10:08:08 +0800 [thread overview]
Message-ID: <5ffc814f-72e9-4173-9a77-5b45f941565c@linux.alibaba.com> (raw)
In-Reply-To: <70785e68-5152-459f-b241-fa5abc3b88ae@redhat.com>
On 2025/5/8 05:19, David Hildenbrand wrote:
> On 07.05.25 14:04, Matthew Wilcox wrote:
>> On Wed, May 07, 2025 at 05:26:12PM +0800, Baolin Wang wrote:
>>> @@ -1476,13 +1476,13 @@ static int set_huge_pmd(struct vm_area_struct
>>> *vma, unsigned long addr,
>>> .pmd = pmdp,
>>> };
>>> - VM_BUG_ON(!PageTransHuge(hpage));
>>> + VM_BUG_ON(!folio_test_large(folio));
>>
>> I don't think this is aterribly useful assertion to keep in a static
>> function with one caller, do you?
Yes. Will remove this VM_BUG_ON.
> I'll not that -- whatever we do here -- we can (finally) get rid of
> PageTransHuge.
Right. I will remove the PageTransHuge in the next version.
prev parent reply other threads:[~2025-05-08 2:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 9:26 [PATCH 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio Baolin Wang
2025-05-07 9:26 ` [PATCH 2/2] mm: convert do_set_pmd() " Baolin Wang
2025-05-07 12:10 ` Matthew Wilcox
2025-05-07 12:36 ` Baolin Wang
2025-05-07 16:47 ` Matthew Wilcox
2025-05-08 2:23 ` Baolin Wang
2025-05-08 7:37 ` David Hildenbrand
2025-05-07 21:24 ` David Hildenbrand
2025-05-07 23:46 ` Zi Yan
2025-05-08 7:36 ` David Hildenbrand
2025-05-08 13:12 ` Matthew Wilcox
2025-05-07 12:04 ` [PATCH 1/2] mm: khugepaged: convert set_huge_pmd() " Matthew Wilcox
2025-05-07 21:19 ` David Hildenbrand
2025-05-08 2:08 ` Baolin Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ffc814f-72e9-4173-9a77-5b45f941565c@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=dev.jain@arm.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox