From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D7FFC05027 for ; Fri, 20 Jan 2023 11:02:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5361F6B0072; Fri, 20 Jan 2023 06:02:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E5966B0073; Fri, 20 Jan 2023 06:02:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D36A6B0074; Fri, 20 Jan 2023 06:02:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2F1E06B0072 for ; Fri, 20 Jan 2023 06:02:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E7CBDA0E41 for ; Fri, 20 Jan 2023 11:02:38 +0000 (UTC) X-FDA: 80374889196.03.8ADFA38 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by imf09.hostedemail.com (Postfix) with ESMTP id 14074140028 for ; Fri, 20 Jan 2023 11:02:35 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Eh2gJVEn; spf=pass (imf09.hostedemail.com: domain of angelogioacchino.delregno@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=angelogioacchino.delregno@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674212556; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b6D0DKn1UcI6xBH+0I5tpLA60iC9vYxQBrCAmS4Lfps=; b=XTP87x6Un1Nyh09e5SEs6+PtHTqZ4bAe3+sNFpHciTRnEpIPYcVVsDt3BkZ11WnQKeUi/d H3DXCDiiSY3kEY7qcXsj1CXM3bYjRMIoIghjT3k4sArpxvbailh1z2ZfUA5hnW6UKyYBH3 51TTgB93kYnLS0U9lRmNRkbILqN4rIA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=Eh2gJVEn; spf=pass (imf09.hostedemail.com: domain of angelogioacchino.delregno@collabora.com designates 46.235.227.172 as permitted sender) smtp.mailfrom=angelogioacchino.delregno@collabora.com; dmarc=pass (policy=none) header.from=collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674212556; a=rsa-sha256; cv=none; b=I1yVX4dx3i44EBHbRh6IubtTCpjfT42JYmvNVkf5Bxi/04IGRevuTUmULDVyI5R/jmIP2l vAx0DwmhVK2ulytAJ+AmiWIVaeUCu6+Pw9TmCMGIagL+wRY8jCGkVwkd9k0C8oUsnhBhj4 +yXdLqvZU97Btdf8eWzDjmS+ieUisu4= Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id E4FB6660230B; Fri, 20 Jan 2023 11:02:33 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1674212554; bh=D1HAtBqHAur8JaHevw9CchxdQMYmjJCpCGW+M/tjShU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Eh2gJVEnl9CTANbedBJfnefEqIiZbcki65abJSvaucO6ovmqitxOj07kJ1zSr+pJa lhIl4WinFUTlp9Wh+weNn7awtx+OCkK7rmwb/o4Suo47ezhavBWi2m6BBMNp2KZGj0 JmsbLQkNmCoWz0051NeYFCJy8DaEgy1O6JhERv/xKIHCPnMsUkp+VlDTnjak+kLOi+ o59D2ddNwTodviyO05AAFrD8+CDS7lRR6T66Jj4I26suiAn2bJQP0OSUM1f8YowvPh QSbTfDwjfGl+uIUl9aLywgdAEMSK1XmSp8GL6d7XFDLsGg66UVzjh/h1DgfGhXcI8o JniLx1Wz6bL+A== Message-ID: <5ffed624-81e0-ab8c-bf68-84fc700239cc@collabora.com> Date: Fri, 20 Jan 2023 12:02:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] ASoC: SOF: sof-audio: prepare_widgets: Check swidget for NULL on sink failure Content-Language: en-US To: Peter Ujfalusi , lgirdwood@gmail.com, broonie@kernel.org Cc: alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com, error27@gmail.com, linux-mm@kvack.org, oe-kbuild-all@lists.linux.dev References: <20230120102125.30653-1-peter.ujfalusi@linux.intel.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230120102125.30653-1-peter.ujfalusi@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 14074140028 X-Rspam-User: X-Stat-Signature: rqqcn5mi5g413659d7n7kq9xyw3gbdrc X-HE-Tag: 1674212555-302248 X-HE-Meta: U2FsdGVkX1+vqTA/KGWy/Txc6l9+ohLX7RmCFiM0u+I6FvsGjoYIr4U6R++VjkMxLlWTCYkAtRkNY4+fzt+gsJ6sdfMVMQYULXIdB021+r6z/TqxGI7z36kMcLDnW+2TFfCAmtLY4a8yAd7nr7oLTN5+2sDjdrKxEUn9eofOikutbXYX+gH1Zz4Q0NYKPEgGMlcvPVPTXlk5TpcJuDTOENQ8hCcWqxDp5aaHycJeiua+WiHheRWphoPpY418Zlg5SrqzwJB+tqcFOHe2W4a5eMtuSLhWpGVA2PixhUBovnEgzzmg0daLMZCTdBuiC80wz+f98UYF/Q/wxtdq7/Aw8Zr7RTuGARo4vHFFJDLZ3FKBjhm15cnabhOGAaOGgGuSmLyitlgK2Mq1ZrCfhLaDNylml3veMDydERRVaKasty8QzPEDqQYb4Pd+PqoDo7WV0XNFv1YoRdWxBjEhCoYOcioPgI0BCaSPLlJO28V6WKo0YJ1mLm+Kv4dFH/Xfx6nElxrWI6K/STOjJs9OAToheQQaom4Gf+UApeiossiSbUmICh/d0HCoegvvsyqqDYEPNGzODgyRGd5ljEZvb+zlS6kLxTsJYXl6v0Vr8wYsgVcRHKH5p9swq6W48DkT6LOaj9RjROG2LLl/n/5b6qFwC8AjhNWRgpNQIyZ1WxdnDDZ3YLzOpZFK5sNj9o3SbBlnQk7OsNuJ3rAkcQfft64mYY8beQTQyZzY3Gak7ROdPLSPZY67m07EaWUUg3VK+hyBBQ8Ihy9FodxTqRwbenuiIpPyX/nQaFi75L69K7dglBSWo1CK0ez4DonxgYNT28G95ILi/esBXL2q7iwQOvUWUIl2vo4MdSs7VZdzw7mpBeIFHPBvN7QF+XXkA8zQ/q5IS5cAFOloeKIALFBfAuuOhm0RgJIvSsQV0kL4uyykTLRXT7XEoj1yJDkD395Mi91lPwyyj2ofwNUHhjLdgx+ 0CjPBGhF 1eh/or9YXaanAudjiUf6AKAgm5RlunGDadd2Y8a1SftkoApHDtCmNhQfTBTq5GzpyKxkkYAY+yBaEiFA2jBoxZZJsPj71pXl8fFnA1g4WMiHk8U5kisC5zKFqfnMlcRt5aHWh6y+kMSYOO11dsQ6oA9ikhlx/SJDUIZOqnwr9bsRzHUemA05RziTY7l/f0dhgCT7Uy9vzOI/2HA9swYS3td6d8RFfE6wJpjAuh1sIhXNbhnrR1uCSDunUUTQBTgtjz89LFVF9BpU47BUnZKQycwQCqi8QBwbAe2El4mebxWPDe6iDU6XDOxrdbzIkc5M0hgPxv+eBcwbD4npo/+Pa7InyzIWa+Ts7pbLbBlgNEbxniMQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Il 20/01/23 11:21, Peter Ujfalusi ha scritto: > If the swidget is NULL we skip the preparing of the widget and jump to > handle the sink path of the widget. > If the prepare fails in this case we would undo the prepare but the swidget > is NULL (we skipped the prepare for the widget). > > To avoid NULL pointer dereference in this case we must check swidget > against NULL pointer once again. > > > Fixes: 0ad84b11f2f8 ("ASoC: SOF: sof-audio: skip prepare/unprepare if swidget is NULL") > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Peter Ujfalusi Reviewed-by: AngeloGioacchino Del Regno