Re: [PATCH 1/3] mm/rmap: not necessary to mask off FOLIO_PAGES_MAPPED

[David Hildenbrand <david@redhat.com>]

On 15.08.25 10:49, Wei Yang wrote:
> At this point, we are sure (nr < ENTIRELY_MAPPED). This means the upper
> bits are already cleared.
> 
> Not necessary to mask off it.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Cc: Rik van Riel <riel@surriel.com>
> Cc: Liam R. Howlett <Liam.Howlett@oracle.com>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Harry Yoo <harry.yoo@oracle.com>
> ---
>   mm/rmap.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 1c5988dbd1e7..a927437a56c2 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1749,7 +1749,7 @@ static __always_inline void __folio_remove_rmap(struct folio *folio,
>   				nr_pages = folio_large_nr_pages(folio);
>   				if (level == PGTABLE_LEVEL_PMD)
>   					nr_pmdmapped = nr_pages;
> -				nr = nr_pages - (nr & FOLIO_PAGES_MAPPED);
> +				nr = nr_pages - nr;
>   				/* Raced ahead of another remove and an add? */
>   				if (unlikely(nr < 0))
>   					nr = 0;

Acked-by: David Hildenbrand <david@redhat.com>

-- 
Cheers

David / dhildenb