From: Ying Han <yinghan@google.com>
To: linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Mike Waychison <mikew@google.com>,
Rohit Seth <rohitseth@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-api@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH]Fix: 32bit binary has 64bit address of stack vma
Date: Fri, 9 Jan 2009 16:27:07 -0800 [thread overview]
Message-ID: <604427e00901091627n7c909abt6aa1f01c181ad65d@mail.gmail.com> (raw)
In-Reply-To: <604427e00901081840pa6dcc41u9a7a5c69302c7b60@mail.gmail.com>
friendly ping...
On Thu, Jan 8, 2009 at 6:40 PM, Ying Han <yinghan@google.com> wrote:
> On Mon, Jan 5, 2009 at 3:39 PM, Ying Han <yinghan@google.com> wrote:
>> From: Ying Han <yinghan@google.com>
>>
>> Fix 32bit binary get 64bit stack vma offset.
>>
>> 32bit binary running on 64bit system, the /proc/pid/maps shows for the
>> vma represents stack get a 64bit adress:
>> ff96c000-ff981000 rwxp 7ffffffea000 00:00 0 [stack]
>>
>> Signed-off-by: Ying Han <yinghan@google.com>
>>
>> fs/exec.c | 5 +-
>>
>> diff --git a/fs/exec.c b/fs/exec.c
>> index 4e834f1..8c3eff4 100644
>> --- a/fs/exec.c
>> +++ b/fs/exec.c
>> @@ -517,6 +517,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>> unsigned long length = old_end - old_start;
>> unsigned long new_start = old_start - shift;
>> unsigned long new_end = old_end - shift;
>> + unsigned long new_pgoff = new_start >> PAGE_SHIFT;
>> struct mmu_gather *tlb;
>>
>> BUG_ON(new_start > new_end);
>> @@ -531,7 +532,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>> /*
>> * cover the whole range: [new_start, old_end)
>> */
>> - vma_adjust(vma, new_start, old_end, vma->vm_pgoff, NULL);
>> + vma_adjust(vma, new_start, old_end, new_pgoff, NULL);
>>
>> /*
>> * move the page tables downwards, on failure we rely on
>> @@ -564,7 +565,7 @@ static int shift_arg_pages(struct vm_area_struct *vma, uns
>> /*
>> * shrink the vma to just the new range.
>> */
>> - vma_adjust(vma, new_start, new_end, vma->vm_pgoff, NULL);
>> + vma_adjust(vma, new_start, new_end, new_pgoff, NULL);
>>
>> return 0;
>> }
>>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-01-10 0:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 23:39 [PATCH]Fix: 32bit binary has 64bit address of stack vma Ying Han
2009-01-09 2:40 ` Ying Han
2009-01-10 0:27 ` Ying Han [this message]
2009-01-10 0:37 ` Andrew Morton
2009-01-10 1:32 ` Ying Han
2009-01-12 22:59 ` Andrew Morton
2009-01-12 23:05 ` Mike Waychison
2009-01-12 23:10 ` Andrew Morton
2009-01-13 17:59 ` Hugh Dickins
2009-01-12 23:06 ` Ying Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604427e00901091627n7c909abt6aa1f01c181ad65d@mail.gmail.com \
--to=yinghan@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mikew@google.com \
--cc=oleg@redhat.com \
--cc=rohitseth@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).