From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463EAC83F03 for ; Wed, 9 Jul 2025 16:56:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B93986B013E; Wed, 9 Jul 2025 12:56:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B69FB6B013F; Wed, 9 Jul 2025 12:56:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A59066B0140; Wed, 9 Jul 2025 12:56:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9657E6B013E for ; Wed, 9 Jul 2025 12:56:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4BD18B8063 for ; Wed, 9 Jul 2025 16:56:42 +0000 (UTC) X-FDA: 83645330244.23.E854B41 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf05.hostedemail.com (Postfix) with ESMTP id EFB31100012 for ; Wed, 9 Jul 2025 16:56:39 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hqialxNZ; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752080200; a=rsa-sha256; cv=none; b=DtzRa9z0vls0pmGLT1u5MSQCkH/VSR2ckrXjTG+wQ7GkB1t+kdlHCyb9UNx2z90knITFUH 4Wqu3X4vIHA8jE1ObbJjwueYL7KND5Hk2UlBQhenI83uru8rvNtXETRo+1af223oE4aBGh sDm4ph4OZTnHiTJHGPxssTci3g+DA7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752080200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/DUdKK8+d6c8HTFV5/NHhbc7PTN0fPnwoX8s8UnNKwo=; b=vVsm3Er96ymeLf3d/EpuuNjHBKuTcdNVrOk0R+MDm5grw323iLiqG5xudjA9keStZcUXpI ufhMu0AqzJw4zbAl0gWN+U8mzaN7YL3wKFM7boK5SATML1fwJ3EGDccTVTL/AYXofhR+9k OZfnQKqlIFd9i250a0kMJb9DPuGgw6M= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hqialxNZ; spf=pass (imf05.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.16 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752080200; x=1783616200; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/DUdKK8+d6c8HTFV5/NHhbc7PTN0fPnwoX8s8UnNKwo=; b=hqialxNZE0Vhp4/ehEQZwJqPwTwBbt0NHOWQ5TAwOYlYCHFKzlu1I5ZM E0gjNERRqa3BF1OGaaqWi5l/ojiQ7aB0LCrcGVI+l+N2De0PW8poCpR3h YyflqBzpnB89amhFJgdvvoT5c2L6307zadOJiBdwivBPA6TZEOwWmCFHA Istmv0WW7TiM6YVtyIFcdeIycNpwFdlZMHk0GB+SlZtRdTB5UoV/R/pjF tdOhvLXoumb4U2vOdkDwvI6Vc0m+HA+p7EkmhAXA/njJYCNC9+elU35Hm L2om99P/CN+3PrBAx8ISTnZ3uazj+lGQN4pVj2KiE4HB1U6kxWWTVtP3U w==; X-CSE-ConnectionGUID: KjFzwR8nTR2+lZoHWD5r7g== X-CSE-MsgGUID: lyJO8RuVSf2kjytskp3H7w== X-IronPort-AV: E=McAfee;i="6800,10657,11489"; a="54481097" X-IronPort-AV: E=Sophos;i="6.16,298,1744095600"; d="scan'208";a="54481097" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2025 09:56:39 -0700 X-CSE-ConnectionGUID: 1lI6A9ftR+yq9Y6vgi4laQ== X-CSE-MsgGUID: BLxPmPvARtufgCHzjffeYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,298,1744095600"; d="scan'208";a="161485847" Received: from puneetse-mobl.amr.corp.intel.com (HELO [10.125.110.190]) ([10.125.110.190]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2025 09:56:38 -0700 Message-ID: <6075af69-299f-43d2-a3c8-353a2a3b7ee7@intel.com> Date: Wed, 9 Jul 2025 10:00:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv9 04/16] x86/cpu: Defer CR pinning setup until core initcall To: "Kirill A. Shutemov" , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin Cc: Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org References: <20250707080317.3791624-1-kirill.shutemov@linux.intel.com> <20250707080317.3791624-5-kirill.shutemov@linux.intel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250707080317.3791624-5-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: EFB31100012 X-Stat-Signature: 9bm1qsdekzgbuu1aibnoprscufa497tj X-HE-Tag: 1752080199-148999 X-HE-Meta: U2FsdGVkX18s/MVemgsCDFYeylVa9ZuTfIDOMRbsLvKHqnNbdU7qpUNiPthDH2nw2Pe8fHv42PVq1xrxrepZrDAbDmycQYoWA+JuIz9p6wGv9V4GoUp8cXQRKKLn4/Po8RX7+W8959pDtbvEFmixhG9u5Z9nRLyhNc8Dw3hKZziP3LjoLSe8+oP2EynXJlyMGo78bZzndCgKf2lO4aFoe60AwjD8IsbqmgK+75jaERStNvsLsSapVP3i3FJ7729toEDK2EcqC4wOkdZyec9ckrY5hW+m/fvhNqybU1VJbVwu90UfqfFgFAKcGsOKTZdebUiuyK/9Febnj1h5nH71sxd/CAymwSPlIDU6c7J1uLklapLz8CGicTQGhch3h+gN6meUC5FMDZWICEunZ5MYO31fvyUuHOuqDjjsbHiQ9TiRs6Gpu/CwgQBRh7tT2Vm3b9uazIHmBWKFPsobQWBE4eQ6LmpKYH/OobqF0pGAcV0GnuG+hs/oqkPGC2bDJ4Fxqjlmjc62sliK90mUrY5CaeBkJQrU1RRNDtFdgRKBIKHFG4Veonjd2Po1Cg9jg9KPUguBnx7SCc9Ju56kJ1qAkGiRdvQ7ZwteD2idh0j4L+WKsvQ5zthhsJvoARZw96ingNUk5+uzRxr2lmRev0NB8iCC0dSYgVeN3Zk0Ez1qw19fpNSDrQvoz2+d5JsbMnhlpdUquK3bx6zWfQjawlDgk434QEK443oU29ydzauBIKnAifB/eUYvWIKQiaGW0n6oDWuOS5HjrpiCeiEuMnqo9U++qM6kR4Ignb1BAeLcEoNzTgatN56zOQpgv97vyXBmXPcBgutNN4Y6bh9Q8on0qmj6nALDX8l5mk4Ckf5gI9vicU/T+rzp2lNHWRscNDS93/VoqhwBQHdWCP8lFaFnbJ0+HaHMwgucmr2x0AdykVFjDDqMUkFyadQEvuO3svQL2iW3kP7hyoJYpRfQQZD 11yOykrM 6BnJ7DtKpoFHrIuVFrOJbaRQ2qFARXvTQjDvjxR+KW8Zj7bP4rFr4kOTz6V5c3gegVszuJoHMfJ/kR57/QFsh1krRpt2f92JQ7TOCR7tSCjDRBVoF1icnsvzsWXZAZmorIHn/l60VVakhowePfPP2CMWa3V11Dhgvc+MNhE4YUyaO0u1qLHnqim7f47WOCIqxtyatnS4T5v18gGGkPNzcR1psrDSNT7fMMdf+uqvqjauz2yXbuSJRQngjRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/7/25 01:03, Kirill A. Shutemov wrote: > Instead of moving setup_cr_pinning() below efi_enter_virtual_mode() in > arch_cpu_finalize_init(), defer it until core initcall. What are the side effects of this move? Are there other benefits? What are the risks? BTW, ideally, you'd get an ack from one of the folks who put the CR pinning in the kernel in the first place to make sure this isn't breaking the mechanism in any important ways.