From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08732C3DA4A for ; Thu, 1 Aug 2024 13:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86DC28D0002; Thu, 1 Aug 2024 09:38:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F72E6B00D4; Thu, 1 Aug 2024 09:38:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BEED8D0002; Thu, 1 Aug 2024 09:38:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4CB996B00D2 for ; Thu, 1 Aug 2024 09:38:48 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EF7C1C0DD5 for ; Thu, 1 Aug 2024 13:38:47 +0000 (UTC) X-FDA: 82403781894.08.BE7AF8B Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf15.hostedemail.com (Postfix) with ESMTP id B2980A0037 for ; Thu, 1 Aug 2024 13:38:40 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of yangerkun@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yangerkun@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722519481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YlkCBqgHPiL4o/MmNQBonL9Gc+IG2S/zISmQ8Brt+fo=; b=miISzI3PIo1lwm2OD9f3ZuradBi8NUIh9WG2RRShtDf8lzU0lHYULf02P7MDkyvJhLo1Ii JTL4t/IZO+MdVhHiTlxHNeUlOr2C1yrGl98a5wI1dtib8PYW0ikoGR16SohtTy6m/mhGSv bVivKqYbeHkQqNz11hHKXRXcp3wdYy8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of yangerkun@huaweicloud.com designates 45.249.212.51 as permitted sender) smtp.mailfrom=yangerkun@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722519481; a=rsa-sha256; cv=none; b=nlURsnMhF3HNkzeLBk1jvobHp8wZBP0aG/NBsOBdj1bX8AP0x0VHy+c/nvYbdl1+qhH2Uv m+OE5rvNg4J7kUmDyF/RP0q69/oE2zGEDjtwi6WV6H49L/gzqAAkryNCFSdyJ0UK0PmLfE X98imsyUpii+uhPXRLc858ei6sfA/po= Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4WZVR34wY7z4f3kKy for ; Thu, 1 Aug 2024 21:38:23 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id 6A73C1A06D7 for ; Thu, 1 Aug 2024 21:38:32 +0800 (CST) Received: from [10.174.177.210] (unknown [10.174.177.210]) by APP4 (Coremail) with SMTP id gCh0CgBnj4XWj6tmDlTkAQ--.34883S3; Thu, 01 Aug 2024 21:38:32 +0800 (CST) Message-ID: <608c3be9-4a44-21dc-fcea-199900d65200@huaweicloud.com> Date: Thu, 1 Aug 2024 21:38:30 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] libfs: fix infinite directory reads for offset dir To: Jan Kara Cc: Christian Brauner , chuck.lever@oracle.com, yangerkun , hughd@google.com, zlang@kernel.org, fdmanana@suse.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, hch@infradead.org, viro@zeniv.linux.org.uk References: <20240731043835.1828697-1-yangerkun@huawei.com> <20240731-pfeifen-gingen-4f8635e6ffcb@brauner> <9107aa4d-c888-3a73-0a07-a9d49f5ec558@huaweicloud.com> <20240801133007.jf6m223mszye66e5@quack3> From: yangerkun In-Reply-To: <20240801133007.jf6m223mszye66e5@quack3> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBnj4XWj6tmDlTkAQ--.34883S3 X-Coremail-Antispam: 1UD129KBjvdXoW7Jw1ruF4kuFy8tF1DWF1rJFb_yoWDXwcEg3 yrC34kCw1UXF1xKan0va13XrZ0kaykKF98tw4Utw4ku34fZFZ8ur4DGrna9rsYgFZ7KFna k34qva45tr1fWjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbaxYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwV A0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0cI8IcVCY1x02 67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I 0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40E x7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x 0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7I2V7IY0VAS 07AlzVAYIcxG8wCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4 IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1r MI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJV WUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j 6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYx BIdaVFxhVjvjDU0xZFpf9x07UAwIDUUUUU= X-CM-SenderInfo: 51dqwvhunx0q5kxd4v5lfo033gof0z/ X-Stat-Signature: ruybyti3c7tc8taajpjr6h9u5omup9pj X-Rspam-User: X-Rspamd-Queue-Id: B2980A0037 X-Rspamd-Server: rspam02 X-HE-Tag: 1722519520-69880 X-HE-Meta: U2FsdGVkX1/tLOUyZ4KqZXICYcvwNw/RcujJP6iCSE9VZUrgSSxf8Ny9tEw6kwU83bzTP2mFP/QxSY3Bp3rYQDdxtRhabWJIBm7orjTjZOEnIXbFWk0ZS9k6ILLLmAG8YxgfvAeuKCYstA3yA7hn/DcNHlYoDXTn8IYLKA0+lz2n3wN3Mqi+TwQrXiSS7zovHFsI9mf9m66CppzKBsz+0cYSlYCrw/josd9x8sK5HDo6q9tJOZlbrml1Q8GAHFLes2ycTKVQiEkv2OULsjda8Wl4UysUwD68lugNLGJSCIJPqT8sHpnHbWhWlu4/ry0wobj5t1KELtkdj4UkgPQE9xJJos16+H1ffGyAgSY/JVSRjmub05U8YX2mrfm46aWgswnt49COAtpfipQq1h+LZWw4HLubjI0ZGJosVwlp6t8Fp9RSBI5tg1bPzabKdYYOM5RKG2U64+Fyia8WGoaw9pbZNFpdINFsIquIPAEx9Ueo7UPztE7n5hh+WEgdnW8KFXyhKK5Cvvk5/K+nw7hXv4FW7FYddpuaoxbJ2FCMQSDdB3oBH8RczW57GCIuuEmcH5um540mW/LmAbcOh4b2c7aANvE/9ozv7y61uqZqhCMv3WbzkumQKcZml1wStvsw6WnOERuA3l6jNH140lcoWlYfsnUCAFHATVHAiQuxTWUaxVEeZIUUK3lZ1/G2oqvrDzH44OAEDUb0H5/0I9Ojr1mNlJpOhbBU4AROKo1DZbazxvCdS65qGdQA22nUtRjVwkFPSTsJuec+2YvWZd/l42kJ9bTem3o6Fi3IoHtSXC6zP08y9Padk46l4SWjBnQlI9xgjU0aV8KnyJBK7QMzpv3EpLYdYOwbeHuPlt4IxOejMgDhYGkVKhxJyvjj+cU7yR5ZQ2p9O1co5ctGiShOTFHFAwD6zfdw51w65MonSdPsAO67PnmCwVE778nu+xphPuwUfguwELyd6Q7Pnrz JnwXeVkw hjRs6J/oVxAemp3r+YIc/jhgyFrOFHTrSwt8sYDx8Fun7zuzeTEF8QtRVfmyfCGzTEsSXGVPRTjBI8x2ZeQ83gDcXQuyOAx52HQsEe3Sbp+w/YUxvZZQHM9HFLwSJi2wgQmnfBKfjqcVCM07nlaVDpTVlqg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000393, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/8/1 21:30, Jan Kara 写道: > On Thu 01-08-24 11:32:25, yangerkun wrote: >> Hi! >> >> 在 2024/7/31 22:16, Christian Brauner 写道: >>> On Wed, 31 Jul 2024 12:38:35 +0800, yangerkun wrote: >>>> After we switch tmpfs dir operations from simple_dir_operations to >>>> simple_offset_dir_operations, every rename happened will fill new dentry >>>> to dest dir's maple tree(&SHMEM_I(inode)->dir_offsets->mt) with a free >>>> key starting with octx->newx_offset, and then set newx_offset equals to >>>> free key + 1. This will lead to infinite readdir combine with rename >>>> happened at the same time, which fail generic/736 in xfstests(detail show >>>> as below). >>>> >>>> [...] >>> >>> @Chuck, @Jan I did the requested change directly. Please check! >> >> Thanks for applied this patch, the suggestions from Jan and Chuck will >> be a separates patch! > > Christian already updated the patch as I've suggested so no need for you > to send anything. OK, thanks for that! > > Honza >