From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC7ACC433F5 for ; Mon, 27 Dec 2021 03:59:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 073CA6B0071; Sun, 26 Dec 2021 22:59:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 022A96B0072; Sun, 26 Dec 2021 22:59:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E05C96B0073; Sun, 26 Dec 2021 22:59:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id CE7A76B0071 for ; Sun, 26 Dec 2021 22:59:37 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 86E088906E for ; Mon, 27 Dec 2021 03:59:37 +0000 (UTC) X-FDA: 78962219994.26.ECA2C7B Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf28.hostedemail.com (Postfix) with ESMTP id 2CD57C0021 for ; Mon, 27 Dec 2021 03:59:37 +0000 (UTC) Received: by mail-qt1-f182.google.com with SMTP id f9so12601593qtk.4 for ; Sun, 26 Dec 2021 19:59:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=w0TpoHfRoDQ+4/03uti72NNxw61oie+s3OIX8ISzosQ=; b=h95hLNMF1hxHjwOcuy1djdgp5vD9wFjjaLLgswEeErKS+gXo8ypYWC/ShjNHMyNGXP qlSNjiB13iRTmaIIGfLLcPIUeTxI0YBKiWSvQzuWf6iZAs15kHab7nWBlxR5ofsIZcsb qosHP8+y1RE5Y/fajuPT+uHK0K61oUhJiWuXNFhULBmS2JHte0bBEk7jPS1v9aw6+pwr O8u7CjPZn9ZnLfTMGOmd6HjcUVsBkYDe9SWqa7YqbIhtTy8QfeuU8jaOG1wVqTQyssce HOQLSQoiwHvRj0x8qEHux4eVuuypEofeLKGFNXbDCPMl90CoBBOxRhpW2zGZeDpSdNlm JlEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=w0TpoHfRoDQ+4/03uti72NNxw61oie+s3OIX8ISzosQ=; b=wY4UkzXLbMBwWKIzq28+BH5SZU6v9ywgod1NiQEuRqDxnNoq4udyfSRjsAj/hIZoAa JX+yBJYupZYX2RxFttmo92yXYLgFmnpq02ARGQXqPW9BEC2RDUFdYaQAMM8p/YcJrbBV WvRP+emNWgug4Ow66rutcrrKKTt9tAb9jsNvVElUaprQ3rH3mHBEIx9QrF4cyq7Su7Zq VrX0K8Ok/5eaNoUu8WVeDYHH+wyyn35O1GHzpkeDDvwuevUruz26Vx2FmfHSpWrF/Kc/ J7zfzM1BeLe6WelGYxBS3xq0regEJ9TCWdWHmU+VDiyRT09nVrZOm3bEsZv1NB5zO4au nvcg== X-Gm-Message-State: AOAM531jV1aFdO6X/Zfcn0yCOeVYhyp/Ir0ySX3pYfMYtg0Sk1FS06gr FWOc7tPKDwYEd4aQDWTGK8Y= X-Google-Smtp-Source: ABdhPJyZt3oRgN6pJyvHmUAp8htm6pm/m9v7Dx8x7Yo/J6OQK2iX6woCT4CL2IiX0IWZN+Me7FzbVg== X-Received: by 2002:ac8:7b2f:: with SMTP id l15mr13404743qtu.654.1640577576525; Sun, 26 Dec 2021 19:59:36 -0800 (PST) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id h3sm12697688qko.78.2021.12.26.19.59.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Dec 2021 19:59:35 -0800 (PST) Message-ID: <61c93a27.1c69fb81.627b0.8bf6@mx.google.com> X-Google-Original-Message-ID: <20211227035933.GA578235@cgel.zte@gmail.com> Date: Mon, 27 Dec 2021 03:59:33 +0000 From: CGEL To: "Huang, Ying" Cc: akpm@linux-foundation.org, yang.shi@linux.alibaba.com, dave.hansen@linux.intel.com, yang.yang29@zte.com.cn, minchan@kernel.org, saravanand@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/vmstat: add events for THP max_ptes_* exceeds References: <20211225094036.574157-1-yang.yang29@zte.com.cn> <87k0fq7n0b.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k0fq7n0b.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Stat-Signature: okrw4rzqrs91z69pgkrqauxjbbt1z49s X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 2CD57C0021 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=h95hLNMF; spf=pass (imf28.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1640577577-751928 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 27, 2021 at 11:19:32AM +0800, Huang, Ying wrote: > cgel.zte@gmail.com writes: > > > From: Yang Yang > > > > There are interfaces to adjust max_ptes_none, max_ptes_swap, > > max_ptes_shared values, see > > /sys/kernel/mm/transparent_hugepage/khugepaged/. > > > > But system administrator maynot know which value is the best. So > > Add those events to support adjusting max_ptes_* to suitable values. > > > > For example, if default max_ptes_swap value causes too much failures, > > and system uses zram whose IO is fast, administrator could increase > > max_ptes_swap until THP_SCAN_EXCEED_SWAP_PTE not increase anymore. > > > > Signed-off-by: Yang Yang > > --- > > include/linux/vm_event_item.h | 3 +++ > > mm/khugepaged.c | 7 +++++++ > > mm/vmstat.c | 3 +++ > > 3 files changed, 13 insertions(+) > > > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > > index a185cc75ff52..7b2363388bfa 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -98,6 +98,9 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > > THP_SPLIT_PAGE_FAILED, > > THP_DEFERRED_SPLIT_PAGE, > > THP_SPLIT_PMD, > > + THP_SCAN_EXCEED_NONE_PTE, > > + THP_SCAN_EXCEED_SWAP_PTE, > > + THP_SCAN_EXCEED_SHARED_PTE, > > "SCAN" appears too general, how about > > THP_COLLAPSE_EXCEED_SWAP_PTE > > ? > Thanks for your suggesting. But I think SCAN is easy to understand, it is SCAN behaviour cause the event, and we know this event is comes from SCAN_EXCEED_*_PTE. > Best Regards, > Huang, Ying > > [snip]