From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A001C433F5 for ; Mon, 11 Apr 2022 10:29:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 496446B0072; Mon, 11 Apr 2022 06:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 445F46B0073; Mon, 11 Apr 2022 06:29:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E7006B0074; Mon, 11 Apr 2022 06:29:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 1BDD86B0072 for ; Mon, 11 Apr 2022 06:29:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A5AA78249980 for ; Mon, 11 Apr 2022 10:29:40 +0000 (UTC) X-FDA: 79344226920.23.79C4B84 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf01.hostedemail.com (Postfix) with ESMTP id 208BA4000A for ; Mon, 11 Apr 2022 10:29:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DA7861F864; Mon, 11 Apr 2022 10:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649672978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t/9VhRHA3bs9D3N2QQLj6PkxXuNIk+sDoWn9CyzhHuI=; b=Ex6kVTaw1yBHbtQj6c/P8yf1mPjyw1jMH4/cp150YTqQMi+bvCshbuacrEvE7LEb9am6hC ePMnHKWIIaptDkJPXBdbYOSSaTQAgCQRfH5IU2KV52BHtCk0ttY1VE2G8psgaP8YCsKhjm QQKlBl+LIKgA4dyOwaMQpKSftCQGWew= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649672978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t/9VhRHA3bs9D3N2QQLj6PkxXuNIk+sDoWn9CyzhHuI=; b=uSPfeSwGXu3KdtorMecGLntCVetyRQpy2lGl8ai/pdf6AjG1+TwVOpDMJjNEStf9uxjCzc xsRoAv/U+XaXV6AA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ACCB513AB5; Mon, 11 Apr 2022 10:29:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id J2tAKRIDVGKhYAAAMHmgww (envelope-from ); Mon, 11 Apr 2022 10:29:38 +0000 Message-ID: <61d43197-3ff4-d51a-d84f-fa5a41fcaf7d@suse.cz> Date: Mon, 11 Apr 2022 12:29:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] mm/slub: remove unused parameter in setup_object*() Content-Language: en-US To: JaeSang Yoo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin Cc: Ohhoon Kwon , Wonhyuk Yang , Jiyoup Kim , Donghyeok Kim , Christoph Lameter , JaeSang Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220411072534.3372768-1-jsyoo5b@gmail.com> From: Vlastimil Babka In-Reply-To: <20220411072534.3372768-1-jsyoo5b@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ex6kVTaw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=uSPfeSwG; spf=pass (imf01.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 208BA4000A X-Stat-Signature: 656b5jb79u1w6f1yxdti5nrjme9x5uf9 X-HE-Tag: 1649672979-866715 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/11/22 09:25, JaeSang Yoo wrote: > setup_object_debug() and setup_object() has unused parameter, "struct > slab *slab". Remove it. > > By the commit 3ec0974210fe ("SLUB: Simplify debug code"), > setup_object_debug() were introduced to refactor previous code blocks > in the setup_object(). Previous code used SlabDebug() to init_object() > and init_tracking(). As the SlabDebug() takes "struct page *page" as > argument, the setup_object_debug() checks flag of "struct kmem_cache *s" > which doesn't require "struct page *page". > As the struct page were changed into struct slab by commit bb192ed9aa719 > ("mm/slub: Convert most struct page to struct slab by spatch"), but it's > still unused parameter. > > Suggested-by: Ohhoon Kwon > Signed-off-by: JaeSang Yoo Thanks, added. > --- > mm/slub.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 9fe000fd19ca..273bbba74ca1 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1264,8 +1264,7 @@ static inline void dec_slabs_node(struct kmem_cache *s, int node, int objects) > } > > /* Object debug checks for alloc/free paths */ > -static void setup_object_debug(struct kmem_cache *s, struct slab *slab, > - void *object) > +static void setup_object_debug(struct kmem_cache *s, void *object) > { > if (!kmem_cache_debug_flags(s, SLAB_STORE_USER|SLAB_RED_ZONE|__OBJECT_POISON)) > return; > @@ -1631,8 +1630,7 @@ slab_flags_t kmem_cache_flags(unsigned int object_size, > return flags | slub_debug_local; > } > #else /* !CONFIG_SLUB_DEBUG */ > -static inline void setup_object_debug(struct kmem_cache *s, > - struct slab *slab, void *object) {} > +static inline void setup_object_debug(struct kmem_cache *s, void *object) {} > static inline > void setup_slab_debug(struct kmem_cache *s, struct slab *slab, void *addr) {} > > @@ -1775,10 +1773,9 @@ static inline bool slab_free_freelist_hook(struct kmem_cache *s, > return *head != NULL; > } > > -static void *setup_object(struct kmem_cache *s, struct slab *slab, > - void *object) > +static void *setup_object(struct kmem_cache *s, void *object) > { > - setup_object_debug(s, slab, object); > + setup_object_debug(s, object); > object = kasan_init_slab_obj(s, object); > if (unlikely(s->ctor)) { > kasan_unpoison_object_data(s, object); > @@ -1897,13 +1894,13 @@ static bool shuffle_freelist(struct kmem_cache *s, struct slab *slab) > /* First entry is used as the base of the freelist */ > cur = next_freelist_entry(s, slab, &pos, start, page_limit, > freelist_count); > - cur = setup_object(s, slab, cur); > + cur = setup_object(s, cur); > slab->freelist = cur; > > for (idx = 1; idx < slab->objects; idx++) { > next = next_freelist_entry(s, slab, &pos, start, page_limit, > freelist_count); > - next = setup_object(s, slab, next); > + next = setup_object(s, next); > set_freepointer(s, cur, next); > cur = next; > } > @@ -1974,11 +1971,11 @@ static struct slab *allocate_slab(struct kmem_cache *s, gfp_t flags, int node) > > if (!shuffle) { > start = fixup_red_left(s, start); > - start = setup_object(s, slab, start); > + start = setup_object(s, start); > slab->freelist = start; > for (idx = 0, p = start; idx < slab->objects - 1; idx++) { > next = p + s->size; > - next = setup_object(s, slab, next); > + next = setup_object(s, next); > set_freepointer(s, p, next); > p = next; > }