From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EB8C43334 for ; Tue, 26 Jul 2022 13:05:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F078900002; Tue, 26 Jul 2022 09:05:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09F9A8E0001; Tue, 26 Jul 2022 09:05:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E82FB900002; Tue, 26 Jul 2022 09:05:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D9E128E0001 for ; Tue, 26 Jul 2022 09:05:46 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A92501A127B for ; Tue, 26 Jul 2022 13:05:46 +0000 (UTC) X-FDA: 79729273092.21.7F3AB9D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id E02A5400C2 for ; Tue, 26 Jul 2022 13:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658840745; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EqUAbmYzG64TPwyrTQpkR4cRsi5LS7Ye58HFj4CSO6I=; b=NsqUjPzJrOO20NoSjX72bViFM8w5jHkKYFKQ1nt9FRQvvjPLgOiG0ZLZD9gcOL15uU3eNc XL0Zgj6Vv/Wri4hMEHRVAO1CVGGdqEjt5cl3y1nq+Z4qu6OPaPG9YMxcsaxW3lXhUBYaiC g1x1LoNW87rrhOsClfkm6VuGjCwB7nM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-171-MRwmRLykNL2LEfkXQHDFGA-1; Tue, 26 Jul 2022 09:05:44 -0400 X-MC-Unique: MRwmRLykNL2LEfkXQHDFGA-1 Received: by mail-wm1-f69.google.com with SMTP id c62-20020a1c3541000000b003a30d86cb2dso10231945wma.5 for ; Tue, 26 Jul 2022 06:05:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=EqUAbmYzG64TPwyrTQpkR4cRsi5LS7Ye58HFj4CSO6I=; b=UuSA3EcDynUW7V7FcspIas2BLoYrZjikfdxOyvKcUBgmxVVEaeoE0lJ+y85Os2rPxg ABZ6aoKa9OiQZ+zLDSXKr5caViF+0FPWTzacelKs5cfJBsm2CaDURxRuGyOl/LYvtrTg 2YSFY1tiZcIxG7gR+D4bQuXZN1Cu5XHJWCDX5gsCgtonojbQFoU7LYqA8QI1F4VbzaNg FZcMqoCNe/k6rfjHVJfQMgcWrH1BSSp3a4I8IDFuuDefFasfAdndfLY6Gl2aNCJzbZs6 N3DiqWeLoudQImJl7msqWjhxo0quRsKgxqBiGEElPh+XPksOFMuqPhJZDdCpTcU7L7sR cETA== X-Gm-Message-State: AJIora/xqfXVVcLPdudXaEYmspjkYQfxVzPGuB0h4gNnmBnqZ1VCHENl NVuv9DXsw0gn9j7rai7XbeIXMehjNMJAJd5uFBVqxKAJ305GxMNoKie140LoX/IfgvXz7iYOA2M DdOIin5/PV5U= X-Received: by 2002:a05:600c:4f51:b0:3a3:478f:6d1c with SMTP id m17-20020a05600c4f5100b003a3478f6d1cmr11290470wmq.143.1658840742899; Tue, 26 Jul 2022 06:05:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vMY6FedwCHXNkq9vi1saetTdROMBAqzr8R5qvIKH1IFxZ0VbgPqLEfOdGvT3QBajAAVIMU/w== X-Received: by 2002:a05:600c:4f51:b0:3a3:478f:6d1c with SMTP id m17-20020a05600c4f5100b003a3478f6d1cmr11290440wmq.143.1658840742550; Tue, 26 Jul 2022 06:05:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:fe00:8ba4:5871:abc3:8a75? (p200300cbc708fe008ba45871abc38a75.dip0.t-ipconnect.de. [2003:cb:c708:fe00:8ba4:5871:abc3:8a75]) by smtp.gmail.com with ESMTPSA id h9-20020a5d4fc9000000b0021e6277bc50sm13615108wrw.36.2022.07.26.06.05.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 06:05:42 -0700 (PDT) Message-ID: <621714a3-f3fd-e9de-c072-0fef3ad76288@redhat.com> Date: Tue, 26 Jul 2022 15:05:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] mm: use is_zone_movable_page() helper To: Kefeng Wang , Oscar Salvador , Andrew Morton , linux-mm@kvack.org Cc: Jason Wang , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <20220726131135.146912-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220726131135.146912-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658840746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EqUAbmYzG64TPwyrTQpkR4cRsi5LS7Ye58HFj4CSO6I=; b=igqasK6fPSYzhueroDal8075VslBgJC5Q7ZfGHBnYne364DvAVJwuMpfPicC5bqpN7LvaE gT3bX6+O3bEBi45jUQiV2UTcVbgnzmnOP3e+h/FAWEz1yh6wn6fzQRLvhAGGUFPdcs2AX6 Ppd442L8xiHi18eaokQQGFrjPk5ccLQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658840746; a=rsa-sha256; cv=none; b=uGJBhir4rzUDzkBFFeYMI+WHIYADke0OLDOlBf+qzt/sdRYckbesufU2yM3CY3FtVgee9N V1gswj7oCXdqpiKXg7fK6xkETgvkBClPAbEL/y5fdQdwuCWXujrmuPPKPgMZiQcJLeGbVL Z8LiOVQKqmiERbiQoSsRKNjzgT+P1M8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NsqUjPzJ; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf11.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E02A5400C2 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NsqUjPzJ; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf11.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Stat-Signature: icu7qc9png9esycg1y4b1xt9hcka4rkg X-HE-Tag: 1658840745-271713 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 26.07.22 15:11, Kefeng Wang wrote: > Use is_zone_movable_page() helper to simplify code. > > Signed-off-by: Kefeng Wang > --- > drivers/virtio/virtio_mem.c | 6 ++---- > mm/memory_hotplug.c | 2 +- > 2 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index e07486f01999..0c2892ec6817 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm, > unsigned long mb_id, > unsigned long start_pfn) > { > - const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) == > - ZONE_MOVABLE; > + const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn)); > int new_state; > > switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) { > @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages) > */ > static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages) > { > - const bool is_movable = page_zonenum(pfn_to_page(pfn)) == > - ZONE_MOVABLE; > + const bool is_movable = is_zone_movable_page(pfn_to_page(pfn)); > int rc, retry_count; > > /* > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 1213d0c67a53..0f5914964a32 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid, > if (!page) > continue; > /* If anything is !MOVABLE online the rest !MOVABLE. */ > - if (page_zonenum(page) != ZONE_MOVABLE) > + if (!is_zone_movable_page(page)) > goto kernel_zone; > online_pages += PAGES_PER_SECTION; > } Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb