[PATCH] mm: use is_zone_movable

linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] mm: use is_zone_movable_page() helper
@ 2022-07-26 13:11 Kefeng Wang
  2022-07-26 13:05 ` David Hildenbrand
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kefeng Wang @ 2022-07-26 13:11 UTC (permalink / raw)
  To: David Hildenbrand, Oscar Salvador, Andrew Morton, linux-mm
  Cc: Jason Wang, Michael S. Tsirkin, linux-kernel, Kefeng Wang

Use is_zone_movable_page() helper to simplify code.

Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 drivers/virtio/virtio_mem.c | 6 ++----
 mm/memory_hotplug.c         | 2 +-
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index e07486f01999..0c2892ec6817 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm,
 					 unsigned long mb_id,
 					 unsigned long start_pfn)
 {
-	const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) ==
-				ZONE_MOVABLE;
+	const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn));
 	int new_state;
 
 	switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) {
@@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages)
  */
 static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages)
 {
-	const bool is_movable = page_zonenum(pfn_to_page(pfn)) ==
-				ZONE_MOVABLE;
+	const bool is_movable = is_zone_movable_page(pfn_to_page(pfn));
 	int rc, retry_count;
 
 	/*
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 1213d0c67a53..0f5914964a32 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid,
 			if (!page)
 				continue;
 			/* If anything is !MOVABLE online the rest !MOVABLE. */
-			if (page_zonenum(page) != ZONE_MOVABLE)
+			if (!is_zone_movable_page(page))
 				goto kernel_zone;
 			online_pages += PAGES_PER_SECTION;
 		}
-- 
2.35.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: use is_zone_movable_page() helper
  2022-07-26 13:11 [PATCH] mm: use is_zone_movable_page() helper Kefeng Wang
@ 2022-07-26 13:05 ` David Hildenbrand
  2022-07-27  4:59 ` Jason Wang
  2022-07-27  5:19 ` Pankaj Gupta
  2 siblings, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2022-07-26 13:05 UTC (permalink / raw)
  To: Kefeng Wang, Oscar Salvador, Andrew Morton, linux-mm
  Cc: Jason Wang, Michael S. Tsirkin, linux-kernel

On 26.07.22 15:11, Kefeng Wang wrote:
> Use is_zone_movable_page() helper to simplify code.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/virtio/virtio_mem.c | 6 ++----
>  mm/memory_hotplug.c         | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index e07486f01999..0c2892ec6817 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm,
>  					 unsigned long mb_id,
>  					 unsigned long start_pfn)
>  {
> -	const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) ==
> -				ZONE_MOVABLE;
> +	const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn));
>  	int new_state;
>  
>  	switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) {
> @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages)
>   */
>  static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages)
>  {
> -	const bool is_movable = page_zonenum(pfn_to_page(pfn)) ==
> -				ZONE_MOVABLE;
> +	const bool is_movable = is_zone_movable_page(pfn_to_page(pfn));
>  	int rc, retry_count;
>  
>  	/*
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 1213d0c67a53..0f5914964a32 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid,
>  			if (!page)
>  				continue;
>  			/* If anything is !MOVABLE online the rest !MOVABLE. */
> -			if (page_zonenum(page) != ZONE_MOVABLE)
> +			if (!is_zone_movable_page(page))
>  				goto kernel_zone;
>  			online_pages += PAGES_PER_SECTION;
>  		}


Reviewed-by: David Hildenbrand <david@redhat.com>

-- 
Thanks,

David / dhildenb



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: use is_zone_movable_page() helper
  2022-07-26 13:11 [PATCH] mm: use is_zone_movable_page() helper Kefeng Wang
  2022-07-26 13:05 ` David Hildenbrand
@ 2022-07-27  4:59 ` Jason Wang
  2022-07-27  5:19 ` Pankaj Gupta
  2 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2022-07-27  4:59 UTC (permalink / raw)
  To: Kefeng Wang
  Cc: David Hildenbrand, Oscar Salvador, Andrew Morton, linux-mm,
	Michael S. Tsirkin, linux-kernel

On Tue, Jul 26, 2022 at 9:05 PM Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> Use is_zone_movable_page() helper to simplify code.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Acked-by: Jason Wang <jasowang@redhat.com>

> ---
>  drivers/virtio/virtio_mem.c | 6 ++----
>  mm/memory_hotplug.c         | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index e07486f01999..0c2892ec6817 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm,
>                                          unsigned long mb_id,
>                                          unsigned long start_pfn)
>  {
> -       const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) ==
> -                               ZONE_MOVABLE;
> +       const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn));
>         int new_state;
>
>         switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) {
> @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages)
>   */
>  static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages)
>  {
> -       const bool is_movable = page_zonenum(pfn_to_page(pfn)) ==
> -                               ZONE_MOVABLE;
> +       const bool is_movable = is_zone_movable_page(pfn_to_page(pfn));
>         int rc, retry_count;
>
>         /*
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 1213d0c67a53..0f5914964a32 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid,
>                         if (!page)
>                                 continue;
>                         /* If anything is !MOVABLE online the rest !MOVABLE. */
> -                       if (page_zonenum(page) != ZONE_MOVABLE)
> +                       if (!is_zone_movable_page(page))
>                                 goto kernel_zone;
>                         online_pages += PAGES_PER_SECTION;
>                 }
> --
> 2.35.3
>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mm: use is_zone_movable_page() helper
  2022-07-26 13:11 [PATCH] mm: use is_zone_movable_page() helper Kefeng Wang
  2022-07-26 13:05 ` David Hildenbrand
  2022-07-27  4:59 ` Jason Wang
@ 2022-07-27  5:19 ` Pankaj Gupta
  2 siblings, 0 replies; 4+ messages in thread
From: Pankaj Gupta @ 2022-07-27  5:19 UTC (permalink / raw)
  To: Kefeng Wang
  Cc: David Hildenbrand, Oscar Salvador, Andrew Morton, Linux MM,
	Jason Wang, Michael S. Tsirkin, LKML

> Use is_zone_movable_page() helper to simplify code.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  drivers/virtio/virtio_mem.c | 6 ++----
>  mm/memory_hotplug.c         | 2 +-
>  2 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index e07486f01999..0c2892ec6817 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -862,8 +862,7 @@ static void virtio_mem_sbm_notify_online(struct virtio_mem *vm,
>                                          unsigned long mb_id,
>                                          unsigned long start_pfn)
>  {
> -       const bool is_movable = page_zonenum(pfn_to_page(start_pfn)) ==
> -                               ZONE_MOVABLE;
> +       const bool is_movable = is_zone_movable_page(pfn_to_page(start_pfn));
>         int new_state;
>
>         switch (virtio_mem_sbm_get_mb_state(vm, mb_id)) {
> @@ -1158,8 +1157,7 @@ static void virtio_mem_fake_online(unsigned long pfn, unsigned long nr_pages)
>   */
>  static int virtio_mem_fake_offline(unsigned long pfn, unsigned long nr_pages)
>  {
> -       const bool is_movable = page_zonenum(pfn_to_page(pfn)) ==
> -                               ZONE_MOVABLE;
> +       const bool is_movable = is_zone_movable_page(pfn_to_page(pfn));
>         int rc, retry_count;
>
>         /*
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 1213d0c67a53..0f5914964a32 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -936,7 +936,7 @@ static struct zone *auto_movable_zone_for_pfn(int nid,
>                         if (!page)
>                                 continue;
>                         /* If anything is !MOVABLE online the rest !MOVABLE. */
> -                       if (page_zonenum(page) != ZONE_MOVABLE)
> +                       if (!is_zone_movable_page(page))
>                                 goto kernel_zone;
>                         online_pages += PAGES_PER_SECTION;
>                 }

Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-27  5:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-26 13:11 [PATCH] mm: use is_zone_movable_page() helper Kefeng Wang
2022-07-26 13:05 ` David Hildenbrand
2022-07-27  4:59 ` Jason Wang
2022-07-27  5:19 ` Pankaj Gupta

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).