From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFBCC433F5 for ; Wed, 23 Mar 2022 09:06:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A0EB6B0072; Wed, 23 Mar 2022 05:06:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4024D6B0073; Wed, 23 Mar 2022 05:06:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 254C96B0074; Wed, 23 Mar 2022 05:06:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 0E7DA6B0072 for ; Wed, 23 Mar 2022 05:06:04 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AA83F18147594 for ; Wed, 23 Mar 2022 09:06:03 +0000 (UTC) X-FDA: 79275069006.24.64C31E3 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf19.hostedemail.com (Postfix) with ESMTP id 388A81A0018 for ; Wed, 23 Mar 2022 09:06:03 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id 10so607719qtz.11 for ; Wed, 23 Mar 2022 02:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=jXKJox2Om6etwhk7KJudaau7HUz1EpjmJZ/s63T4/k0=; b=bm/LCnkLnZw611V9fsvsjCOv4UdBglqU2xwn9F0GdNmft3KRdpuArXrTqUlAZr1GfI EMhMVS9AnMUfwKK2rZNZbLV11Q5tIPzC+SCr+3FPP05iQV7Qam3S9B4y53rUHTs51jlR SxXybEdYfprHXi/F8oeiTLQyPpns8q2FLTVfpq/2i8WG3uY/5N/qgB2D8OZDDUDnxTMO sjqJyqH/YEQk63jF/ifA3HYmZ+VrxQNCZL/CxU4rdKyeG16PUd8TtHKUka1mdVQJTL1z R1K0XaUNWH0XRaQErsGKjkS5+ofNUsQFb6lpPRQmec7o5m0NtERx6NHVhY+imQup79Bn 027g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=jXKJox2Om6etwhk7KJudaau7HUz1EpjmJZ/s63T4/k0=; b=nZVhgWV/XspC6lDsKatmHU8Go4abnvpIftjV12Bn0RdSnuywmvymCtYAy0LMbEPzD2 pPLy5HNmHOY8wpG8PVrvwJFZGqwkdJ2ib7NwKItPDs1Y3yB/UpWPJ/yMxXrhlttTDHHx K+JMYZ0l8VoSzsUqoF1HnVO8oNtpmPqFZNFJuBMixCZbdXW4651XnykVEhQ3ubcISxev A/HPRXoTE52NjfId85bSiPYCCGyU6OGg/lpUf+FOLcMj/HTLojylAO4199NQwPqwqM3v trDw+iKMIXLdK74X6iHzrAMA/VpNIXdGkOSr2VKJKyjhcJ8hYjjE8nr/oacFbMtzrm+u XpdQ== X-Gm-Message-State: AOAM532Z2IOu4ZHB6nT7rzyiODgZH2PFCAbqGaAdp9Ui0aQTaPUMv/N6 FOqHJxITM31HPa7/b0zTd0c= X-Google-Smtp-Source: ABdhPJx0jnj942+IQDs3MSGcp0tcvBVn7ITkv+Q6pQ7GaRiUtb5yBiAnCoj/AlWDZZI22lJo4htAXg== X-Received: by 2002:ac8:5d94:0:b0:2e1:ce44:5041 with SMTP id d20-20020ac85d94000000b002e1ce445041mr23459241qtx.356.1648026362515; Wed, 23 Mar 2022 02:06:02 -0700 (PDT) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id d2-20020ac85ac2000000b002e1cc2d363asm15350634qtd.24.2022.03.23.02.06.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Mar 2022 02:06:01 -0700 (PDT) Message-ID: <623ae2f9.1c69fb81.28ae2.21f3@mx.google.com> X-Google-Original-Message-ID: <20220323090558.GA2345975@cgel.zte@gmail.com> Date: Wed, 23 Mar 2022 09:05:58 +0000 From: CGEL To: David Hildenbrand Cc: akpm@linux-foundation.org, bsingharora@gmail.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Yang Yang , Ran Xiaokai Subject: Re: [PATCH] delayacct: track delays from COW References: <20220322110444.2340748-1-yang.yang29@zte.com.cn> <9f9ddbf7-797a-58d8-2903-beacb2698329@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f9ddbf7-797a-58d8-2903-beacb2698329@redhat.com> X-Stat-Signature: jpk5n8x55suxwmzx3srof439mbrany3t Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="bm/LCnkL"; spf=pass (imf19.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 388A81A0018 X-HE-Tag: 1648026363-986434 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 23, 2022 at 09:49:46AM +0100, David Hildenbrand wrote: > On 22.03.22 12:04, cgel.zte@gmail.com wrote: > > From: Yang Yang > > > > Delay accounting does not track the delay of COW. When tasks trigger > > much COW, it may spend a amount of time waiting for it. To get the > > impact of tasks in COW, measure the delay when it happens. This > > could help users to do tunnings, such as decide whether to use > > ksm or not. > > > > Also update tools/accounting/getdelays.c: > > > > / # ./getdelays -dl -p 231 > > print delayacct stats ON > > listen forever > > PID 231 > > > > CPU count real total virtual total delay total delay average > > 6247 1859000000 2154070021 1674255063 0.268ms > > IO count delay total delay average > > 0 0 0ms > > SWAP count delay total delay average > > 0 0 0ms > > RECLAIM count delay total delay average > > 0 0 0ms > > THRASHING count delay total delay average > > 0 0 0ms > > COMPACT count delay total delay average > > 3 72758 0ms > > COW count delay total delay average > > 3635 271567604 0ms > > You should also update Documentation/accounting/delay-accounting.rst > most probably. I will update this documentation immediately if this patch is merged. > Overall LGTM and this might be of value not only for KSM but for anybody > using fork(). There will be collisions with [1], especially [2], which I > want to get in -next early after we have v5.18-rc1 (after rebasing [1] > on top of this). > > We'll have to decide if we want to also account hugetlb wp code > (hugetlb_cow), and if we want to account "unsharing" here as well under > cow (I tend to say that we want to for simplicity). For THP, we only > split and don't copy, so there isn't anything to account. > Thanks for your reminding, we will work on that too. > [1] https://lore.kernel.org/r/20220315104741.63071-1-david@redhat.com > [2] https://lore.kernel.org/r/20220315104741.63071-14-david@redhat.com > > -- > Thanks, > > David / dhildenb