From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D25C47DD9 for ; Wed, 27 Mar 2024 08:47:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5944D6B0093; Wed, 27 Mar 2024 04:47:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 544036B0095; Wed, 27 Mar 2024 04:47:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BE036B0098; Wed, 27 Mar 2024 04:47:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2B70A6B0093 for ; Wed, 27 Mar 2024 04:47:33 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F41B71201E2 for ; Wed, 27 Mar 2024 08:47:32 +0000 (UTC) X-FDA: 81942190344.10.246F2EA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id ABEDFA0005 for ; Wed, 27 Mar 2024 08:47:30 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K8CNK09i; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711529250; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mr6CHANv5/Pxd2mqOgkaDkz4dpnu39dS4lzW9kZ1PzQ=; b=WpqjaVBlNk4AlEqYyvOJOEbMQKol6ZbOXed9yfSfLeswHM4Jb13wSm+h2FGxg4RSGth5Mb 3lG+sEs5pDAoUhZh4aKeKszLg5bAjA0XVHLdp5BV5YzbZC8mxmvVshG5iVA9a4JOhzFDIf r/EbF3w0BbYiKselzPKuu5vCXa4ayTU= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K8CNK09i; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711529250; a=rsa-sha256; cv=none; b=djmPF69h8XxhsajoEzGwoFhk0F9A922KTHPzRcCn2pltKFru/lQGpf+pQwEpz4y1Ee1wP6 nmFuvnCCQGMEKld+v3Lo5yomZ2YkRmba9LYnictbZe14+/8jaN8EqXlvibgdQL1UwMu8sY K5WsSCa7+6xKkuA7AHwVze6oRm8j3js= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711529249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mr6CHANv5/Pxd2mqOgkaDkz4dpnu39dS4lzW9kZ1PzQ=; b=K8CNK09iBFXbrmzFRNuGXT2uIM+d0nzGSNrDCMQDpMBzd90zGIvlhYe6rMM89xTjB44XzQ T95qH32/6bVzIpA9sA9ljT+luC/nFj5MrbJ8vQYzCneJMNb2xUJ38W3KfItL1WnZA+djRJ pixG+hjjqzSVrOi8V7y8N91E8DSIt3U= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-LarjFStTOm--lbFL4FvKsQ-1; Wed, 27 Mar 2024 04:47:28 -0400 X-MC-Unique: LarjFStTOm--lbFL4FvKsQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-41481ad9364so27938295e9.0 for ; Wed, 27 Mar 2024 01:47:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711529247; x=1712134047; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mr6CHANv5/Pxd2mqOgkaDkz4dpnu39dS4lzW9kZ1PzQ=; b=jqEedtmggAfxE8wmHwBpOwgK07JZXBZ0zIq+bXL7IkS/v7hd923k79+zsaHT9s2fyB Nq56Eq1BaaHbPvMK0ugA0/cFeFn7XU9urKhDjMYnd/f3/QtRyuXeKVt2JQB+QzHQGJPp zAF7a7KJ8J6rfoewJj6uVtUmQSmZtXna+HC6kb7Mwm4gfsDJrxquMQ8n9O+sx3IthDkh BgoNiSoJBEUHBFAw8TMC28/8G+F6Oe31FzvP6lLCaCQkurzkYiwFm+ELvs5z5/TVptSZ SXJtCN+Im6r4xPvJJEGgpGoS7kbMhMuZTnHMJ9XVb7wK6VJKb8S3Ursew9FF4DshnG8h Jm7w== X-Forwarded-Encrypted: i=1; AJvYcCWCqn05xpUdAqZn47hVf+MaY17QstGnBmIVSvRSm8cIUWyQyOB69iKxYZ+0udR2QAehj9RzSPRhLVp0ZHmSRSvtMX0= X-Gm-Message-State: AOJu0Yyor3XqmX1XEHuhzmJtKPm/2jZW/VeHpdm2eE7WHQUxUSSlJwbh 9JDErunXGmHluwO5qnz+TdYIV9p6YsPq5KMJEkYQTVUIzHxXDutRc+x5P9j0DYS7EqjpIpNAb9m IEvtah68oN3A/OnFZxOEpTkqu/AdoxSWZg+IewLafxWcqHGrZ X-Received: by 2002:a05:600c:a07:b0:414:7eca:d9a5 with SMTP id z7-20020a05600c0a0700b004147ecad9a5mr1889978wmp.12.1711529246901; Wed, 27 Mar 2024 01:47:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBOvbz8Zehv/FlOIpgY15QHwvHr+Q3GUSn1NCLjUZAtaX1/rX09Ir1S0ULPPyL6hQrL72Lhg== X-Received: by 2002:a05:600c:a07:b0:414:7eca:d9a5 with SMTP id z7-20020a05600c0a0700b004147ecad9a5mr1889944wmp.12.1711529246385; Wed, 27 Mar 2024 01:47:26 -0700 (PDT) Received: from ?IPV6:2003:cb:c708:8a00:362b:7e34:a3bc:9ddf? (p200300cbc7088a00362b7e34a3bc9ddf.dip0.t-ipconnect.de. [2003:cb:c708:8a00:362b:7e34:a3bc:9ddf]) by smtp.gmail.com with ESMTPSA id g18-20020a05600c001200b00413eb5aa694sm1438713wmc.38.2024.03.27.01.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 01:47:25 -0700 (PDT) Message-ID: <6248d6fb-b982-4ebd-93a9-7750cc4a5039@redhat.com> Date: Wed, 27 Mar 2024 09:47:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm: support multi-size THP numa balancing To: "Huang, Ying" , Baolin Wang Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, wangkefeng.wang@huawei.com, jhubbard@nvidia.com, 21cnbao@gmail.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <87cyrgo2ez.fsf@yhuang6-desk2.ccr.corp.intel.com> <87edbwm6fh.fsf@yhuang6-desk2.ccr.corp.intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <87edbwm6fh.fsf@yhuang6-desk2.ccr.corp.intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: ABEDFA0005 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ro71toia1if7xe4tigzcfe7u98fopz3k X-HE-Tag: 1711529250-245347 X-HE-Meta: U2FsdGVkX1+AyNfacUz2yZR0bWgYBmVXeP84/C+s2TRPGEukDY7M0elDO2N56UHBFBkMn/JiMeQSzefWyaFbShJzhN2gU2WdFYWw2pilBhzcYkWiKUMczW/bPIcm3XSaCCKXygmhk2DQ+BrfchL7aPLqd/3HDa7MlttTNjz7ZgrpyD4KqqEeOOCWPPJF/2jXY4QXqO0RpS46SLj9U3pVRcSZV61nKfwQMJjSTc4baKhGN3feYRdsMGa/3gvdkcYAcRfE/lHMhpXQUepQl5jma836Q5GijquzKLmpurnU1SZGS7rHiNzBK4XFEmSXgWxxdUyJOFem0BY6F6JwS2e0dv1l8/E2HOAib4H2f26pHwdpIGePWbDZrKrx0yNQ2/91VZn4im6DMl0sr+sI9lyAiGOdwjeyvA2aU3goQrweG1tmvFFu+eXT6laGCVMuuWhKO/TZVrYBY5pnxwde38KbtZD9Ndwqmsl696KHv5t/YxQOpetyo9JVMhROcjYtElNfsfC0ZVxk7MF53eTjh2lc//aokgndMO8kXLyrQbLhoQmzWkqMpiMoHPK/+gXfe+qnd5Vc4+bzlS6kqMy+blpm17MgkVIX9mo24MKA2p1+sed7zRlYAxE8X0dKfxhAxUWLUi4ccrENfPnO05FJR/oPn9DR8rmqSwO/6qL321YMng/pB5L3nCjVcvjUlr8rKMgZQVJ7Zx6DoWHCoL17RlYXLAiSpjdqwmb2DW3ghKTRrgE/TlpfGcGmIkUqNjHohmfrGu5c49yVQjmSK/n3AM5C09z3GEMbZVdAjcOLqZx9eEYoYj0rBKK/B68hCAgk5khxwfKVenop5aGtSfqte3TDzdGv7RyS22SnxkC6HTD5KBgdQMenAgwk4juPoDO3xJC+VWWrl9LBIsTRJJqnuqp2BmK6pcGHgEK1AsP0eC+RgXvn3hGmu1jJrkqi81O7WNKqEEh0e6+99LDiV2TsOyp b+mRzvXV a1VL2mspDSQYE8XhwSYFo3XldpfMFMpJd0m5w7eP+da1YwGZUZOmebgoycRSrO1UYmlaTAFiYlbS8ktLGTVVubIIe1WfGgLzbg8VIfN50EKt59YTifRhX+zwLLM7AtCaYXieTFJlbKN4mk+v0JCBYlE9Nh57QOBV1MrwPYbecoI+kfnTcWYWIvhw2mHyTwZ9zDLYZX3q0Y7rSVIxeG2K3IL0PdZo+z1nqpIBAJSIFiv3QnBKogcDU4oKGbMAusAfisbe5su93G/9d5tAOlqpES02MJX8taMDqVcKny07HMHkmjplfLf00OncKg7+ncYnKq07GCxdJCj3r6nuB5Bi6p88Q+V5VJ5eTn384OS1BDvimLlCWMWW//nYZoUMUlc0IJEPvHbOstqtoGZEwhwwboo/B8ob5do5TrmfVj2DmBUHcd2mLLkikmpYleLj/P3Mpuxbq02uEZjWpnfGsZkzHu08uwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 27.03.24 09:21, Huang, Ying wrote: > Baolin Wang writes: > >> On 2024/3/27 10:04, Huang, Ying wrote: >>> Baolin Wang writes: >>> >>>> Now the anonymous page allocation already supports multi-size THP (mTHP), >>>> but the numa balancing still prohibits mTHP migration even though it is an >>>> exclusive mapping, which is unreasonable. >>>> >>>> Allow scanning mTHP: >>>> Commit 859d4adc3415 ("mm: numa: do not trap faults on shared data section >>>> pages") skips shared CoW pages' NUMA page migration to avoid shared data >>>> segment migration. In addition, commit 80d47f5de5e3 ("mm: don't try to >>>> NUMA-migrate COW pages that have other uses") change to use page_count() >>>> to avoid GUP pages migration, that will also skip the mTHP numa scaning. >>>> Theoretically, we can use folio_maybe_dma_pinned() to detect the GUP >>>> issue, although there is still a GUP race, the issue seems to have been >>>> resolved by commit 80d47f5de5e3. Meanwhile, use the folio_likely_mapped_shared() >>>> to skip shared CoW pages though this is not a precise sharers count. To >>>> check if the folio is shared, ideally we want to make sure every page is >>>> mapped to the same process, but doing that seems expensive and using >>>> the estimated mapcount seems can work when running autonuma benchmark. >>> Because now we can deal with shared mTHP, it appears even possible >>> to >>> remove folio_likely_mapped_shared() check? >> >> IMO, the issue solved by commit 859d4adc3415 is about shared CoW >> mapping, and I prefer to measure it in another patch:) > > I mean we can deal with shared mTHP (by multiple threads or multiple > processes) with this patch. Right? It's independent of the folio order. We don't want to mess with shared COW pages, see commit 859d4adc3415a64ccb8b0c50dc4e3a888dcb5805 Author: Henry Willard Date: Wed Jan 31 16:21:07 2018 -0800 mm: numa: do not trap faults on shared data section pages. Workloads consisting of a large number of processes running the same program with a very large shared data segment may experience performance problems when numa balancing attempts to migrate the shared cow pages. This manifests itself with many processes or tasks in TASK_UNINTERRUPTIBLE state waiting for the shared pages to be migrated. ... that introduced this handling. -- Cheers, David / dhildenb