From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 544B1C433F5 for ; Sat, 7 May 2022 02:05:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C78D6B0071; Fri, 6 May 2022 22:05:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9763A6B0073; Fri, 6 May 2022 22:05:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817346B0074; Fri, 6 May 2022 22:05:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 721D66B0071 for ; Fri, 6 May 2022 22:05:29 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 3A2871217E2 for ; Sat, 7 May 2022 02:05:29 +0000 (UTC) X-FDA: 79437305178.09.C05B29C Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf06.hostedemail.com (Postfix) with ESMTP id D519F18003C for ; Sat, 7 May 2022 02:05:26 +0000 (UTC) Received: by mail-pl1-f170.google.com with SMTP id k1so9054993pll.4 for ; Fri, 06 May 2022 19:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=jalhMSau/4ac1aQTeKEt0TtpRgwPn28KXUpA5qg/su4=; b=KRd718Jg9pNqg0PO87qH43qF2rb43W1ldMnyH8wRDwVA955pSBtF2Af3S9Z8RoJy9A c4uqDtiZTfE7hmRtXjAlBTkmPZuG8VLUjKfVS5sC4d/snsPe2GfdrXp394cHdt2jfEXd rP8jvytgtnjziXev8xgqf2zdJGypsg0FtDsZadiPSu/a4cWRLzCuRnBpyHhbfudhrCYL x0+eOlN9Bkc7mzWlg75F55khDRlA7PjdXQQb+mp3dfY3qCyMkspEbSdREXmQSQXFsMLW d3WlADCQUxFo0E+OD3dNCf3qmyxe1nDKBdgDN7dDy8NLWumIZzUdnDPoO47ogIY+l8Pg ddgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=jalhMSau/4ac1aQTeKEt0TtpRgwPn28KXUpA5qg/su4=; b=htsKNGtPSbw7EJUx80kSQkeMqXsQ9uk75NUqM3NH0QXWVFrnGEjI6Y6EUJukuy9UuL OkeHjGJddaZJEaz9a2ufpqtqyWLUmy9z3LJBr3L6ZCs1GnPTGb0wMZp2YTlZtpW9wTZW 4HSc6bZ/eaH/0H/Dps4T6RUm+l6LJBElXmaVnrwenDDeNxLO556/bOA/KTCy/UyjmlHu usj3cxUEqoe2n++XszBTzKLer3A6A+VBFmdhKsClNKNWpE412OZWhdw0tz+NkkJ1F6wE XHsJ5wH5v/6/xhqwO9DAkfonAIKE8tdyMJXveJHfjKHxaD6YO520XwyzXwpg7THMsXZ9 OtCQ== X-Gm-Message-State: AOAM533CJEFmVCOD/6QRDg5qFTM//4UQOElN7PapZbqv2nUxNd02isOT L6FoNdyL/eZf/LDy7FPftLs= X-Google-Smtp-Source: ABdhPJy7T41X/72GySbNn47N0uNkibxJz8jqtoaW1gWqsUShW0gI7XsZ/T1SyHoiX8O5W3qqeJnxnw== X-Received: by 2002:a17:903:1206:b0:151:7d67:2924 with SMTP id l6-20020a170903120600b001517d672924mr6535189plh.45.1651889127755; Fri, 06 May 2022 19:05:27 -0700 (PDT) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id d6-20020a170903230600b0015e8d4eb2c5sm1912558plh.271.2022.05.06.19.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 May 2022 19:05:27 -0700 (PDT) Message-ID: <6275d3e7.1c69fb81.1d62.4504@mx.google.com> X-Google-Original-Message-ID: <20220507020525.GA639691@cgel.zte@gmail.com> Date: Sat, 7 May 2022 02:05:25 +0000 From: CGEL To: Michal Hocko Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, shy828301@gmail.com, roman.gushchin@linux.dev, shakeelb@google.com, linmiaohe@huawei.com, william.kucharski@oracle.com, peterx@redhat.com, hughd@google.com, vbabka@suse.cz, songmuchun@bytedance.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, Yang Yang Subject: Re: [PATCH] mm/memcg: support control THP behaviour in cgroup References: <20220505033814.103256-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: D519F18003C X-Stat-Signature: kx6qkney6xcogg56555jznpji7nschk6 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KRd718Jg; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.214.170 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1651889126-649958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 06, 2022 at 03:41:50PM +0200, Michal Hocko wrote: > On Thu 05-05-22 03:38:15, cgel.zte@gmail.com wrote: > > From: Yang Yang > > > > Using THP may promote the performance of memory, but increase memory > > footprint. Applications may use madvise to decrease footprint, but > > not all applications support using madvise, and it takes much costs > > to re-code all the applications. And we notice container becomes more > > and more popular to manage a set of tasks. > > Could you be more specific about the actual usecase? When do you group > processes based on their general THP reqirements? You are mentioning > containers but those are usually bags of different processes that just > share a common objective. > > > So add support for cgroup to control THP behaviour will provide much > > convenience, administrator may only enable THP for important containers, > > and disable it for other containers. > > Why would that be a matter of importance? > > Also what is actual semantic when processes living inside those cgroups > explicitly state their THP requirements? > Docker might support this new cgroup knob in the future, add provide UI likes: # docker run -it --thp-enabled=[always,never,madvise] The cmdline format from https://docs.docker.com/engine/reference/run/ If there are many containers to run on one host, and some of them have high performance requirements, administrator could turn on thp for them: # docker run -it --thp-enabled=always Then all the processes in those containers will always use thp. While other containers turn off thp by: # docker run -it --thp-enabled=never By doing this we could promote important containers's performance with less footprint of thp. > -- > Michal Hocko > SUSE Labs