From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE973C433F5 for ; Wed, 11 May 2022 03:31:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3FEB16B0073; Tue, 10 May 2022 23:31:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3ADD36B0075; Tue, 10 May 2022 23:31:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 275726B0078; Tue, 10 May 2022 23:31:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1976A6B0073 for ; Tue, 10 May 2022 23:31:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id DD718121D92 for ; Wed, 11 May 2022 03:31:02 +0000 (UTC) X-FDA: 79452035964.26.FA85DBA Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf23.hostedemail.com (Postfix) with ESMTP id 1E09B14009D for ; Wed, 11 May 2022 03:30:48 +0000 (UTC) Received: by mail-pf1-f174.google.com with SMTP id p8so845491pfh.8 for ; Tue, 10 May 2022 20:31:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=f3y8JeeuRKLfinU+E+7GukwHp8s5bConUpcRwZiK5/Y=; b=BKbENFHQMubnhde7tbStDgYqbvdUGHDGa3+vDByOTiOk/cx4ITbwSWFkiUnYPiOv3T m/6+vUBywcMUXD73hoF8tjZVxt/Cwrm7I/1Adn8e/mobzys25xFLr0E5RWtPk2HuprZc /Qqxa5EHnsPlq8/oBzZh8cq1Kp/z82xrVJHa/6sfoD15YJe+oIh3NFv4OI8NZgLvHOUQ 5FdE6CSuZdylu/Nt90wYkNqL0Cu28p+s/fADnxBfxxR6Pf0FeDb8TiqIcw95VgLQUn01 ROjN0OtWv3ORaq8G8SJG44rVQLb4tS6a5/nNQawPHTg2VOxI/KHK9dSaWWQBnDGUZnHL m8Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=f3y8JeeuRKLfinU+E+7GukwHp8s5bConUpcRwZiK5/Y=; b=Bdb7ROXBJtX4p1qrgb18m0sdkU0qON0lFOaSzQYULcP4H6s5jWCQINYMMyBsoIFZ2A 9kp8SpcTK1F/PkDrcM9J/LgqVXD2dYINTVw3mAGxKGn43H84iTA21i2kTxfyD4ZvzLFT DXjaiKvL/duo9qyU0o4xK54GqWNfUoO9Qec1nlStTGXgFG/4UplZFiZQz3Rrg2TcCFnY h/eEWFCIFGNpG+3LZntFUX9wJidhIY8YEJcxtoAkF/KcnhOZBGrFPynuM8F/g/cvSl6n sv3IJZFiPOZ06rjcjWi9LC2kl1Dzv2c+uzCPEyBq8dcenBpRvz7lGghIutPA8spmOeEP HJUw== X-Gm-Message-State: AOAM532Rd6DyFJyG6QNc/gnuA7r8I749DdGw+sR6rrBehO4xYJbo0fPg S53jpTNioQ2nXqSLnW9GqFw= X-Google-Smtp-Source: ABdhPJz10XSZ3O1XC+b2OBJCjfyw1qIWUYbdr3HGoF/ULVgejPJuCh8MmJf6bl4fNCCDXIo6uA/3Hw== X-Received: by 2002:a63:1762:0:b0:3db:3306:da60 with SMTP id 34-20020a631762000000b003db3306da60mr167742pgx.23.1652239861465; Tue, 10 May 2022 20:31:01 -0700 (PDT) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id w3-20020a170902e88300b0015ea8b4b8f3sm379160plg.263.2022.05.10.20.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 20:31:01 -0700 (PDT) Message-ID: <627b2df5.1c69fb81.4a22.160f@mx.google.com> X-Google-Original-Message-ID: <20220511033100.GA1498085@cgel.zte@gmail.com> Date: Wed, 11 May 2022 03:31:00 +0000 From: CGEL To: Roman Gushchin Cc: Shakeel Butt , Yang Shi , Michal Hocko , Andrew Morton , Johannes Weiner , Matthew Wilcox , Miaohe Lin , William Kucharski , Peter Xu , Hugh Dickins , Vlastimil Babka , Muchun Song , Suren Baghdasaryan , Linux Kernel Mailing List , Linux MM , Cgroups , Yang Yang Subject: Re: [PATCH] mm/memcg: support control THP behaviour in cgroup References: <6275d3e7.1c69fb81.1d62.4504@mx.google.com> <6278fa75.1c69fb81.9c598.f794@mx.google.com> <6279c354.1c69fb81.7f6c1.15e0@mx.google.com> <627b1d39.1c69fb81.fe952.6426@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1E09B14009D X-Stat-Signature: 73azu436ngymazoh9q487tubi7bo1poq X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BKbENFHQ; spf=pass (imf23.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.210.174 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1652239848-494446 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 10, 2022 at 08:11:16PM -0700, Roman Gushchin wrote: > On Tue, May 10, 2022 at 07:47:29PM -0700, Shakeel Butt wrote: > > On Tue, May 10, 2022 at 7:19 PM CGEL wrote: > > > > > [...] > > > > > > > > > > > > All controls in cgroup v2 should be hierarchical. This is really > > > > > > required for a proper delegation semantic. > > > > > > > > > > > > > > > > Could we align to the semantic of /sys/fs/cgroup/memory.swappiness? > > > > > Some distributions like Ubuntu is still using cgroup v1. > > > > > > > > Other than enable flag, how would you handle the defrag flag > > > > hierarchically? It is much more complicated. > > > > > > Refer to memory.swappiness for cgroup, this new interface better be independent. > > > > Let me give my 0.02. I buy the use-case of Admin restricting THPs to > > low priority jobs but I don't think memory controller is the right > > place to enforce that policy. Michal gave one way (prctl()) to enforce > > that policy. Have you explored the BPF way to enforce this policy? > > +1 for bpf > > I think these THP hints are too implementation-dependent and unstable to become > a part of cgroup API. > Thanks! If no other suggesting we will submit a bpf version of this patch. > Thanks!