From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ABA0C83F0A for ; Tue, 8 Jul 2025 12:12:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CB676B0316; Tue, 8 Jul 2025 08:12:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A35D6B0317; Tue, 8 Jul 2025 08:12:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8926A6B0318; Tue, 8 Jul 2025 08:12:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 76F3F6B0316 for ; Tue, 8 Jul 2025 08:12:25 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2F2DF10B4FE for ; Tue, 8 Jul 2025 12:12:25 +0000 (UTC) X-FDA: 83640985050.05.F395294 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id B86E2A0003 for ; Tue, 8 Jul 2025 12:12:22 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qpswLP0u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sJlQRrkd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ng1zuW7r; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7fDkh8ds; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751976743; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jvXwVBSd1AJJG+tu7OkjqSWOH8Ox3gBNgCJ8ii7IyfU=; b=77/xjiqbdm4HPlzIBl0NiCS0C+waNHL+efJQJqbzHOouIbtyRETbMCY3qfxCGP7D9IbOrV d6ReBq8OsoNOD9lp64+RMbqkUiXjaT9WrCuIxoKZfhjUyP7AB2W6Y4jyWGMgAHMQ3dzF9b DfJzxNzidryYVA8rHVEnMDF4ioppHTE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qpswLP0u; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=sJlQRrkd; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ng1zuW7r; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=7fDkh8ds; spf=pass (imf25.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751976743; a=rsa-sha256; cv=none; b=RN0aqtm8Mp9seNOvUsFhb/9Zg524z/x2a7Grwl1GNRZsPFDsNfuc7IBWqc3x6i4IEKTst9 baGf0jZ6ISCwYSvuTW3MxhEtmcVMY46pUTULZDqUzYWCdIjKD2aSSs+CmJSqQKXabWkH58 Qa34oAHl4vX+wqvn9cwTw/UUF6BpFW4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C0B131F38D; Tue, 8 Jul 2025 12:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1751976741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jvXwVBSd1AJJG+tu7OkjqSWOH8Ox3gBNgCJ8ii7IyfU=; b=qpswLP0uPO9lmq5Apj4Tp5+Qcs4bOnbnVZ/y8iM3w5CaGnwImRZZseMjkWnvTsEpJ6qW9F 83e8W11gE+5ynBU82by9/yuIy6BRr/Bat9mVNhydxgRIZUAFkopS8zIy65PcK5CXOOi8+2 TwCZXC07pI/UxJ+fEPjlRmDFUggJOhk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1751976741; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jvXwVBSd1AJJG+tu7OkjqSWOH8Ox3gBNgCJ8ii7IyfU=; b=sJlQRrkd4R8MHahyl9fZIYW+xI8BzxFkM1ckmQKnSKm5oe+v12h+txVWYJCYKzQc9alKvN UG/ZP2ZlHoUdJlAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1751976740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jvXwVBSd1AJJG+tu7OkjqSWOH8Ox3gBNgCJ8ii7IyfU=; b=ng1zuW7r8ZN8xfc+Ui9FfbhVFudowpVdH4oCh8j7pjkcmWyP2qoPC8aCe+IjfGsIMnx/3n bYmVc6xkQjHDH4uyB2NpuhEK19UugyHEi5VLtFfjph39mz7v3kPDSUuCgU2OUjURrerNWf 7EUyNHW7UfsyBw2jQAt0K+PSeHc90cc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1751976740; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jvXwVBSd1AJJG+tu7OkjqSWOH8Ox3gBNgCJ8ii7IyfU=; b=7fDkh8dsVx+H4tqX1VEo7wG7ehiAClNUQHNDY+o/uV/ZbXZMdJiqqXzZVtZF5WxmbQPDws eRaEuojlI/8NsBCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A73C713A54; Tue, 8 Jul 2025 12:12:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id W2LSJyQLbWhfHgAAD6G6ig (envelope-from ); Tue, 08 Jul 2025 12:12:20 +0000 Message-ID: <628e8c0d-2bc5-4cc8-893a-0b8388ba98f9@suse.cz> Date: Tue, 8 Jul 2025 14:12:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 1/4] mm/vmalloc: allow to set node and align in vrealloc Content-Language: en-US To: Vitaly Wool , linux-mm@kvack.org Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org References: <20250707164755.631374-1-vitaly.wool@konsulko.se> <20250707164843.631434-1-vitaly.wool@konsulko.se> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: <20250707164843.631434-1-vitaly.wool@konsulko.se> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B86E2A0003 X-Stat-Signature: z8p5mnu8cgr7ar71oeejks6gk61wieco X-Rspam-User: X-HE-Tag: 1751976742-622903 X-HE-Meta: U2FsdGVkX19cZjwdxweuWCMkamedx0p7eCeR4DqHhgLgX5jzwl50XzeryUKFFvKu8Yhcs4MiW7oXrhu5HgkO2Scq0fhnMxntu71OWXXsUhB5kk47ejNjpmZrv6yRA41LJmHK8yenfb5uK7Fr6QD808mMzudZd3eFjQAtx3TkRL1kUYhzjq6M4h0X93TkuGIgsMpeOL0RQ/LkUoYkrpfTtqQHOMWcfwSsRY5y1L7qcxz8nmZqHNUiqdX/ov4O+hGuzR3clsCv3NcHFEYTPsLDHsBLFgDqG3wDb+939M1tffX1Q+4Clcj3uSF1bSxfFkb28Or8ifit2IjR2CND/I7N6hHQge78DCoJeO0l5udWdYN2dX5En35u2u42u8ceCrHf12ie7Atn/vTi4SJ76gKdw8jF9B1Rv/2VDWIw2KRtSqA2bJxCqRFrv/yWgdKmnK2+qJ8p/I/02Mpm2fYczq/jg/hvsHJ2rsx9P3S01aPjIptzhQ3+od7NejwOX7QanjsOszVBhZj7QYaexuKJQE9UZl8Sk9pAQEvKx1dUTW4nlu1/6DfBEIHtlSN16kT+FOpBxoiqnskfVsMd6DL/wA9yeYDiZWgQeIj4xS4FZg/NTt7GpKtJC1ymOypsOE5Kw13JdjokzH6k+qG6jN7qHPlETS9AHh8cpUHkJGsntZTkvI+fn/1IBhK86vbIf7KLoxXeYN8su/BtQgwAH9GZlm8ttm7A3PkZ/MdfN+4vykbsajX+ZDSmyyNdid8cnqgroXkJzfuAFR2NSxkBdTnjdUYNIzQl5k2KXTTFoHYrEuXzcnfrezcYMkPOJiy/y7Tc1BVfu8A2wo4jdbCNx3FbXbC6/aVDxjdyV350zQRPQQCAQb4LtVefK8kRUgwuPc2G4whqgGct3r6Nn+ZJ+QrHG7o8SLhbc2eVim22mncnkZ1kXXEB0DHO7Mi8FQy+O5jmG8+A0VYsrlfIVV8jVfLxdcM GGCe/L23 dwzRgzBHjqfahH6TYEr0ZDaWQgNtllsDH6+G7BXhuQlAetIWWvDNdeGfzdW3RXH9GT+LhM31F019KsOf92RQ5GpunHgjGkmlIocxXjDsQneb8XHKwH2GPeI91SdXgD25krAkZ4/3T0Ac5nu6YpkyNoyl0mH3E3flrnQp32OYDnZSvSIOa9XheJZ9Bi6x/2ZpOvnY+cZ7nYq/QQn6rMa/mNRTlEPuAties9nuDA0O0p5ezdyQhILe1FpyTkzuMlM7OcceMTQeijfujGrYw0gdhJjpYdanomRcJkiSWhKwN96U2snyVinTJWcd3hA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/7/25 18:48, Vitaly Wool wrote: > Reimplement vrealloc() to be able to set node and alignment should > a user need to do so. Rename the function to vrealloc_node_align() > to better match what it actually does now and introduce macros for > vrealloc() and friends for backward compatibility. > > With that change we also provide the ability for the Rust part of > the kernel to set node and alignment in its allocations. > > Signed-off-by: Vitaly Wool > Reviewed-by: Uladzislau Rezki (Sony) Reviewed-by: Vlastimil Babka Nit: > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4089,13 +4089,22 @@ void *vzalloc_node_noprof(unsigned long size, int node) > EXPORT_SYMBOL(vzalloc_node_noprof); > > /** > - * vrealloc - reallocate virtually contiguous memory; contents remain unchanged > + * vrealloc_node_align_noprof - reallocate virtually contiguous memory; contents > + * remain unchanged > * @p: object to reallocate memory for > * @size: the size to reallocate > + * @align: requested alignment > * @flags: the flags for the page level allocator > + * @nid: node number of the target node > + * > + * If @p is %NULL, vrealloc_XXX() behaves exactly like vmalloc(). If @size is > + * 0 and @p is not a %NULL pointer, the object pointed to is freed. > * > - * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If @size is 0 and > - * @p is not a %NULL pointer, the object pointed to is freed. > + * if @nid is not NUMA_NO_NODE, this function will try to allocate memory on > + * the given node. If reallocation is not necessary (e. g. the new size is less > + * than the current allocated size), the current allocation will be preserved > + * unless __GFP_THISNODE is set. In the latter case a new allocation on the > + * requested node will be attempted. > * > * If __GFP_ZERO logic is requested, callers must ensure that, starting with the > * initial memory allocation, every subsequent call to this API for the same > @@ -4111,7 +4120,8 @@ EXPORT_SYMBOL(vzalloc_node_noprof); > * Return: pointer to the allocated memory; %NULL if @size is zero or in case of > * failure > */ > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_node_align_noprof(const void *p, size_t size, unsigned long align, > + gfp_t flags, int nid) > { > struct vm_struct *vm = NULL; > size_t alloced_size = 0; > @@ -4135,6 +4145,12 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > if (WARN(alloced_size < old_size, > "vrealloc() has mismatched area vs requested sizes (%p)\n", p)) > return NULL; > + if (WARN(!IS_ALIGNED((unsigned long)p, align), > + "will not reallocate with a bigger alignment (0x%lx)\n", align)) > + return NULL; Maybe this should be mentioned in the doc comment above? > + if (unlikely(flags & __GFP_THISNODE) && nid != NUMA_NO_NODE && > + nid != page_to_nid(vmalloc_to_page(p))) > + goto need_realloc; > } > > /* > @@ -4165,8 +4181,10 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > return (void *)p; > } > > +need_realloc: > /* TODO: Grow the vm_area, i.e. allocate and map additional pages. */ > - n = __vmalloc_noprof(size, flags); > + n = __vmalloc_node_noprof(size, align, flags, nid, __builtin_return_address(0)); > + > if (!n) > return NULL; >