From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9282CC7EE2A for ; Fri, 27 Jun 2025 15:41:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AF3C6B00B9; Fri, 27 Jun 2025 11:41:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 189486B00BA; Fri, 27 Jun 2025 11:41:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09CA86B00BB; Fri, 27 Jun 2025 11:41:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED5696B00B9 for ; Fri, 27 Jun 2025 11:41:11 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB42B1D0AEE for ; Fri, 27 Jun 2025 15:41:11 +0000 (UTC) X-FDA: 83601594342.21.78AF5C8 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) by imf04.hostedemail.com (Postfix) with ESMTP id DBC1A40008 for ; Fri, 27 Jun 2025 15:41:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=A6KB+5Kr; spf=pass (imf04.hostedemail.com: domain of lance.yang@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=lance.yang@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751038870; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+uh7nr2QVWHptEpAnjQihyKbhrhglo9WQLFj8/DJXyI=; b=dgtFYz54gVT60yfV2P1llGQPh0nIkMAsslzTCp0fB3bC1u/zMKsCPn/21ErpTErtA3mtMA 3Of6ay3xfWpYFSbQGxbDwhQl0+3LnmNkxIccxEwpnAAhl07mpPAlIPcySV2PvWTol9DHMt 86jYYKSQW79UcGv4IuveQTudDGjq1TM= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=A6KB+5Kr; spf=pass (imf04.hostedemail.com: domain of lance.yang@linux.dev designates 91.218.175.181 as permitted sender) smtp.mailfrom=lance.yang@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751038870; a=rsa-sha256; cv=none; b=2EiEiQu/+5N/4/4IVNVCsKuANC7Uy1Ngx6c0MH6y8FeekN/jVKklO28exyMQ7VIux+QRC5 hsnKPKEoXA0bUrJ2i6oYT9fFIxzWI0yXhx6X35gsxfU0L/24l6RXdKkb9CzNYt978MoIk1 465vkDq8I0EXnrHvSY4JttFiv2PaC1U= Message-ID: <62c00c9e-1ba4-46dd-a6e0-18e9eee7f93a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1751038867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+uh7nr2QVWHptEpAnjQihyKbhrhglo9WQLFj8/DJXyI=; b=A6KB+5Kr3BDZXeLJWAdUA+Qbqh46nbflrRZ0WDh1vwtVvuN1LIuR639CI9SJDnT/NYa0YA zg25fHaBbEC7iCgO6lx6xBEqL2M1WksjFO/qZp2Ix/RLqTxhlX12ecDrrsLgxbCrdcQGFU BoWGakogT5WEytrx6fiUJQXNzTE0Pnc= Date: Fri, 27 Jun 2025 23:40:55 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v1 4/4] mm: remove boolean output parameters from folio_pte_batch_ext() Content-Language: en-US To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo , Lance Yang References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-5-david@redhat.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Lance Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DBC1A40008 X-Stat-Signature: hg3g8f46i5m5jwd146titdzj154gt9e1 X-HE-Tag: 1751038869-793598 X-HE-Meta: U2FsdGVkX1/Dzy7kLwzfxxSfELEYW2BOaLRP07tA4PVFddjkg3AvPat5cKJa4yDyGXfRwb1b1x4EOIuiHdCC+i28Ewp+NYt72VFfWdkV/c/wYGia+oj+gNnBEKz41LoNecAPdInOuSptR6ijjlwpq1DqfYvbSdEFUJKXU452nz07NHoe4gTdCf0PiG9NJVd+I0xribLoshCUhSppw6Rjfet/A26C4gRcjEnnjEs4dYcfREsG08CgEhGX7wTNwauQi0S0UT55MtfdlHjH7DjW7jpmY/LuBYLQJ8r3u+u4UO3Wo02CxylXRq+yhxK4oLpPyTKQTMqlS02+soDZscAsd5YVQSavfgszB9jj3nCnLY/K94HWDuIneRQFasM6X2HygG7DOST2PmXBURfCzZmNS9X8+q+4JvuzDluabMl8gb/t/zPPfPL8vQCuIgmjOn+KlQaJYkzI5II7fgXyWWQS6tIlR2+ZfwM1A2oQzM+nC2Rwm/9o14Au5BnOeJafVRre/T8aWRqjLqcxulXzdUoclxRMPc04QiGhQQoCe8IWcLaa2a5rPgp7xWPmnrng4oZUejCKuiHUH2UpI75lKJMii/+hPXAPFkfo6lgmwvRdzQxS26k9zmmzT5Dx3tK0UOTmBcHH7Q28xV/rRCXpynnKHHf9MaDIKg+T97t02Q034NKDdjsydUhKTDMW4U7rQ6t1CRb6IhaNJfsvC+eOYcPnNhCppliUtpfJylT7s3rx2fvti+Jg5ZxIr1R669S8fwmuJddIBXn83ySSQftwvhbVU1s9auTpnMxyXeQncZk4SVV0tqIh5Bm3xZlyD3vnvVJqXbdiQIqCglhZzyo53ND6KIVbk+1h2hYbVObNfF4Yket18DIBbjiIabLzSItuRQpkYRubmzXBnOspPqx8TuhKJhD0egHQy96ZmfMfA2BnF8agbGZ7CEPx/RDVyu+Rsi9OwxLVpAdjwIax4u/9h0Q DNeaPA7E 6I29I54+fXLQga0aRjI1W+QOH/zTHRubyLLJlatWHPwoCenpU+afrsAYV1uyEFhRvw3SoNgPdZUvT61E/d8vu9N1XAUpOnfjFL0w1VVSW/Bz6/EQyCryxh06/GYTL7kKoqssthKK7WL3Sxi5ooeOztNiSCU5N3/sepHPIPhEl5U2PTWPUo5OfvD6YGzn1XfifHccZQLC9upHxqONIkbLMzauUaNN2A+T1GSGkiXBoVimL80/bgM4ozo12PfPwvA1NL0U0NfwPZe4r61jG6KZn+lwFq+eSBEYH4n/Xyum6Uu0txiE3MlTJYwjf1fr01l+JQ601/cDtVfISbD42fBvNXzStdt/F2khHBDl3F/UhgBSvUPBD3eBh6irSpzvjTPIzZ9dn2vL4qW66Q78= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/27 23:11, David Hildenbrand wrote: > On 27.06.25 16:34, Lance Yang wrote: >> On Fri, Jun 27, 2025 at 7:55 PM David Hildenbrand >> wrote: >>> >>> Instead, let's just allow for specifying through flags whether we want >>> to have bits merged into the original PTE. >>> >>> For the madvise() case, simplify by having only a single parameter for >>> merging young+dirty. For madvise_cold_or_pageout_pte_range() merging the >>> dirty bit is not required, but also not harmful. This code is not that >>> performance critical after all to really force all micro-optimizations. >> >> IIRC, this work you've wanted to do for a long time - maybe even a >> year ago? > > Heh, maybe, I don't remember. > > For this user here, I realized that we might already check the existence > of any_dirty at runtime -- because the compiler will not necessarily > create two optimized functions. Ah, I see! That's a very sharp observation about the compiler's behavior ;) > > So we already have runtime checks ... instead of checking whether > any_dirty == NULL, we now simply do the merging (checking for > pte_young() instead) now. Thanks for the lesson! Lance