From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AD86C43334 for ; Wed, 20 Jul 2022 06:02:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 385DD6B0072; Wed, 20 Jul 2022 02:02:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35C1F6B0073; Wed, 20 Jul 2022 02:02:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 224476B0074; Wed, 20 Jul 2022 02:02:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 13C586B0072 for ; Wed, 20 Jul 2022 02:02:37 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DDF2B1A04C2 for ; Wed, 20 Jul 2022 06:02:36 +0000 (UTC) X-FDA: 79706433912.26.1E11FC6 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf08.hostedemail.com (Postfix) with ESMTP id 70FFE16007C for ; Wed, 20 Jul 2022 06:02:36 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id gq7so635341pjb.1 for ; Tue, 19 Jul 2022 23:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:from:to:cc:subject:references:mime-version :content-disposition:in-reply-to; bh=GOSt91VjSu2VEl8kfFKkP6kjxkw8pyT1JGZchTh4yMY=; b=GLSGwJBy1rmLnKP1MXZ0CO0xCE4X6vPyM/fWH8VRnVDjlmRGpOSwneEepnYklWVeF/ ZTjMBCl7PqNo0CMCaY60xA/3fTcMChuPwZiyEvL4cdfhGaE3Qfk4nLXpKpNnlWtspZAN d5AczfT5RwSxskHXde0l+u/3Bfi09SK9iNU5jus42l3dV6UuWVpOyUfVYAc3+qG22I/r Y9eMiV8P0EJS5SbfvAG9v7/ECoWA3YL+lHUNFpj9oa/tPLxIEygHAHEjr68zv9Dln6YV qfeagsCXbnvQ2BPk08R7ZkgsM9U4PKjG2ximOq52TlP0514aNgJGFeG8J6U4uWnlswtV OHyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:from:to:cc:subject:references :mime-version:content-disposition:in-reply-to; bh=GOSt91VjSu2VEl8kfFKkP6kjxkw8pyT1JGZchTh4yMY=; b=lnR8RNnDhYVqdEbOjBnSbQ/cn0cGepm/jsL+ODWynHgBzcsNgpIzUxi1W2XjqFGkML gc5EUzdZdtsyXyo/wjIAokxopGQkJKD2WDUnC43XRLTAsjQN2AfjhuDt+Ycg2aAygsoy mlHItsWppZBhNNhuHZOUfzMjBc8e594CavnCIxoIkb5knOPu0iRKVOR5Buqb5/hBOA+5 ml3NIgYVmLOM/GeTPfTrXws0UTX0cIPB7yevLVWqfSRnMKfa556TLDomNmNI3tS6TCE9 joykrpz50o3lmosB3QIilMj7g3lBqcGo88liL54/D30YxNittdXIrnFGO5iPScKzkIZ+ A6Ug== X-Gm-Message-State: AJIora/J/ZP5ItcT6bCsDEjFH9QREJprVdeKsg5P+7pcUy7CzbfImcsE 8T+u9m9UKCV3hDI4TgHPens= X-Google-Smtp-Source: AGRyM1vERw1W/biXDH3FHaCl6/KCF9/jCHaZI3rf3jbENK8Cgsc77M9GgyGmnnEQZwZZ9eOL6dkDNw== X-Received: by 2002:a17:90a:5513:b0:1f1:c93c:7ad8 with SMTP id b19-20020a17090a551300b001f1c93c7ad8mr3483937pji.88.1658296955363; Tue, 19 Jul 2022 23:02:35 -0700 (PDT) Received: from localhost ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id k4-20020a170902c40400b0016782c55790sm12961802plk.232.2022.07.19.23.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 23:02:33 -0700 (PDT) Message-ID: <62d79a79.1c69fb81.e4cba.37f5@mx.google.com> X-Google-Original-Message-ID: <20220720060232.GA1496592@cgel.zte@gmail.com> Date: Wed, 20 Jul 2022 06:02:32 +0000 From: CGEL To: Matthew Wilcox Cc: viro@zeniv.linux.org.uk, hughd@google.com, akpm@linux-foundation.org, hch@infradead.org, hsiangkao@linux.alibaba.com, yang.yang29@zte.com.cn, axboe@kernel.dk, yangerkun@huawei.com, johannes.thumshirn@wdc.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ran Xiaokai Subject: Re: [PATCH] fs: drop_caches: skip dropping pagecache which is always dirty References: <20220720022118.1495752-1-yang.yang29@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GLSGwJBy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658296956; a=rsa-sha256; cv=none; b=4tCfH/0XZLqEOaBMT9NjwAbXU4lB4ZeTy/oZpbIQPpAkIXcUKiJDE36FSsfr2FoSEAgiA2 eF3PixlqUiUEY47ZdireanEaKHJ9EMNtujkFHaxsvc4P+rIQ2lEb5mAlpNWPua9ObjNNZz soSqu9MpTadZ7dSZVxhrPAAsTFXKWZk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658296956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GOSt91VjSu2VEl8kfFKkP6kjxkw8pyT1JGZchTh4yMY=; b=Plh0ANy8FEll3O5LJ26jj8aAumld9stmhsjF40y6k+OuMPHYmt5gN8YAABaxoy9fRpkztm WKzkHURDb6zk+Ko4ejl7iMo09mZjvKiju+WzHoTSrFzLQWomVF5epqyKGSwGX4dl4d3Vox TAYIjzRIfcYLw8jxOPEbcn3sAqKFdTM= X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 70FFE16007C Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=GLSGwJBy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of cgel.zte@gmail.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=cgel.zte@gmail.com X-Stat-Signature: i43jq394fian6rc9ymjdxp8y7otogybu X-HE-Tag: 1658296956-436219 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 20, 2022 at 04:02:40AM +0100, Matthew Wilcox wrote: > On Wed, Jul 20, 2022 at 02:21:19AM +0000, cgel.zte@gmail.com wrote: > > From: Yang Yang > > > > Pagecache of some kind of fs has PG_dirty bit set once it was > > allocated, so it can't be dropped. These fs include ramfs and > > tmpfs. This can make drop_pagecache_sb() more efficient. > > Why do we want to make drop_pagecache_sb() more efficient? Some users may use drop_caches besides testing or debugging. For example, some systems will create a lot of pagecache when boot up while reading bzImage, ramdisk, docker images etc. Most of this pagecache is useless after boot up. It may has a longterm negative effects for the workload when trigger page reclaim. It is especially harmful when trigger direct_reclaim or we need allocate pages in atomic context. So users may chose to drop_caches after boot up.