From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF66C7EE30 for ; Wed, 2 Jul 2025 09:11:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D5746B00BC; Wed, 2 Jul 2025 05:11:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6861D6B00BE; Wed, 2 Jul 2025 05:11:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5275D6B00BF; Wed, 2 Jul 2025 05:11:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 3F9D96B00BC for ; Wed, 2 Jul 2025 05:11:26 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C2AF5124820 for ; Wed, 2 Jul 2025 09:11:25 +0000 (UTC) X-FDA: 83618756130.14.6E56680 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id D166F10000A for ; Wed, 2 Jul 2025 09:11:21 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OrGlsZhl; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751447483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gB2c1lvXTPUU8lAcDb8yV8BpUQhaQDga1PKrbM3zRiE=; b=NJS+zretKp4Q7Jge+jLhh9nRp/4/StviF6hrusvaEMf5sdVbeRq1HQRruBh1lEL+mH0ecZ QC6JXN5JPX93vA7zr/x45l/ysb5uTM68yFycnBdbWRAjI1fqfdxjsiFizhGEu8dimUc6nn 0EG1yLNaEZ5qtssXuPhm2paUIXrT9hg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OrGlsZhl; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751447483; a=rsa-sha256; cv=none; b=vA19pY8k5zhB+4zhxPovNHbJOk6oI6q6PRy6TBjXcxgNXsa3zDgIKbS47Pkxg3SzNzv25w 5BCntElOeFycEBmLE13hVbiUOJoYcriDqhI3WaH0pJOYpVS7y6uAD55GwxCS4Shr3kgHR8 hqW6CftTQTD45kc7eF3eIOuXanF0S98= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751447481; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gB2c1lvXTPUU8lAcDb8yV8BpUQhaQDga1PKrbM3zRiE=; b=OrGlsZhlXshYVfbkyqiZvNWvH2XHqk4+SsSKWHXGDi6B2afsLFQfNFhfZifmMb32ZzV5ZB +Mr6Ol7w/K4qEePLWhYQQzTINkj++ejF1nJ0QfY/wc0ZwusHAnbGk5Jw6i65ZtTEVjAqoO Mdx+/2+8scld4pqDKjg1CXfNesjp9Eg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-rinWU92DN1yeWUJNLBGg5Q-1; Wed, 02 Jul 2025 05:11:19 -0400 X-MC-Unique: rinWU92DN1yeWUJNLBGg5Q-1 X-Mimecast-MFC-AGG-ID: rinWU92DN1yeWUJNLBGg5Q_1751447478 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450d64026baso35322665e9.1 for ; Wed, 02 Jul 2025 02:11:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751447478; x=1752052278; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gB2c1lvXTPUU8lAcDb8yV8BpUQhaQDga1PKrbM3zRiE=; b=Uu7eJQF+l1Gi7E/3rc0m2Gcr8+yWAGFa/9U97FhVEarnL0drg8IzJOIUFXHWwgI3QQ D7SGgoaJ4uM0ReryFGuFNHXgwA51Tw7Qh+VcZWNhQXJJRduZNWwBXwPjCueStc1Ri1zf +VzT6QWlDipGS8GZ9fk4um0Vdw1+MMn5/qqPTLGZEPNABltqRkC7QPhOrMm3GpE2r46x /ecvXqqeTNLPiEzzUe5uQMQhwMsrg8QTkKE9+G1C8GoQs1W0prvcGi8ThTY7C7L2zGsP M+HWk2HdGA5Z3kvmQTJYg3foDOi30SHc+aJnNVpG7tyclMaq6PKy9uDspFxozyOfk3iP k5GA== X-Forwarded-Encrypted: i=1; AJvYcCWHK5Dj2+WHqWqHp2jGTzdHjA8NWKScgGZ+h8wdKj5HR83CFt73T+Vi4wzoI23O5btgW2Us4DAOig==@kvack.org X-Gm-Message-State: AOJu0Ywwj9IQh2E/z5o/3kopCJSCr3uDKs0XipN8adeb/JnQIrbNtePu 57m4CD7ocJaePiHe4nXKau3Ut1n/iR2B6TkQvtXJ+bXRUxAmXI02/7rFVUVVo7zCeHEaqUolPom hu6yenpl1qLG6V2Yw1pvRvtbhIHxtJBLkUGSZucjV1++aJiiPpfl/ X-Gm-Gg: ASbGncukodDSb67nVLYNSBW9s2MGcmdOVNt+sBzQDk5qXN56gPXdsunuGhSTZ/vhGZ2 xPmjzVndl3pstkyCmJpysJsBesRTv/o33c3lsOSxEuBUISAOxoNKDies26GUxDGhIbBJQLl0no9 Oe2C6ye2CKKY9WMzQOicubgtEx4n9VoIOiBCQNR/gHl1STE4EmQyAXGSPl7vFj5p+Bkz52jnI0H jKREtMYdqiUGLcdbC8Op6464Fls8ICtg9X/kXCwzh0BD4FDD3DmIxeCPXkJbQ5XahZ+Ea/m1g7k nY5BBkVlsZk7FDWhnSDGyOObszyHAT054u5Hmxpr2zt7FZTTD9ZDg2Q= X-Received: by 2002:a05:600c:1d0e:b0:450:cabd:160 with SMTP id 5b1f17b1804b1-454a36db2d5mr26787795e9.3.1751447477661; Wed, 02 Jul 2025 02:11:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAa4JTgVrvR64TMcVsUpXXyzC4HELXqfdtWbSrzoZ98bvqmNaf5eKbrOurVw/r1QXRfTvtWg== X-Received: by 2002:a05:600c:1d0e:b0:450:cabd:160 with SMTP id 5b1f17b1804b1-454a36db2d5mr26787195e9.3.1751447477093; Wed, 02 Jul 2025 02:11:17 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4538a390d55sm196824095e9.6.2025.07.02.02.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 02:11:16 -0700 (PDT) Message-ID: <62da3059-ee1f-4ec7-a7e3-af5153044d91@redhat.com> Date: Wed, 2 Jul 2025 11:11:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] mm: smaller folio_pte_batch() improvements To: Lorenzo Stoakes Cc: Oscar Salvador , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Pedro Falcato , Rik van Riel , Harry Yoo References: <20250627115510.3273675-1-david@redhat.com> <20250627115510.3273675-3-david@redhat.com> <1d98e96b-4bc9-45c1-9861-e0f3c5930ec2@redhat.com> <753a8900-d9ff-436c-8758-17d363967b30@lucifer.local> <6092c44e-8800-47ec-9cfb-a1f062ea122a@redhat.com> <14e4407c-11b2-42bf-aa63-343762018877@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <14e4407c-11b2-42bf-aa63-343762018877@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MWHiBEDOk_fC47v999ZnJF8bpmsv04Mqb40JV-xTbh4_1751447478 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D166F10000A X-Stat-Signature: 5oepu46ze7onnphxe4njgpuw5zxz4zoo X-HE-Tag: 1751447481-409054 X-HE-Meta: U2FsdGVkX19vK4pqBM/X6jsLllHE9cfQSH3CQNixI3rxZZntOHuRxbI3g1XjxTDUEOybL3Yr/1kWllHp/FZ4zhlRvsahPEEjzV4tiGb4hRpFuOX9oJiBjl10wGnhzC60ka4G2Nysf0hYH6dDd6TDKrPQf7/UZAvM/Xk6c4djq6DJix/7iII48efp4HCAmZFesq7ZU5/NA+on6NAHUdC/I2dLDGU8dUYyXFNThTG/CQiooby1RkkJS2gGlgDp6M5JaA1V5RdY4Tjxafpt6/+Arcxr/Yoiy+Ruftba1RUwm5OkfOZ8uQx3uEKoIE1fdDKeO6fT27Oy6gzr54mEcOj4aEC4GgmNmeranN90dJBKdk9GVswOclAtFiECRvVmvuWtj+a2jZWDmyOqNDlmBS92vSTVsd16vTKJDMMz24J2Vn0hZugyGXBp3V8vYa9aUcBzkVQwgK7bQPo9fVx4lAfdDz0ZdXoffaT4Vz4+nr4JR0hmx6TGUEpem0DIQks3GOKiWNRZ9K6OdUrj//IM7mo9E6hJwBoZgeKrSUliunbsSt3ykQwzfcaIcZ7tSqYncdsEV0WhyW+uQVO81cQMNRVcPIu6GalC5DgDPf2+5GjB8UcTb9vIZ+N2/ZiqsSPTpr+MYJjAf2nEuQzNveYxKsoC/h/SIqTyhJf7OfI81T8BeqJqSm44qPK1g+99iahGK96HqNdjru51yl9BmZLHrfnZ1VHIEXgYM6UDrtUkKxwEQmcIf4Dkr+Qsy7x3OSPi9tWcANc+ZK33DD42Mjx1HHi8zEbCz+l9johFd3G4WkVMCnl1JaRhWHHZqCllqWiNkwSJ5NVDGuwipE/efkec6LECoxUxVUjT5FZ5DRTxh75Mesxm3sQB/y4NfFC5ZMVptWHEEXbuntdSa9gsOAt7oXikytfIhoP5bSTHohH3WSQeCeIj28Q1JiN4zg4AwvlCb/psZBtuVKz0qOnyUTg+dRv SvjMbLFa QCAYn9goM9Oeg5vQeIegDNBqVRFR075g2B5LUdIbiuJlZpn5x4nPqp4vT0WF6wDKOF/diBXTHKI4kwCdTgRgLTpcl+9vjXd9V9SG4JZhKZSXMUzPBSzh0YaILlOWpgm7pOZUlKQ38qdz+UvhzdE35Pa9S6wQzj6TxFuZOF1T5HpE8noZ8REVofIG5gtEXVeTZJVj0uqF4wAY2ZYGdVA8QSybyWBYYPsxLtedbgVQtWv5c/6gfn68Uoe2j8dD6mVoN2oNvrTbqZw6Rpbw03xdDA3lazLO3VgI6h8cIWWkmwlMKonJ/m0pAjADEYSCZOahE1RiwMn/Y9I18tV9Nu3YKf0+yavlsWEKY8MS2wcS5KQu8liFAcHf/hDQRV1vJSTELtYMLya6vmmFoWP4qK4rP0dtFf/AvZ56RQgUc9i7fU+dgEb4MfOqCok/vKnk75CEybhzot3jawHHNIkurC6+W3csEU62PBTBWmpgslpBDug3OikAgb6KsqwTo2Dh/MENgCO3P/uw48982IWKiiimvACOx36jXvGcXnRnum2snD01Hp9JoLtetW0duDDqLQfFbMKWn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.07.25 11:08, Lorenzo Stoakes wrote: > On Wed, Jul 02, 2025 at 11:00:48AM +0200, David Hildenbrand wrote: >> On 02.07.25 10:51, Lorenzo Stoakes wrote: >>> On Wed, Jul 02, 2025 at 10:48:20AM +0200, David Hildenbrand wrote: >>>> On 02.07.25 10:42, Oscar Salvador wrote: >>>>> On Fri, Jun 27, 2025 at 01:55:08PM +0200, David Hildenbrand wrote: >>>>>> Let's clean up a bit: >>>>>> >>>>>> (1) No need for start_ptep vs. ptep anymore, we can simply use ptep >>>>>> >>>>>> (2) Let's switch to "unsigned int" for everything >>>>>> >>>>>> (3) We can simplify the code by leaving the pte unchanged after the >>>>>> pte_same() check. >>>>>> >>>>>> (4) Clarify that we should never exceed a single VMA; it indicates a >>>>>> problem in the caller. >>>>>> >>>>>> No functional change intended. >>>>>> >>>>>> Signed-off-by: David Hildenbrand >>>>> >>>>> Hi David :-), >>>>> >>>>> I have to confess that I fell in the same trap as Lorenzo wrt. >>>>> __pte_batch_clear_ignored changing the pte value. >>>>> So I'm not sure if it would be nice to place a little comment in >>>>> __pte_batch_clear_ignored claryfing that pte's value remains unchanged ? >>>> >>>> I mean, that's how all our pte modification functions work, really? :) >>>> >>>> Thanks! >>> >>> I mean, it might be that me and Oscar are similarly 'challenged' in this >>> respect :P (high 5 Oscar!) but I think the issue here is that it's sort of >>> a compounded use, and in fact some functions do modify stuff, which is why >>> we end up with all the ptep ptent etc. fun. >>> >>> Up to you re: comment, but I think maybe in cases where it's a reallly >>> compounded set of stuff it's potentially useful. >>> >>> But obviously we still do do this all over the place elsewhere with no >>> comment... >> >> Well, if you are not passing in a *value* and not a pointer to a function, >> you would not expect for that *value* to change? :) >> >> Yes, once we pass pointers it's different. Or when we're using weird macros. >> >> Adding a comment that a function will not modify a value that is ... >> passed-by-value? Maybe it's just me that doesn't get why that should be >> particularly helpful :) > > I think the issue is that we've passed around 'pte' as value and pointer (and of > course, via macros...) previously so that's the cause of the confusion, often. > > This is why I really am a fan of us consistently saying ptep when passing a > pointer. 100%: pte for pointers is absolutely nasty. -- Cheers, David / dhildenb