From: Laurent Dufour <ldufour@linux.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: cheloha@linux.ibm.com, David Hildenbrand <david@redhat.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux-MM <linux-mm@kvack.org>, Michal Hocko <mhocko@suse.com>,
mm-commits@vger.kernel.org, nathanl@linux.ibm.com,
Oscar Salvador <osalvador@suse.de>,
Rafael Wysocki <rafael@kernel.org>,
stable <stable@vger.kernel.org>, Tony Luck <tony.luck@intel.com>
Subject: Re: [patch 8/9] mm: replace memmap_context by meminit_context
Date: Tue, 29 Sep 2020 18:28:51 +0200 [thread overview]
Message-ID: <6300fe4c-d54e-8f99-ccf8-216f15cde4fb@linux.ibm.com> (raw)
In-Reply-To: <CAHk-=wjcg4ni8_zhGDS9vTQQYM-3ZBg4hGF7Ot9MzW5F2o7mpA@mail.gmail.com>
Le 26/09/2020 à 19:32, Linus Torvalds a écrit :
> The explanations here do not make sense.
>
> On Fri, Sep 25, 2020 at 9:19 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>>
>>
>> There are 2 issues here:
>>
>> a. The sysfs memory and node's layouts are broken due to these multiple
>> links
>>
>> b. The link errors in link_mem_sections() should not lead to a system
>> panic.
>>
>> To address a. register_mem_sect_under_node should not rely on the system
>> state to detect whether the link operation is triggered by a hot plug
>> operation or not. This is addressed by the patches 1 and 2 of this series.
>>
>> The patch 3 is addressing the point b.
>>
>> This patch (of 2):
>>
>> The memmap_context enum is used to detect whether a memory operation is due
>> to a hot-add operation or happening at boot time.
>>
>> Make it general to the hotplug operation and rename it as meminit_context.
>>
>> There is no functional change introduced by this patch
>
> So far so good.
>
> But there is no "patch 3" that addresses point (b) in this series.
>
> I see it on lore, but it's not part of what actually got sent to me,
> so the commit message for patch 1 now makes no sense any more.
I agree, the commit description is a bit confusing now.
I think the Andrew's idea was to queue up the 2 first patches which are
cc:stable to the 5.9-rcX and later the third one which is not really fixing an
issue. The BUG_ON is unlikely to be triggered once the 2 first patches are applied.
Thanks,
Laurent.
next prev parent reply other threads:[~2020-09-29 16:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 4:17 incoming Andrew Morton
2020-09-26 4:19 ` [patch 1/9] mm, THP, swap: fix allocating cluster for swapfile by mistake Andrew Morton
2020-09-26 4:19 ` [patch 2/9] mm: memcontrol: fix missing suffix of workingset_restore Andrew Morton
2020-09-26 4:19 ` [patch 3/9] mm/gup: fix gup_fast with dynamic page table folding Andrew Morton
2020-09-26 4:19 ` [patch 4/9] mm/migrate: correct thp migration stats Andrew Morton
2020-09-26 4:19 ` [patch 5/9] lib/string.c: implement stpcpy Andrew Morton
2020-09-26 4:19 ` [patch 6/9] lib/memregion.c: include memregion.h Andrew Morton
2020-09-26 4:19 ` [patch 7/9] arch/x86/lib/usercopy_64.c: fix __copy_user_flushcache() cache writeback Andrew Morton
2020-09-26 4:19 ` [patch 8/9] mm: replace memmap_context by meminit_context Andrew Morton
2020-09-26 17:32 ` Linus Torvalds
2020-09-29 6:55 ` Michal Hocko
2020-09-29 16:28 ` Laurent Dufour [this message]
2020-09-29 20:37 ` Andrew Morton
2020-09-30 16:00 ` Linus Torvalds
2020-09-30 17:30 ` Michal Hocko
2020-09-26 4:19 ` [patch 9/9] mm: don't rely on system state to detect hot-plug operations Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6300fe4c-d54e-8f99-ccf8-216f15cde4fb@linux.ibm.com \
--to=ldufour@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cheloha@linux.ibm.com \
--cc=david@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mm-commits@vger.kernel.org \
--cc=nathanl@linux.ibm.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).