From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BA7C32772 for ; Tue, 23 Aug 2022 09:37:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 362308D0002; Tue, 23 Aug 2022 05:37:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 311368D0001; Tue, 23 Aug 2022 05:37:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D96D8D0002; Tue, 23 Aug 2022 05:37:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0EA788D0001 for ; Tue, 23 Aug 2022 05:37:03 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D7B4714150F for ; Tue, 23 Aug 2022 09:37:02 +0000 (UTC) X-FDA: 79830353484.08.EA86C90 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 2CEB41C0018 for ; Tue, 23 Aug 2022 09:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661247421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nEnl5FVShRbfX9bxOxgHI5l05EhEroNOdj3tfZ7Zdw4=; b=KPr+v4N14J8j8Z+FrqUU4hZqN5gqiKINTg0/TF5PC+fQP4jpHVGCl/SNWTRQx/jDCYWlrB VEyDU1XWe+iurKOyhvovEbYKlMZNJaVVrdgVdhU0MIknkyugcj30qMVH0kUgTcTyht8de6 Imt9VJCFGSOuTg5U33OlrFgA56nQpiE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-591-Pyk667LYPhGakhjFjaKJOQ-1; Tue, 23 Aug 2022 05:37:00 -0400 X-MC-Unique: Pyk667LYPhGakhjFjaKJOQ-1 Received: by mail-wm1-f69.google.com with SMTP id i7-20020a1c3b07000000b003a534ec2570so8492351wma.7 for ; Tue, 23 Aug 2022 02:37:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=nEnl5FVShRbfX9bxOxgHI5l05EhEroNOdj3tfZ7Zdw4=; b=VQ1x9tr78HigcNIla5P7htlzDwMGr55MmF0jWGrHTDurQhxCuG1if3ZjMUudiNdQ/4 7ufl7mQUzb0izxG5eg4Nu7AuEpLXAhtNOA4LaxYJayJr4WZNoot2of8YOTIX8Z8dVilL OgOvENDYb39w2vqpERabYkK7QicfJpLdWnXowNDS+HRAJgOdnqEHdL5W5337a6/4abXM pelI1YeCKSdvst9Y0wl3JIr0tUQhzZwi1WJOxBCj0XvAhKIFsOmUW7u3Zw/5302BW/49 ys4Fii7z+ajletyRQxM7ww3Fgx80fRija1FtHQOhLm91UiE6nxtu31WcT89zRl/RSOID xU3Q== X-Gm-Message-State: ACgBeo2xHSpouUkgFZRis1BNpeTDEFrN3QdbJee/nWqG6/c0WToLfjFK uGgveUXY9Bszy5UsPN5VYNprLWBdpEjMj/f9K5U8Xr8R+jZWiFUoYIiP93GAU+PgHGAb763Mj6t vhtkeajtmjnI= X-Received: by 2002:a05:6000:15ca:b0:225:4575:746d with SMTP id y10-20020a05600015ca00b002254575746dmr7719039wry.147.1661247419138; Tue, 23 Aug 2022 02:36:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR7XJsJFK4+5+04kPo9xzd7r7glHujIb/q9IfHO4DPFp9HoQNR1VaEwbfBReHf1AjZ2VMxslEw== X-Received: by 2002:a05:6000:15ca:b0:225:4575:746d with SMTP id y10-20020a05600015ca00b002254575746dmr7719028wry.147.1661247418852; Tue, 23 Aug 2022 02:36:58 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:1600:c48b:1fab:a330:5182? (p200300cbc70b1600c48b1faba3305182.dip0.t-ipconnect.de. [2003:cb:c70b:1600:c48b:1fab:a330:5182]) by smtp.gmail.com with ESMTPSA id l18-20020a5d5612000000b0021ee65426a2sm13599193wrv.65.2022.08.23.02.36.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 02:36:58 -0700 (PDT) Message-ID: <6382c2d4-ac0b-644e-4c69-8650afe30bb9@redhat.com> Date: Tue, 23 Aug 2022 11:36:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/8] memblock tests: update tests to check if memblock_alloc zeroed memory To: Rebecca Mckeever , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Shaoqin Huang References: <669782f4f508c3dd60c5efd6d130d12a77573448.1660897732.git.remckee0@gmail.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <669782f4f508c3dd60c5efd6d130d12a77573448.1660897732.git.remckee0@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KPr+v4N1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661247422; a=rsa-sha256; cv=none; b=iLGDoHcxWDwlefjaVv9tYmP8p9QGXCSjey8RNGVlKosoS6ZOCYzkMIiEcL/RbN4DhEMUdW JePrARLnA560PTWNe/zcOIPYD94GrDkLx6pXCoX9fOFayt4rqCHiyj8lVpFdr3ysjnhUVQ jct5UKbunIsNz7V+siR6C7l/7IaYIIs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661247422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nEnl5FVShRbfX9bxOxgHI5l05EhEroNOdj3tfZ7Zdw4=; b=Yz5B9qu1mQj0j0yh/ljSZgFTUhDIXpdvJd2mFcnW/52T7VG1cNk7QAd1+3YhJ58yiMQD/L L0h9bnoO4wRwlyB6MPzJ+a/sMdt1d+/RKJJx2sA+rtTpRInukuE3lwZjkZQrkF54DQOxJt Go7VqqsuDNovDqJng/6ufgK9PImXLfE= X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KPr+v4N1; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Stat-Signature: hswc3j7qoc6mmd6eshttxti5pwau9kcq X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2CEB41C0018 X-HE-Tag: 1661247422-148443 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.08.22 10:34, Rebecca Mckeever wrote: > Add an assert in memblock_alloc() tests where allocation is expected to > occur. The assert checks whether the entire chunk of allocated memory is > cleared. > > The current memblock_alloc() tests do not check whether the allocated > memory was zeroed. memblock_alloc() should zero the allocated memory since > it is a wrapper for memblock_alloc_try_nid(). > > Reviewed-by: Shaoqin Huang > Signed-off-by: Rebecca Mckeever Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb