From: Kevin Brodsky <kevin.brodsky@arm.com>
To: Hongfu Li <lihongfu@kylinos.cn>,
akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org,
liam@infradead.org, vbabka@kernel.org, rppt@kernel.org,
surenb@google.com, mhocko@suse.com, shuah@kernel.org
Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, keith.lucas@oracle.com,
maddy@linux.ibm.com, usama.anjum@collabora.com,
yury.khrustalev@arm.com, jhubbard@nvidia.com, joey.gouly@arm.com,
zwisler@google.com, hongfu.li@linux.dev
Subject: Re: [PATCH v8 1/5] selftests/mm: move pkey selftest helpers to pkey_util.c
Date: Wed, 1 Jul 2026 10:46:30 +0200 [thread overview]
Message-ID: <63a70282-0d9d-489b-ae70-436901e6bf70@arm.com> (raw)
In-Reply-To: <20260630073235.3802271-2-lihongfu@kylinos.cn>
On 30/06/2026 09:32, Hongfu Li wrote:
> [...]
>
> diff --git a/tools/testing/selftests/mm/pkey_util.c b/tools/testing/selftests/mm/pkey_util.c
> index 255b332f7a08..abf708d6575e 100644
> --- a/tools/testing/selftests/mm/pkey_util.c
> +++ b/tools/testing/selftests/mm/pkey_util.c
>
> [...]
>
> +void abort_hooks(void)
> +{
> + fflush(stdout);
> + fprintf(stderr, "running %s()...\n", __func__);
> + tracing_off();
> +#ifdef SLEEP_ON_ABORT
> + sleep(SLEEP_ON_ABORT);
> +#endif
> +}
Definitely an improvement to move this to pkey_util.c. We still have
multiple functions declared in pkey-helpers.h and defined in
protection_keys.c (which clearly doesn't make sense), but this is a step
in the right direction.
Reviewed-by: Kevin Brodsky <kevin.brodsky@arm.com>
next prev parent reply other threads:[~2026-07-01 8:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 7:32 [PATCH v8 0/5] selftests/mm: refactor pkey helpers and fix mmap error handling Hongfu Li
2026-06-30 7:32 ` [PATCH v8 1/5] selftests/mm: move pkey selftest helpers to pkey_util.c Hongfu Li
2026-07-01 8:46 ` Kevin Brodsky [this message]
2026-06-30 7:32 ` [PATCH v8 2/5] selftests/mm: unify pkey sighandler selftest assertions and tracing Hongfu Li
2026-07-01 8:48 ` Kevin Brodsky
2026-07-01 10:33 ` Hongfu Li
2026-06-30 7:32 ` [PATCH v8 3/5] selftests/mm: use pkey_assert on clone_raw failure in pkey test Hongfu Li
2026-07-01 8:48 ` Kevin Brodsky
2026-06-30 7:32 ` [PATCH v8 4/5] selftests/mm: add missing mmap() return checks in pkey tests Hongfu Li
2026-07-01 8:48 ` Kevin Brodsky
2026-06-30 7:32 ` [PATCH v8 5/5] selftests/mm: add missing pthread_create() " Hongfu Li
2026-07-01 8:49 ` Kevin Brodsky
2026-06-30 17:56 ` [PATCH v8 0/5] selftests/mm: refactor pkey helpers and fix mmap error handling Mike Rapoport
2026-06-30 19:05 ` Liam R. Howlett
2026-07-01 5:20 ` Andrew Morton
2026-07-01 6:59 ` Kevin Brodsky
2026-07-01 9:33 ` Hongfu Li
2026-07-01 15:12 ` Kevin Brodsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63a70282-0d9d-489b-ae70-436901e6bf70@arm.com \
--to=kevin.brodsky@arm.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=hongfu.li@linux.dev \
--cc=jhubbard@nvidia.com \
--cc=joey.gouly@arm.com \
--cc=keith.lucas@oracle.com \
--cc=liam@infradead.org \
--cc=lihongfu@kylinos.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mhocko@suse.com \
--cc=rppt@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=usama.anjum@collabora.com \
--cc=vbabka@kernel.org \
--cc=yury.khrustalev@arm.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox